• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Whitespace cleanup

Avoid message keys from packages outside the dependency tree, provide a way to customize the proctoring session name

    • -1
    • +1
    ./proctoring-support/lib/proctored-page.adp
    • -0
    • +2
    ./proctoring-support/lib/proctored-page.tcl
Prefer a message key in the dependency tree of this package

    • -1
    • +1
    ./proctoring-support/lib/proctoring-display.adp
Whitespace cleanup

    • -11
    • +11
    ./notifications/tcl/notification-type-procs.tcl
Use quicker idiom to check for existance

    • -2
    • +7
    ./notifications/tcl/notification-request-procs.tcl
    • -9
    • +0
    ./notifications/tcl/notification-request-procs.xql
Whitespace cleanup

    • -3
    • +3
    ./notifications/tcl/notification-display-procs.tcl
    • -3
    • +3
    ./notifications/tcl/notification-reply-procs.tcl
Whitespace changes

    • -3
    • +3
    ./notifications/tcl/delivery-method-procs.tcl
Prefer api to retrieve the approval state of a user

    • -2
    • +2
    ./notifications/tcl/notifications-security-procs.tcl
    • -14
    • +0
    ./notifications/tcl/notifications-security-procs.xql
Complete coverage for the notification package

    • -0
    • +247
    ./notifications/tcl/test/notifications-test-procs.tcl
Brutally delete the notification requests before deleting the delivery method (it's fine because it will be rolled back)

    • -0
    • +1
    ./notifications/tcl/test/notifications-test-procs.tcl
Fix issue in the query logics: we actually want to check the owner of the request, there might be multiple requests associated to the same object

    • -6
    • +6
    ./notifications/tcl/notifications-security-procs.tcl
    • -1
    • +10
    ./notifications/tcl/test/notifications-test-procs.tcl
Extend coverage, this will expose an api bug

    • -0
    • +179
    ./notifications/tcl/test/notifications-test-procs.tcl
added proper handling of overfull recurrence rule lines

    • -3
    • +4
    ./caldav/tcl/caldav-interface-procs.tcl
added proper handling of overfull recurrence rule lines

Whitespace cleanup

    • -34
    • +34
    ./caldav/tcl/caldav-interface-procs.tcl
Port of downstream commit by Markus Moser: do not use pg query parser to substitute user_id because substitution will take place at a time when :user_id is not available anymore

    • -3
    • +3
    ./caldav/tcl/caldav-interface-procs.tcl
According to thr RFC, there is no need to specify single quotes in the BYDAY rule, also because in some cornercase, they might produce a line longer than 76 characters

See https://datatracker.ietf.org/doc/html/rfc5545

Fixes downstream automated tests

    • -1
    • +1
    ./caldav/tcl/caldav-interface-procs.tcl
Whitespace cleanup

    • -75
    • +75
    ./caldav/tcl/test/caldav-test-procs.tcl
Whitespace changes

    • -26
    • +25
    ./notifications/www/request-notification.tcl
Extend coverage

    • -1
    • +27
    ./notifications/tcl/test/notifications-test-procs.tcl
Cover more api

    • -0
    • +42
    ./notifications/tcl/test/notifications-test-procs.tcl
Extend automated tests

    • -0
    • +124
    ./notifications/tcl/test/notifications-test-procs.tcl
Allow to specify a user that does not come from the connection

    • -2
    • +7
    ./notifications/tcl/notification-display-procs.tcl
Expand tests

    • -2
    • +80
    ./notifications/tcl/test/notifications-test-procs.tcl
Improve test a bit

    • -2
    • +9
    ./notifications/tcl/test/notifications-test-procs.tcl
Update documentation to best practices

    • -10
    • +8
    ./notifications/tcl/notification-display-procs.tcl
Fix proc signature

    • -1
    • +1
    ./assessment/tcl/as-apm-checks-procs.tcl
    • -2
    • +2
    ./dotlrn-forums/tcl/dotlrn-forums-procs.tcl
    • -2
    • +2
    ./dotlrn-news/tcl/dotlrn-news-procs.tcl
    • -2
    • +2
    ./notifications/tcl/notification-procs.tcl
    • -1
    • +1
    ./notifications/tcl/test/notifications-test-procs.tcl
    • -1
    • +1
    ./notifications/www/request-notification.tcl
Replace leftover occurrences

    • -2
    • +2
    ./notifications/tcl/notification-procs.tcl
    • -1
    • +1
    ./notifications/www/admin/sweep-now.tcl
Deprecate notification::get_delivery_method_id, same as notification::delivery::get_id and looking more established

    • -1
    • +1
    ./assessment/tcl/as-apm-checks-procs.tcl
    • -2
    • +2
    ./dotlrn-forums/tcl/dotlrn-forums-procs.tcl
    • -2
    • +2
    ./dotlrn-news/tcl/dotlrn-news-procs.tcl
    • -2
    • +7
    ./notifications/tcl/notification-procs.tcl
    • -2
    • +2
    ./notifications/tcl/test/notifications-test-procs.tcl
    • -1
    • +1
    ./notifications/www/request-notification.tcl