Dashboard

Welcome Message

Welcome at fisheye.openacs.org!

The site allows you to cast a FishEye on the history and SCM activities of OpenACS and .LRN. This SCM monitoring tool is licensed to OpenACS/.LRN under the Atlassian Open Source Project License.

Enjoy!

Support

You are running Fisheye 4.8.10 (20220620091927 2022-06-20 09:21)

If you are experiencing any issues, please contact your administrator. You may also want to browse the documentation or search the support forums. Still stuck? You can start a support ticket at support.atlassian.com or raise a bug or feature request at jira.atlassian.com.

Customize the support message.

Friday 24 Mar
6:12 pm

antoniop

Apply downstream fixes

Options
    • -3
    • +2
    /openacs-4/packages/calendar-portlet/www/calendar-portlet.adp
6:11 pm

antoniop

Test of the calendar portlet, admin and regular, for all views

The tests exposes typos and forgottent variables in upstream code

Options
    • -0
    • +66
    /openacs-4/packages/calendar-portlet/tcl/test/calendar-portlet-procs.tcl
5:47 pm

antoniop

Test bm_portlet::show, but then make it private: it is not supposed to be invoked on its own, but via the Service Contract API

Options
    • -2
    • +2
    /openacs-4/packages/bm-portlet/tcl/bm-portlet-procs.tcl
    • -1
    • +37
    /openacs-4/packages/bm-portlet/tcl/test/bm-portlet-procs.tcl
5:28 pm

antoniop

Claim additional coverage

Options
    • -1
    • +3
    /openacs-4/packages/acs-service-contract/tcl/test/acs-service-contract-procs.tcl
5:23 pm

antoniop

Basic test of acs_mail_lite::send

Options
    • -0
    • +103
    /openacs-4/packages/acs-mail-lite/tcl/test/acs-mail-lite-procs.tcl
5:23 pm

antoniop

file acs-mail-lite-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-mail-lite/tcl/test/acs-mail-lite-procs.tcl
5:02 pm

antoniop

Make acs_mail_lite::utils::build_body, replace (commented) references in other packages

Options
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/utils-procs.tcl
    • -2
    • +0
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
4:51 pm

antoniop

Complete coverage for the package

Options
    • -0
    • +60
    /openacs-4/packages/acs-lang/tcl/test/lang-widget-procs.tcl
4:51 pm

antoniop

file lang-widget-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-lang/tcl/test/lang-widget-procs.tcl
4:21 pm

antoniop

State new dependencies

Options
    • -2
    • +2
    /openacs-4/packages/acs-datetime/acs-datetime.info
    • -3
    • +3
    /openacs-4/packages/calendar/calendar.info
1:43 pm

hectorr

Whitespace changes

Options
    • -11
    • +11
    /openacs-4/packages/dotlrn/www/weblog-new.tcl
Thursday 23 Mar
6:22 pm

antoniop

Replace deprecated api

Options
    • -2
    • +8
    /openacs-4/packages/evaluation/www/admin/tasks/task-add-edit.tcl
6:12 pm

antoniop

Use new feature for dt_get_info to retrieve variables in a way that we know what is there and what not

Options
    • -8
    • +12
    /openacs-4/packages/calendar/www/mini-calendar.tcl
    • -1
    • +1
    /openacs-4/packages/calendar/www/view-month-display.adp
    • -7
    • +7
    /openacs-4/packages/calendar/www/view-month-display.tcl
6:11 pm

antoniop

Allow dt_get_info to return its results as a dict or a simple value, without settings a ton of variable in the caller scope that are difficult to track

Options
    • -5
    • +29
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
5:15 pm

antoniop

Deprecate leftover api

Options
    • -2
    • +2
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
5:14 pm

antoniop

Deprecate all remaining dt_widget_* api

The rationale is that modern HTML5 provides already consistent and localized UI elements for date and time input. It is also difficult to style a widget that comes pre-baked by the api. One should either use acs-templating or xowiki feature to generate UIs, or modern HTML5 is in most cases sufficient.

Options
    • -4
    • +22
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
    • -5
    • +30
    /openacs-4/packages/acs-datetime/tcl/acs-datetime-procs.tcl
    • -33
    • +1
    /openacs-4/packages/acs-datetime/www/doc/design.adp
    • -42
    • +9
    /openacs-4/packages/acs-datetime/www/doc/design.html
    • -37
    • +0
    /openacs-4/packages/acs-datetime/www/doc/examples/calendar-widgets.adp
    • -40
    • +0
    /openacs-4/packages/acs-datetime/www/doc/examples/calendar-widgets.tcl
    • -53
    • +0
    /openacs-4/packages/acs-datetime/www/doc/examples/datetime-widgets.adp
    • -52
    • +0
    /openacs-4/packages/acs-datetime/www/doc/examples/datetime-widgets.tcl
    • -5
    • +1
    /openacs-4/packages/acs-datetime/www/doc/examples/index.adp
4:50 pm

antoniop

Replace deprecated api

Options
    • -11
    • +10
    /openacs-4/packages/dotlrn/www/weblog-new.tcl
4:41 pm

antoniop

Prevent Javascript in the comment content

Note that this check is additional to that coming from e.g. allowed tags or similar

Options
    • -1
    • +18
    /openacs-4/packages/general-comments/www/comment-add-2.tcl
    • -1
    • +18
    /openacs-4/packages/general-comments/www/comment-edit-2.tcl
4:24 pm

antoniop

Do not allow markup in the portlet name

Options
    • -3
    • +6
    /openacs-4/packages/static-portlet/www/element.tcl
4:22 pm

antoniop

Localize error message

Options
    • -3
    • +8
    /openacs-4/packages/acs-templating/tcl/data-procs.tcl
4:13 pm

antoniop

Use a better regexp to reimplement ad_looks_like_html_p, use the improved api to port downstream feature: an ad_form datatype validator that won't allow to insert markup

Many thanks to Günter Ernst

Options
    • -6
    • +2
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
    • -1
    • +20
    /openacs-4/packages/acs-templating/tcl/data-procs.tcl
3:31 pm

antoniop

Cleanup reference to deprecated api

Options
    • -1
    • +0
    /openacs-4/packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl
3:31 pm

antoniop

Quote name, as this will be shown in the error message

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
2:56 pm

antoniop

Do not allow data URLs

Options
    • -1
    • +6
    /openacs-4/packages/general-comments/www/url-add-2.tcl
2:38 pm

antoniop

Use modern HTML and OpenACS features for date input, which do not require rendering via a custom widget api and cumbersome validation

Options
    • -2
    • +2
    /openacs-4/packages/news/www/admin/approve-2-oracle.xql
    • -2
    • +2
    /openacs-4/packages/news/www/admin/approve-2-postgresql.xql
    • -10
    • +6
    /openacs-4/packages/news/www/admin/approve-2.tcl
    • -2
    • +2
    /openacs-4/packages/news/www/admin/approve.adp
    • -4
    • +3
    /openacs-4/packages/news/www/admin/approve.tcl
2:24 pm

antoniop

Deprecate dt_widget_calendar_year

Options
    • -2
    • +5
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
    • -4
    • +1
    /openacs-4/packages/acs-datetime/www/doc/design.adp
    • -4
    • +1
    /openacs-4/packages/acs-datetime/www/doc/design.html
    • -2
    • +1
    /openacs-4/packages/acs-datetime/www/doc/examples/calendar-widgets.tcl
    • -2
    • +1
    /openacs-4/packages/acs-datetime/www/doc/examples/index.adp
2:17 pm

antoniop

Cleanup dt_widget_calendar_navigation documentation

Options
    • -4
    • +1
    /openacs-4/packages/acs-datetime/www/doc/design.adp
    • -4
    • +2
    /openacs-4/packages/acs-datetime/www/doc/design.html
    • -42
    • +0
    /openacs-4/packages/acs-datetime/www/doc/examples/calendar-navigation.adp
    • -39
    • +0
    /openacs-4/packages/acs-datetime/www/doc/examples/calendar-navigation.tcl
2:13 pm

antoniop

Deprecate dt_widget_calendar_navigation

Options
    • -2
    • +7
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
2:00 pm

antoniop

Test dt_no_time_p

Options
    • -12
    • +36
    /openacs-4/packages/acs-datetime/tcl/test/acs-datetime-procs.tcl
1:50 pm

antoniop

Deprecate ad_ns_set_to_tcl_vars, which can always be replaced with simple tcl idioms

Options
    • -2
    • +10
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl