Minor cleanup

Remove first argument of MethodDispatch, which is apparently not needed

Avoid mixed declarations and code

Merge branch 'master' of ssh://alice.wu-wien.ac.at/usr/local/src/git-repo/nsf

Added experimental definition of NSF_CONSTANT_COMPILED_LOCAL_LOOKUP

* nsf.c (FindNextMethod): Provide revised, streamlined implementation of FindSelfNext as FindNextMethod. FindSelfNext is maintained, but unused for the time being.

Cleanup and Optimization

- align code with documentation

- remove dead code

- minor optimization

White space changes

Reduce number of returns before end of function

Whitespace changes, typos

more macro definition after GNU definitions

Remove redundant definition

Remove dead assignment

Add more tidy and checking compiler flags

Merge branch 'master' of ssh://alice.wu-wien.ac.at/usr/local/src/git-repo/nsf

* nsf.c (NsfCurrentCmd), nsfStack.c (CallStackNextFrameOfType): Render [current isnextcall] aware of ensembles. Extended submethods.test to cover [current isnextcall] within ensembles.

set the displayed_object_id to the forum_id for edit operations

    • -0
    • +1
Use package_id as "displayed_object_id" for "item-create" and "revision-add"

    • -0
    • +1
Improve robustness, when no displayed_object_id is given

CKEditor Reform

- Add basic support for the standard "filebrowser" plugin,

which is part of all CKEditor presets

- The filebrowser plugin supports image uploads to the server and

to browse/select images already attached to this object

(based on displayed_object_id)

- Bump version number to 0.13

reduce verbosity

    • -2
    • +2
Cleanup of yesterdays changes (based on experiences with learn@wu)

    • -123
    • +171
nsf.c (FindSelfNext): Render [current nextmethod] aware of ensembles. Added basic tests.

Add safety belt in case the page_template is not instantiated

    • -2
    • +8
Whitespace changes

    • -96
    • +96
add missing file

Shared Workflow Definitions (Part 2)

When shared workflow definition are used, a different management of

object specific code is necessary, since one definition seves for many

objects, and it is not freshly created per object. Therefore, a new

concept is introduced for workflow definitions, named "object-specifc"

Instead of writing in a workflow definition

Action save

state initial -actions {save}

[my object] proc foo {} { ns_log notice "===foo==="}

one has to write now:

Action save

state initial -actions {save}

:object-specific {

:proc foo {} { ns_log notice "===foo==="}


where the object-specific is evaluated once per request for every

involved workflow instance in the context of the object (a [self]

in this block refers to the object).

In case a [my object] is encountered and sharedWorkflowDefinition is

activated, a warning is produced and the code falls back to old-style

shared workflow definitions.

    • -145
    • +279
    • -7
    • +3
Major overhaul of the CKEditor support

- support for ckfinder interface "imageUploadUrl"

(as used in the "uploadimage" plugin)

- Improved configurability through config files

Small improvement for portrait management (deletion)

Exploit existing on delete cascade constraints when we delete a portrait, instead of deleting stuff manually.

Also, put remaining logics into a proc and use it in acs_user::delete to address legit use case of people wanting

to remove a user permanently without removing portrait in advance.

White-space changes