gustafn in OpenACS

whitespace changes

add safety-guard in case, someone tries to call action via hacking form hacking

    • -13
    • +25
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
fix typoCVS: ----------------------------------------------------------------------

add transtional code to support semi-upgraded folders (having no description field set)

    • -1
    • +13
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
whitespace cleanup

    • -713
    • +713
    /openacs-4/packages/acs-tcl/tcl/xml-0-sgml-procs.tcl
provide better argument name

switch to simple new group::update call with dict as argument

This change fixes as well a bug in install::xml::action::set-join-policy

since group::get returns a member "text" which is not accepted by

group::update.

    • -3
    • +3
    /openacs-4/packages/xowiki/xowiki.info
    • -3
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
provide configuration for exam folder

    • -0
    • +2
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
provide additional configuration hooks when creating new pages

- p.source (copy variables from that site-wide page upon creation)

- p.configure (call a method for configuration of the page)

    • -5
    • +14
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
provide mimetype to "text" field (otherwise form is incorrectly displayed in browser)

support passing a dict as argument to "group::update" (not only array)

support folder instances as prototype pages

provide a default menu config via proc

The setup of the menu of xowf instances can be now configured

via {config -use xowf}, new instances are created with this setup

    • -1
    • +23
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
relax default samesite setting for login and session cookies to lax

This change was made because otherwise the "keep me logged in"

is often lost, e.g. also with toplevel navigation requests

(e.g. when navigating to the site via Google)

show notification controls only, when the request is not from a bot

    • -3
    • +3
    /openacs-4/packages/forums/forums.info
    • -17
    • +21
    /openacs-4/packages/forums/www/forum-view.adp
    • -6
    • +9
    /openacs-4/packages/forums/www/message-view.adp
    • -3
    • +6
    /openacs-4/packages/forums/www/message-view.tcl
added "ad_conn bot_p" to check, whether request was initiated by a bot

This feature is based on a simple heuristic based on the user-agent

(which can be certainly extended). It is useful to avoid e.g. Google

bot to run into "notifications subscribe" + login attempts, which

are useful for not-logged-in user, but not for bots. These attemps

lead to failures in google statistics that might reduce the google

ranking of a web site.

    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
reduce debugging output

fix listing of batch run

- make links clickable

- modernize Tcl code

improve debug message

Added points in addition to minutes to test items and inclass-exam workflows

    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
remove personal-message dialog when user has finished her exam

improve source code documentation

    • -0
    • +6
    /openacs-4/packages/xowf/lib/inclass-exam.wf
return raw value for form-fields of type label, when disableOutputEscaping is set

fix broken support for explicit bindvars to db_foreach

added last_contribution based on last created object

file ip-info.adp was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/acs-admin/www/ip-info.adp
file ip-info.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/acs-admin/www/ip-info.tcl
remove stray "from" in last visit information

we have in table "users" no last IP, we could just fall back to a

last contribution field

use common "icanuse" idioms

use localized_text for folders and links