gustafn in OpenACS

improve navigation structure (context bar) and actions labeling

the reousrce actions is not necessary, since rerun performs an automatic resources

adjust to api-browser changes for trailing non-positional arguments

Added support for trailing non-positional arguments

The change makes the old hack with the own trailing-argument-parser

"ad_arg_parser" obsolete by using directly the c-level argument parser

which is anyhow capable of handling trailing arguments. A few changes

were necessary for api doc to handle there trailing arguments as well.

The proc "db_string" is already converted to use native arguments.

    • -3
    • +3
    /openacs-4/packages/acs-tcl/acs-tcl.info
added test case for db_string with various bind options

whitespace changes

move db-test case to db-regression test files

remove unneeded method

complete listing of covered procs in test cases

use fine-grade percentage to color mapping

added a comment about the usefulness of ad_arg_parser

Fix for issue #3442 to support range types in .xql files

PostgreSQL supports range types since 9.5. When using range types,

square braces have to be used in SQL statements. Since OpenACS uses

always Tcl substitution in .xql files, and OpenACS does NOT allow

backslash substitution in these files, square brackets could not be

escaped and therefore not be used in .xql files so far. This change

allows now a developer to deactivate the substitution by passing

e.g. "-subst none" to the db_* command using the .xql file. Valid

values for "-subst" are "all", "none", "vars", and "commands", default

is "all" which is exactly the behavior of before. Therefore, this

change is fully backward compatible.

    • -1
    • +1
    /openacs-4/packages/acs-tcl/acs-tcl.info
mark private functions as private

whitespace changes

improve test coverage

improve consistency of interface: use instance variable when no folder_id is provided

add option to show student IP address during the exam

use absolute time for computing beeps

do not rely on xo::dc in packages not depending on xotcl-core

reduce the size of the public interface

improve spelling

Avoid calling depreacted content_item__new/17, call content_item__new/21 instead

file upgrade-5.10.0d1-5.10.0d2.sql was initially added on branch oacs-5-10.

improve test coverage

small performance improvement

avoid setting of unneeded function, reduce access to nsvs

    • -3
    • +2
    /openacs-4/packages/search/tcl/search-procs.tcl
provide a flushing interface to apm_package_id cache to avoid the need to call the uncached code directly

whitespace changes: break overlong lines

make clear from the name that db_qd_prepare_queryfile_content is intended to be used in different packages

Refactor content repository backend

The refactored code is a first step to become able to provide plugins

for backends for storing content in different systems. Instead of

using switch statements to distinguish between backends "file", "lob"

and "text", procs with a suffix of the storage name are provided

now. Essentially, by providing process with additional suffixes can be

used to provide additional storage systems.

In addition, the deletion handling was also refactored such that the

non-scalable functions iterating over all items (such as

"cr_check_orphaned_files") will become obsolete. This is imporant for

content repositories with double and triple digit terabytes.

added "content_type" to the list of specially handled calls. this fixes two more cases in Test case callgraph__bad_calls