• last updated 15 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
provide a default for pass_through option

Add column 'attachments_allowed_p' to 'forums_forums', to be used to allow/disallow attachments on a per forum basis. Currently, the attachment logic is package instance wise, so if the forums instance has an attachment instance mounted below, then attachments are assumed to be enabled for all forums in that package instance. The idea with this change is to check for both the attachments instance mounted under a particular forum instance, and the 'attachments_allowed_p' column on 'forums_forums', to decide if attachments are enabled or not (both should be true). Next step would be to rewrite the logic to achieve that.

    • -5
    • +5
    /openacs-4/packages/forums/forums.info
file upgrade-1.3.1d12-1.3.1d13.sql was initially added on branch oacs-5-10.

Trailing whitespace cleanup

Use 'ckfinder::file_attach' instead of 'ckfinder::image_attach', which is not implemented.

Make doc and logging consistent with implementation (image_attach -> file_attach)

Fix translation

Keep accepting empty values as proper ids, as deprecated ad_var_type_check_integer_p would have done

Specify an explicit format that clock scan can recognize, otherwise results will be unexpected (port from downstream)

Use provided email only when a party exists, in all other cases keep the previous behavior (fixes automated tests)

Fix regression on enabling/disabling locales

Use a german gender-neutral wording for "members"

make object adressing more consistent

fix typo

improve spelling

replace hardcoded /tmp by API function [ad_tmpdir]

template::reset_request_vars must be executed for all requests in the cleanup

this is already happening via "ns_ictl trace freeconn", but we keep

for the time being this as a reminder, when merging with different versions, etc.

don't hardcode /tmp/

simplify file delivery modes

don't start accidentially thread via monitoring

improve spelling

replace deprecated function ad_var_type_check_number_p which was used improperly

replace deprecated functions ad_var_type_check_integerlist_p and ad_var_type_check_number_p

replace deprecated ad_var_type_check_number_p by "string is double -strict "

Mark value checking functions from before ad_page_contract as deprecated

(see also issue #3407)

A 16 years old comment says:

This is some old security crud from before we had ad_page_contract

check_for_form_variable_naughtiness

ad_var_type_check_integer_p

ad_var_type_check_safefilename_p

ad_var_type_check_dirname_p

ad_var_type_check_number_p

ad_var_type_check_word_p

ad_var_type_check_nocheck_p

ad_var_type_check_noquote_p

ad_var_type_check_integerlist_p

fix seplling errors

fix spelling errors

whitespace changes

avoid usage of ad_var_type_check_integer_p

(use Tcl idiom "string is integer -strict" instead)

fix typos in message catalog and bump version number to force reload