antoniop in OpenACS

Add missing refresh to categories portlet definition after http://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-9%3Aantoniop%3A20170609120749 (Many thanks to Thomas Renner)

Remove Oracle incompatible code (as pointed out by regression tests)

Remove incompatible idiom from oracle's sql (as pointed out by regression tests)

Prevent errors in between of a release upgrade when system still has not render_widgets proc defined. Users should restart the server asap anyway.

Remove redundant not localized text

    • -2
    • +1
    /openacs-4/packages/search/www/search.adp
Fix typo

Improve documentation

Comment out currently not working code. To enable again one should forward interaction when a user is approved to a page sending some confirmation email, but seems like this is now missing.

Allow to retrieve membership also for users that have more than one role in a group (e.g. member + admin)

Use site_node:: api to retrieve package_url instead of explicit query. Remove unused sql and simplify idiom for fs_get_folder_name.

Don't assume a Unix OS when executing commands

Don't assume a Unix OS when exec'ing commands

Localize group actions (port of work by Monika Andergassen)

Prevent error when user is removed from the Registered Users group, but not from users altogether

Allow to specify another return url for the page

Fix typo in previous commit

Don't steal anybody's address nor email, especially if people was banned. Fail and give a message instead.

Use ad_script_abort everytime one issues ad_return_complaint, or subsequent errors will trigger without the user noticing

    • -0
    • +1
    /openacs-4/packages/chat/www/html-chat.tcl
    • -1
    • +2
    /openacs-4/packages/chat/www/room-delete-2.tcl
Prevent user from triggering db error by entering too big subjects

simplify idiom

Fix cases of this portlet being called on trees without categories.

Modernize list assign idioms

Port some improvements from Learn@WU codebase:

- check whether chat room exists exploits cache

- chat room retrieval enriches with some acs_objects metadata

Fix potential errors when we try entering a chat room that has been deleted and check for its activity status

    • -11
    • +43
    /openacs-4/packages/chat/tcl/chat-procs.tcl
- Introduce new proc ad_sanitize_filename implementing current best practices for ensuring a valid filename on most filesystems.

- Use it in every place where filename sanitization is performed in the code and deprecate fs::remove_special_file_system_characters.

TODO deprecate also util_text_to_html? Use case of sanitizing urls and filenames might have different requirements.

Make sure message exists when dealing with a banned user

Update construct to reload a page, as previous one was not working properly at least on Chrome and Explorer

Improve UI for Hostnode map so it is feasible on sites with many nodes to show navigate the site structure

Fix typo

Check if we have already a folder with same name before inserting, or we get error in the logs.

Remove small duplication

Don't report pretty link in export comments for items without a package_id, or export will come out corrupted.

(This is the case for global template objects as en:folder.form)

    • -2
    • +3
    /openacs-4/packages/xowiki/tcl/import-procs.tcl
Remove sql duplication, converge oracle and postgres codebase