antoniop in OpenACS

Quote the backslash as well...

Italian message keys for cookie-consent package

Revert reduction of divergency between oracle and postgres codebase:

this conflicts hard with downstream code and results in less scalable behavior

Use better idiom to retrieve the xowiki instance (also checking permissions)

Reduce divergency between oracle and postgres codebase

    • -0
    • +38
    /openacs-4/packages/chat-portlet/www/chat-portlet.xql
Remove reference to client, as now this is decided in the xowiki chat implementation

Fix string replace to render user link

Use a more scalable idiom to retrieve the first available xowiki instance

Force IE to recover focus on the message field whenever messages are rendered

Chat reform:

- rework xotcl-core chat machinery to return its responses through JSON and include information about active users

- depend on xowiki instead of xotcl-core only

- exploit xowiki "Comet" server push implementation when the browser supports it

- reduce code duplication

- drop plain HTML chat

- reduce hardcoded styling

- minor cleanups

    • -64
    • +16
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
    • -0
    • +12
    /openacs-4/packages/chat/www/chat.adp
    • -23
    • +5
    /openacs-4/packages/chat/www/chat.tcl
    • -30
    • +0
    /openacs-4/packages/chat/www/html-chat.adp
    • -47
    • +0
    /openacs-4/packages/chat/www/html-chat.tcl
    • -11
    • +4
    /openacs-4/packages/chat/www/index.tcl
    • -21
    • +3
    /openacs-4/packages/chat/www/room-enter.tcl
    • -8
    • +1
    /openacs-4/packages/chat/www/room-exit.tcl
    • -53
    • +0
    /openacs-4/packages/chat/www/ajax/chat.adp
    • -274
    • +0
    /openacs-4/packages/chat/www/ajax/chat.js
    • -23
    • +22
    /openacs-4/packages/chat/www/ajax/chat.tcl
  1. … 9 more files in changeset.
Converge render method for chat and xotcl-core package

Add ':' to formatting to uniform with the render method

Preliminary xowiki chat rework

- update javascript to comply with CSP (setInterval...)

- exploit template resource loading machinery to load javascripts

- remove code duplication

- remove inline styling

    • -95
    • +78
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
Unquote single quote from JSON before appending messages to chat

Fix quoting of single quotes in JSON

Remove leftover alert

Avoid javascript eval idiom as CSP will refuse to execute when unsafe-eval is disabled

This requires moving to a more approprate JSON parser... which is also pickier regarding single quotes, so I had to rework JSON encoding to please it.

Make ad_sanitize_html not hardly dependant on a connection being there (thanks to Markus moser for the report)

Also, update documentation and make idioms less awkward.

(this passes automated tests)

Better separate data from formatting

    • -1
    • +6
    /openacs-4/packages/chat/www/ajax/chat.adp
    • -9
    • +1
    /openacs-4/packages/chat/www/ajax/chat.tcl
Normalize indentation

    • -19
    • +19
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
Decouple a bit formatting from data

    • -0
    • +48
    /openacs-4/packages/chat/www/ajax/chat.adp
    • -26
    • +6
    /openacs-4/packages/chat/www/ajax/chat.tcl
Give templating a chance

move all hardcoded styling to the adp template, which might be styled by the theme. Also, biring some order in the login proc, e.g. don't open and read a file to include a javascript all the time.

    • -64
    • +59
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
Modernize XoTcl idioms

Remove smelly comment, as parameter is there

Deprecate util_search_list_of_lists, as since Tcl 8.5 its behavior can be achieved natively through lsearch

Modernize tcl

Whitespace removal

Move image::get_info together with its pals procs in the content repository... just to realize it should probably go away at some point

    • -42
    • +0
    /openacs-4/packages/acs-tcl/tcl/image-procs.tcl
Fix layout when no data for test is available

Fix typo in doc