antoniop in OpenACS

Remove sql duplication, converge oracle and postgres codebase

Prevent user from selecting source folder as destination folder when moving files. Localize feedback messages (thanks to Markus Moser for the germen translation)

Fix typo in html attributes definition (this enables proper styling and input checks).

Put formwidget directly into markup, otherwise the templating system complains about missing id for the submit widget.

Don't lookup creator name for messages coming from the system, as they won't be found

    • -2
    • +3
    /openacs-4/packages/chat/tcl/chat-procs.tcl
Don't assume import_file exists when checking for virus

Put missing -base argument (many thanks to Markus Moser)

    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
Remove debugging comment

Use name and title for the copy, rather than name as title and file_upload_name as name. This will make so copied files will have also the same title as the original when this was renamed.

Try conserving file extension in the name when adding the suffix

Localize untranslated messages in the copy file-storage script (thanks to Markus Moser for the german translation)

Don't show time interval when choosing recurrence in case of all day events

Give a feedback message when permission have been modified

Improve translation of ad-return-complaint message. Add missing translation

Use a lazy but feasible check to decide if we have buttons for copy in the file storage

Avoid other double encoding when export_vars is applied on xowiki pretty_links

    • -2
    • +2
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/www/admin/list.tcl
Don't double encode pretty links

Don't apply new encoding behavior to already encoded strings (many thanks to Thomas Renner)

Use localized text for search placeholder

Make filter simpler with just one field and more suitable to a responsive design (thanks to Günter Ernst)

Replace xo::Http with select-free util::http

    • -5
    • +8
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Add filters for applications list so it is easily possible to reach permission and parameters page also on sites with many mounted applications.

Fix hiding of delete and move buttons. For move I resolved using the

delete permission as a criteria, because otherwise one should ensure

also the availability of a suitable destination, which must be writable

and in none of the object's subtrees. Complicated and costly to execute everytime.

Make encoding the url part the default behavior. Add extra exception for the trivial case of dummy url '#'.

Make url part encoding in export_vars optional by the -base_encode flag to avoid regressions in existing code (e.g. urls containing anchors)

Fix typo in parameter name

Allow copy of files/folders into the same folder of the original content. This is done by appending a numerical suffix to the name.

It required modifying copy stored procedures so they could accept a different name and title for the copy.

I have also removed redundant package definition in oracle code that was immediately overridden afterwards.

file upgrade-5.9.1b4-5.9.1b5.sql was initially added on branch oacs-5-9.

file upgrade-5.9.1b3-5.9.1b4.sql was initially added on branch oacs-5-9.

Performance improvement in content_item__get_path stored procedure (thanks to Thomas Renner)

file upgrade-5.9.1b3-5.9.1b4.sql was initially added on branch oacs-5-9.

Improve translation for the full version of this portlet: was same as the lesser one and therefore confusing. (thanks to Markus Moser)