antoniop in OpenACS

Use a HTML-quote safe idiom to indent categories in the widget

Make sure connection channel is available (e.g. not detached) before returning content, as more recent Naviserver versions would return an error

Make sure files exist

No need to rollback as we don't touch the db

Add an extra use case when UTF-8 encoding is stated explicitly

Expand the test about util::http and json

Basic tests for util::http:: JSON encoding behavior

file http-client-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/test/http-client-procs.tcl
Whitespace changes

Explain better why is not easy to get rid of this library

Give a proper documentation to xml_* api

Close brackets as pointed out by files__tcl_file_syntax_errors

Downgrade as a warning the case when pdfs fail to be converted to text because of password protection

xowiki_form_instance_item_view reform: get object creation metadata from the item, instead than from the revision

    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -6
    • +14
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Don't complain when the context_id is not there to be ignored

    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Safety belt so users cannot change URL of the main subsite from the UI

Make sure package_id is set on transcripts also when flushing messages every day

Chat reform:

- use consistently package_id to model belonging of a chat object to a particular package instead of the context_id

- set context_id to the package_id, as was already the case in practice, for permission checking

- make sure package_id exists and set it to the context_id in case it doesn't to handle legacy installations

    • -2
    • +2
    /openacs-4/packages/chat/tcl/chat-procs.tcl
    • -2
    • +2
    /openacs-4/packages/chat/www/index.tcl
    • -1
    • +1
    /openacs-4/packages/chat/www/room-edit.tcl
Further performance improvement: as we only want one column from xowiki_form_page, just get it through a subquery

    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -5
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
xowiki_form_instance_item_view performance improvement: do not join with dummy cr_text table, use lateral on Postgres to better guide the query planner

    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -5
    • +34
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Fix properly import/export in a way that, as we did before, context_id of imported objects will use cr_items default, the parent_id

    • -10
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
xowiki_form_instance_item_view reform: retrieve the context_id from the cr_item, rather than from the cr_revision

Rationale: revision's context_id is always set to its item_id. This will make every fetched ORM object appear as its context_id = item_id, while item's acs_object will display the correct context_id (in most cases, its parent)

    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -2
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Keep previous behavior of ignoring the context_id when exporting/importing xowiki objects now that this metadata would be persisted

    • -1
    • +11
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Pass object_id to the include UI, make the include contract clear

Wrap upleveled command in a list statement to make number of arguments clear

Do not require uuid package anymore

Use ns_uuid Naviserver command instead of uuid::uuid generate from tcllib: apparently, this can interact badly with clock localized formatting, leading to the "GREGORIAN_CHANGE_DATE" issue

Add @see to deprecated doc

Prefer using the list structure directly: each category has only 1 translation per locale

Smartify idiom