hectorr in OpenACS

Add missing brace

Transform page_contract into include_contract, and add 'session_id' required parameter for the 'find_assessment' query

Create 'ad_include_contract' for includelet

    • -140
    • +156
    /openacs-4/packages/assessment/lib/session-items.tcl
Fix typo

Fix typo

Rework adp boolean expressions

  1. … 11 more files in changeset.
Prefer literal in adp expressions + Whitespace changes

Brace and rework expressions + Whitespace changes

Revert unintended replacement

Prefer literal in adp axpressions + Whitespace changes

  1. … 15 more files in changeset.
Prefer literal in adp axpressions

Prefer individual 'set' operations over 'lassign' in these particular cases

Replace obsolete proc 'exists_and_not_null'

Brace expressions

Fix typos + Whitespace changes

Fix typos

Fix capitalization

    • -2
    • +2
    /openacs-4/packages/search/tcl/search-procs.tcl
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 461 more files in changeset.
Prefer indivudual 'set' operations over 'lassign' in this case.

Rework variable assigning loops (set -> lassign)

Rework variable assigning loops (set -> lassign) + Whitespace changes

    • -36
    • +35
    /openacs-4/packages/acs-tcl/tcl/pools-init.tcl
Prefer 'lset' to 'lreplace'.

Prefer string operators to 'string equal'.

Rework string comparison expression

Rework list operations

Add 'aggregation_format' option to list template (many thanks to Felix Moedritscher)

Replace 'linsert' with 'lappend'

Fix linsert command argument expansion + Whitespace

Replace 'exists_and_not_null'

Replace deprecated proc 'ad_parameter' with 'parameter::get'