hectorr in OpenACS

Rollback of 'boolean' parameter datatype, as oracle does not see necessary to have 'boolean' datatypes, and they do not even provide with a proper alternative on what to use instead. Great. See: https://asktom.oracle.com/pls/asktom/f?p=100:11:0::::P11_QUESTION_ID:6263249199595#876972400346931526

Add 'boolean' parameter datatype and increase version number

file upgrade-5.10.0d12-5.10.0d13.sql was initially added on branch oacs-5-10.

Fix typo

Whitespace changes

Whitespace changes + editor hints

    • -74
    • +74
    /openacs-4/packages/glossar/tcl/glossar-procs.tcl
    • -27
    • +33
    /openacs-4/packages/glossar/www/glossar-add.tcl
    • -15
    • +21
    /openacs-4/packages/glossar/www/glossar-edit.tcl
    • -131
    • +126
    /openacs-4/packages/jabber/www/edit-user-2.tcl
  1. … 11 more files in changeset.
Replace/remove deprecated proc 'db_null'

  1. … 11 more files in changeset.
Remove deprecated proc 'db_nullify_empty_string' from doc

Whitespace changes + editor hints

    • -55
    • +55
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
    • -422
    • +422
    /openacs-4/packages/assessment/tcl/as-qti-procs.tcl
    • -16
    • +22
    /openacs-4/packages/logger/tcl/util-procs.tcl
  1. … 5 more files in changeset.
Replace/remove deprecated proc 'db_null' and update doc accordingly

  1. … 19 more files in changeset.
Deprecate 'db_nullify_empty_string', essentially just returning the same string it receives

Deprecate 'db_null'

Trailing whitespace cleanup

Refactoring of 'folder-zip-add'

Fix folder creation in 'folder-zip-add'

Whitespace changes

Remove backtick from the list of characters to be replaced by 'ad_sanitize_filename', as 'util::zip' deals with them properly now

util::zip reform.

+ Use '::zipfile::mkzip', introduced in tcllib 1.18, if available.

+ For unix-like systems, with older tcllib versions, bash was used for changing directories. This method was problematic when using certain characters for the filenames, such as backticks, for example. In order to avoid this and properly quote everything, we use tclsh instead, in a convoluted and funny way (thanks to Nathan Coulter for the hack).

+ TODO: test this method also on windows, and unify the legacy implementations if it works.

Fix typos

    • -13
    • +13
    /openacs-4/packages/search/tcl/search-procs.tcl
Whitespace changes + editor hints

    • -61
    • +59
    /openacs-4/packages/search/tcl/search-procs.tcl
Deprecate broken proc 'search::is_guest_p', and replace its only occurrence in the whole codebase, in the 'intermedia-driver' package, with working code.

    • -2
    • +6
    /openacs-4/packages/search/tcl/search-procs.tcl
Remove extra whitespace

Whitespace changes

    • -11
    • +10
    /openacs-4/packages/dotlrn/www/register.tcl
Add missing 'ad_script_abort' after 'ns_returnfile'

Bump version number due to updated message keys

Add '`' to the list of sanitazable characters by 'ad_sanitize_filename'

Fix erroneus file description in page contract

Implement uninstantiate apm callback to delete existent FAQs in advance

    • -0
    • +14
    /openacs-4/packages/faq/tcl/apm-callback-procs.xql
Whitespace changes + Added editor hints

    • -0
    • +6
    /openacs-4/packages/chat/www/noactive.tcl
    • -5
    • +7
    /openacs-4/packages/chat/www/room-delete-2.tcl
    • -2
    • +8
    /openacs-4/packages/chat/www/room-delete.tcl
    • -45
    • +51
    /openacs-4/packages/chat/www/room-edit.tcl
    • -0
    • +5
    /openacs-4/packages/chat/www/search-3.tcl
  1. … 13 more files in changeset.
Chat Redesign: