hectorr in OpenACS

About

782 commits
  • Committer is not mapped to a user
  • First commit: 12 March 2008
  • Last commit: 14 August 2019
Last Week All Time
Commits: 0 782
Files changed: 0 8,064
Change in LOC: 0 40,044

Line History

Line Count Graph
Line Count Graph

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Wednesday 14 Aug
4:28 pm

hectorr

Return a fallback attachments url when not in a connection context, for example, during mail sending on the bulk-mail package

Options
    • -17
    • +21
    /openacs-4/packages/attachments/tcl/attachments-procs.tcl
Monday 05 Aug
2:27 pm

hectorr

Whitespace cleanup

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/policy-procs.tcl
Thursday 18 Jul
6:04 pm

hectorr

Add new private proc 'attachments::get_attachments_url', and use it to complement the logic of 'attachments::get_url'

As 'attachments::get_url' returns the value of the attachments package

'RelativeUrl' parameter, which can change at any time, it could happen

that previously mounted attachments have a different url and are not

found anymore.

We try our best here to find a mounted attachments package under

'base_url' to mitigate this, probably flawed, package logic.

In the future, probably a better method should be used for URL resolving

that is not so broken.

The whole thing is even more weird, as the attachments package is

currently a singleton that auto-mounts on /attachments, so i am tempted

to replace this whole thing with just that, but anyway...

Options
    • -4
    • +51
    /openacs-4/packages/attachments/tcl/attachments-procs.tcl
5:56 pm

hectorr

Use 'attachments::detach_url' instead of building manually the URL

Options
    • -2
    • +2
    /openacs-4/packages/forums/lib/message/attachment-list.tcl
1:51 pm

hectorr

Bump version to reload message keys

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/xotcl-core.info
Wednesday 17 Jul
7:44 pm

hectorr

Renaming of files so they are loaded after 00-icanuse-procs.tcl

Options
    • -19
    • +0
    /openacs-4/packages/acs-tcl/tcl/00-database-procs-oracle.tcl
    • -21
    • +0
    /openacs-4/packages/acs-tcl/tcl/00-database-procs-postgresql-postgresql.xql
    • -19
    • +0
    /openacs-4/packages/acs-tcl/tcl/00-database-procs-postgresql.tcl
    • -3800
    • +0
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
    • -0
    • +19
    /openacs-4/packages/acs-tcl/tcl/01-database-procs-oracle.tcl
    • -0
    • +21
    /openacs-4/packages/acs-tcl/tcl/01-database-procs-postgresql-postgresql.xql
    • -0
    • +19
    /openacs-4/packages/acs-tcl/tcl/01-database-procs-postgresql.tcl
    • -0
    • +3800
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
7:44 pm

hectorr

file 01-database-procs-oracle.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/01-database-procs-oracle.tcl
7:44 pm

hectorr

file 01-database-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
7:44 pm

hectorr

file 01-database-procs-postgresql.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/01-database-procs-postgresql.tcl
7:44 pm

hectorr

file 01-database-procs-postgresql-postgresql.xql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/01-database-procs-postgresql-postgresql.xql
1:46 pm

hectorr

Localize some pretty names. Many thanks to Monika Andergassen

Options
    • -0
    • +6
    /openacs-4/packages/xotcl-core/catalog/xotcl-core.de_DE.ISO-8859-1.xml
    • -0
    • +6
    /openacs-4/packages/xotcl-core/catalog/xotcl-core.en_US.ISO-8859-1.xml
    • -4
    • +4
    /openacs-4/packages/xotcl-core/tcl/cr-procs.tcl
Tuesday 16 Jul
9:43 am

hectorr

Fix typo

Options
    • -1
    • +1
    /openacs-4/packages/calendar/www/doc/requirements.adp
9:24 am

hectorr

Fix typos

Options
    • -2
    • +2
    /openacs-4/packages/calendar/www/doc/requirements.adp
Monday 15 Jul
4:49 pm

hectorr

Remove form debug code

Options
    • -15
    • +1
    /openacs-4/packages/forums/lib/message/post.tcl
4:48 pm

hectorr

Forum attachments reform.

- Add new style of attachments to the forums, allowing multiple attachments to a single message directly from the message post page, using the multiple file input widget.

- Retain compatibility with old style attachments, using the new 'AttachmentStyle' package instance parameter. Currently, this supports two values: 'simple' (new behavior) and 'complex' previous behavior.

- Both attachment styles can coexist, and attachments added by any of such methods will be shown.

- Improve the contract on 'forums/lib/message/post.tcl'.

- Show attachments on message preview.

- Bump version number.

Options
    • -2
    • +3
    /openacs-4/packages/forums/forums.info
    • -2
    • +1
    /openacs-4/packages/forums/lib/message/post-confirm.adp
    • -26
    • +196
    /openacs-4/packages/forums/lib/message/post.tcl
    • -1
    • +10
    /openacs-4/packages/forums/lib/message/row.adp
    • -2
    • +3
    /openacs-4/packages/forums/lib/message/row.tcl
Friday 12 Jul
6:00 pm

hectorr

Add 'alt_template' to include contract

Options
    • -2
    • +3
    /openacs-4/packages/forums/lib/message/attachment-list.tcl
5:57 pm

hectorr

Add include contract and 'preview' view to the attachment list

Options
    • -3
    • +8
    /openacs-4/packages/forums/lib/message/attachment-list.adp
    • -11
    • +7
    /openacs-4/packages/forums/lib/message/attachment-list.tcl
5:39 pm

hectorr

Add some remarks regarding the 'privacy control' in the forum portlet

Options
    • -1
    • +9
    /openacs-4/packages/forums-portlet/www/forums-portlet.tcl
5:29 pm

hectorr

Require admin privileges for attachment deletion in the forum, the same as for message editing

Options
    • -2
    • +4
    /openacs-4/packages/forums/lib/message/attachment-list.tcl
4:37 pm

hectorr

Put the delete link to the right of the attachment

Options
    • -1
    • +1
    /openacs-4/packages/forums/lib/message/attachment-list.adp
4:31 pm

hectorr

Only offer the possibility to delete an attachment from the file storage if it is really there, offer to detach it in any case.

Options
    • -2
    • +2
    /openacs-4/packages/attachments/www/detach.adp
    • -58
    • +75
    /openacs-4/packages/attachments/www/detach.tcl
4:19 pm

hectorr

Add 'attachments::get_title' to centralize the logic of title guessing for an attachment

Options
    • -37
    • +51
    /openacs-4/packages/attachments/tcl/attachments-procs.tcl
3:00 pm

hectorr

Add the 'detach' option on the attachment list, for users with write permissions on the message

Options
    • -1
    • +6
    /openacs-4/packages/forums/lib/message/attachment-list.adp
    • -4
    • +15
    /openacs-4/packages/forums/lib/message/attachment-list.tcl
2:59 pm

hectorr

Center icons on attachment list

Options
    • -0
    • +4
    /openacs-4/packages/forums/www/resources/forums.css
Thursday 11 Jul
7:01 pm

hectorr

Generalize attachment size logic in forum posts, so different object types, such as 'content_item', 'content_revision', and their subtypes, are supported

Options
    • -15
    • +33
    /openacs-4/packages/forums/lib/message/attachment-list.tcl
6:41 pm

hectorr

Whitespace changes

Options
    • -15
    • +20
    /openacs-4/packages/attachments/www/go-to-attachment.xql
    • -2
    • +2
    /openacs-4/packages/attachments/www/download/index.xql
6:38 pm

hectorr

Generalize attachment download logic, so it can deal with different object types, such as 'content_item', 'content_revision', and their subtypes

Options
    • -44
    • +60
    /openacs-4/packages/attachments/www/go-to-attachment.tcl
    • -0
    • +14
    /openacs-4/packages/attachments/www/go-to-attachment.xql
    • -11
    • +35
    /openacs-4/packages/attachments/www/download/index.vuh
    • -1
    • +12
    /openacs-4/packages/attachments/www/download/index.xql
6:01 pm

hectorr

Add 'exception_count' to 'ad_return_complaint'

Options
    • -3
    • +5
    /openacs-4/packages/attachments/www/download/index.vuh
1:54 pm

hectorr

Use the paremeter 'LoginPasswordAutocomplete' to decide on the value of the attribute for the password element in the login form

Options
    • -1
    • +9
    /openacs-4/packages/openacs-bootstrap3-theme/resources/templates/packages/acs-subsite/lib/login.tcl
12:57 pm

hectorr

Add a new instance parameter 'LoginPasswordAutocomplete' with the value of the 'autocomplete' attribute of the password field of the login form, to let each subsite decide.

Options
    • -2
    • +3
    /openacs-4/packages/acs-subsite/acs-subsite.info
    • -1
    • +9
    /openacs-4/packages/acs-subsite/lib/login.tcl