hectorr in OpenACS

About

1,171 commits
  • Committer is not mapped to a user
  • First commit: 12 March 2008
  • Last commit: 14 January 2021
Last Week All Time
Commits: 0 1,171
Files changed: 0 8,176
Change in LOC: 0 40,277

Line History

Line Count Graph
Line Count Graph

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Thursday 14 Jan
4:24 pm

hectorr

Fix proc name

Options
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
Wednesday 13 Jan
1:39 pm

hectorr

Fix webserver version check using 'apm_version_names_compare' for rc versions.

Between 4.99.6 and 4.99.20rc1, for example, 'apm_version_names_compare' will consider the latter to be the lowest.

As this is not the expected behavior for webserver version check, this patch just removes the rc part of the version before comparing in the few cases where this is done, and should be removed if the behavior changes in the future.

Options
    • -2
    • +7
    /openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
    • -1
    • +4
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
Tuesday 15 Dec 2020
2:14 pm

hectorr

Fix typos

Options
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/test/email-inbound-procs.tcl
2:10 pm

hectorr

Fix priority check in 'acs_mail_lite_inbound_procs_check' test case

Options
    • -4
    • +4
    /openacs-4/packages/acs-mail-lite/tcl/test/email-inbound-procs.tcl
Friday 04 Dec 2020
11:57 am

hectorr

Whitespace changes

Options
    • -2
    • +2
    /openacs-4/packages/file-storage/www/folder-chunk.tcl
11:56 am

hectorr

Disable RSS offering in file-storage if the RSS generation service is disabled in rss-support. Bump version numbers and fix dependencies, as the RssGenActiveP parameter is only available in latest rss-support.

Options
    • -3
    • +3
    /openacs-4/packages/file-storage/file-storage.info
    • -6
    • +8
    /openacs-4/packages/file-storage/www/folder-chunk.adp
    • -1
    • +7
    /openacs-4/packages/file-storage/www/folder-chunk.tcl
11:27 am

hectorr

Whitespace changes

Options
    • -1
    • +1
    /openacs-4/packages/news/news.info
    • -3
    • +3
    /openacs-4/packages/news/www/index.adp
    • -7
    • +7
    /openacs-4/packages/news/www/index.tcl
    • -13
    • +4
    /openacs-4/packages/news/www/admin/index.adp
    • -17
    • +17
    /openacs-4/packages/news/www/admin/index.tcl
    • -1
    • +1
    /openacs-4/packages/news-portlet/news-portlet.info
    • -12
    • +21
    /openacs-4/packages/news-portlet/www/news-portlet.tcl
11:15 am

hectorr

Disable RSS offering in news and news-portlet if the RSS generation service is disabled in rss-support. Bump version numbers and fix dependencies, as the RssGenActiveP parameter is only available in latest rss-support.

Options
    • -3
    • +3
    /openacs-4/packages/news/news.info
    • -7
    • +7
    /openacs-4/packages/news/www/index.adp
    • -6
    • +11
    /openacs-4/packages/news/www/index.tcl
    • -4
    • +8
    /openacs-4/packages/news/www/admin/index.adp
    • -6
    • +9
    /openacs-4/packages/news/www/admin/index.tcl
    • -3
    • +3
    /openacs-4/packages/news-portlet/news-portlet.info
    • -1
    • +1
    /openacs-4/packages/news-portlet/www/news-portlet.adp
    • -3
    • +11
    /openacs-4/packages/news-portlet/www/news-portlet.tcl
Thursday 03 Dec 2020
1:52 pm

hectorr

Whitespace changes

Options
    • -2
    • +2
    /openacs-4/packages/rss-support/rss-support.info
    • -41
    • +41
    /openacs-4/packages/rss-support/tcl/rss-generation-service-procs.tcl
1:49 pm

hectorr

Add parameter RssGenActiveP to the rss-support package, to enable/disable the RSS generation service. Bump version number.

Options
    • -2
    • +3
    /openacs-4/packages/rss-support/rss-support.info
    • -15
    • +19
    /openacs-4/packages/rss-support/tcl/rss-generation-service-procs.tcl
Wednesday 25 Nov 2020
3:35 pm

hectorr

Fix expression logic

Options
    • -3
    • +3
    /openacs-4/packages/dotlrn/tcl/community-procs.tcl
Thursday 12 Nov 2020
3:56 pm

hectorr

Remove the 'dot-stuffing' from 'acs-mail-lite', as this is done directly on 'nssmtpd' and 'ns_smtp' now. See https://bitbucket.org/naviserver/naviserver/commits/4bdbd53a3c36f60b8ec0c4e400de1b69bf3e19e5 and https://bitbucket.org/naviserver/nssmtpd/commits/d484ba5d41364c1a0ab8e2437c5311a6d5d7e986

Options
    • -10
    • +1
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
Wednesday 11 Nov 2020
5:59 pm

hectorr

Add a second period to new lines starting with one ('dot-stuffing'), as defined by RFC 5321 section 4.5.2, before sending mail via nssmptd.

According to the RFC:

- "Before sending a line of mail text, the SMTP client checks the

first character of the line. If it is a period, one additional period is inserted at

the beginning of the line."

- "When a line of mail text is received by the SMTP server, it checks the line. If the

line is composed of a single period, it is treated as the end of mail indicator. If

the first character is a period and there are other characters on the line, the first

character is deleted."

This change adds the second period at the beginning of a line suggested in the first

paragraph, preventing nssmptd from deleting dots by acting as mentioned in the second one.

In the case of lines comprised of just a single period, '::mime::qp_encode' already takes

care of them by converting the '.' into '=2E', so they are not affected by this.

Options
    • -1
    • +10
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
1:37 pm

hectorr

Fix test category misplacement

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/text-html-procs.tcl
Tuesday 10 Nov 2020
1:39 pm

hectorr

Take care of string values when these are longer than the randomized length

Options
    • -0
    • +4
    /openacs-4/packages/acs-tcl/tcl/test/text-html-procs.tcl
1:08 pm

hectorr

Whitespace changes

Options
    • -12
    • +12
    /openacs-4/packages/acs-tcl/tcl/test/text-html-procs.tcl
1:07 pm

hectorr

Set tests as 'production_safe'

Options
    • -4
    • +4
    /openacs-4/packages/acs-tcl/tcl/test/text-html-procs.tcl
Thursday 05 Nov 2020
11:14 am

hectorr

Cleanup after each individual test

Options
    • -8
    • +8
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
Wednesday 04 Nov 2020
3:40 pm

hectorr

Remove 'check_xotcl_xocc' test case, as it has served its purpose already

Options
    • -10
    • +0
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-avail-procs.tcl
2:25 pm

hectorr

Ensure a minimal connection context before checking for user_id

Options
    • -1
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
2:12 pm

hectorr

Cleanup temporary XOTcl objects after test run

Options
    • -1
    • +8
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
Monday 02 Nov 2020
7:07 pm

hectorr

Add 'package_id' for tests so it does not need to be guessed

Options
    • -6
    • +6
    /openacs-4/packages/xolp/tcl/test/xolp-test-procs.tcl
5:26 pm

hectorr

Add 'package_id' for tests so it does not need to be guessed

Options
    • -2
    • +3
    /openacs-4/packages/xolp/tcl/test/xolp-test-procs.tcl
4:32 pm

hectorr

Add 'check_xotcl_xocc' test case, checking for 'xo::cc'.

The intention of this test is to expose the destruction of the '::xo::cc' object, as a side effect of the 'check_xotcl' test. The test will fail if executed after it, and succeed otherwise.

The object destruction affects other tests executed in the same batch, and breaks in particular xowf's 'create_folder_with_page'.

The 'check_xotcl' test runs the 'Serializer all' method, which is calling 'xo::at_cleanup', destroying the '::xo::cc' object.

Options
    • -0
    • +11
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-avail-procs.tcl
Thursday 29 Oct 2020
5:24 pm

hectorr

Do rollback after test run

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/navigation-procs.tcl
Wednesday 28 Oct 2020
4:41 pm

hectorr

Prefer 'namespace which' over 'info commands'

Options
    • -3
    • +3
    /openacs-4/tcl/0-acs-init.tcl
4:39 pm

hectorr

Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

Options
    • -1
    • +1
    /openacs-4/packages/acs-admin/tcl/acs-admin-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/tcl/apm-admin-init.tcl
    • -1
    • +1
    /openacs-4/packages/acs-admin/tcl/site-wide-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/version-callback-add-edit.tcl
    • -1
    • +1
    /openacs-4/packages/acs-admin/www/install/install-3.tcl
    • -18
    • +21
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -9
    • +15
    /openacs-4/packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-api-browser/www/proc-view.tcl
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/installer/index.tcl
    • -3
    • +3
    /openacs-4/packages/acs-bootstrap-installer/installer/tcl/0-acs-init.tcl
    • -4
    • +4
    /openacs-4/packages/acs-bootstrap-installer/installer/www/blank-master.tcl
    • -3
    • +3
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/tcl/30-apm-load-procs.tcl
    • -4
    • +4
    /openacs-4/packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl
  16. … 44 more files in changeset.
1:08 pm

hectorr

Reuse computations

Options
    • -24
    • +34
    /openacs-4/packages/xolp/tcl/test/xolp-test-procs.tcl
1:02 pm

hectorr

Fix message key for SC/MC question alternatives. Many thanks to Stephan Adelsberger

Options
    • -0
    • +1
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
Tuesday 27 Oct 2020
4:13 pm

hectorr

Add 'package_id' for tests so it does not need to be guessed

Options
    • -4
    • +2
    /openacs-4/packages/xolp/tcl/xolp-activity-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xolp/tcl/xolp-iri-procs.tcl
    • -18
    • +65
    /openacs-4/packages/xolp/tcl/test/xolp-test-procs.tcl