hectorr in OpenACS

Remove leftover

Fixed var name and add warning for 'cr_file_name' being empty (the latter ported from downstream, originally made by Günter Ernst)

Whitespace changes + Editor hints

Replace deprecated API

Update spanish message keys

Update spanish message keys

    • -0
    • +4
    /openacs-4/packages/xolp/catalog/xolp.es_ES.ISO-8859-1.xml
Replace deprecated API. Fixes 'callgraph__bad_page_calls' test case

    • -4
    • +5
    /openacs-4/packages/chat/www/search-3.tcl
    • -2
    • +3
    /openacs-4/packages/chat/www/user-unban-2.tcl
    • -2
    • +3
    /openacs-4/packages/chat/www/user-ban-2.tcl
Remove obsolete file. Fixes 'callgraph__bad_page_calls' test case

Mark 'template::adp_puts' as public, as it is used in 'calendar'

Mark 'fs::max_upload_size' as public, as it is used in 'attachments'

Remove obsolete files, initially deleted in oacs-5-8 branch, 8 years ago, which somehow managed to survive

Remove obsolete file, initially deleted in oacs-5-8 branch, 8 years ago, which somehow managed to survive

Remove bogus proc name. Fixes 'naming__proc_naming' test case

Mark 'auth::can_admin_system_without_authority_p' as public, as it is used in 'acs-admin'

Mark 'auth::authority::get_sc_impl_columns' as public, as it is used in 'acs-admin'

Mark 'lang::message::cache' as public, as it is used in 'acs-admin'

Mark 'lang::catalog::package_catalog_dir' as public, as it is used in 'acs-admin'

Mark 'lang::util::get_hash_indices' as public, as it is used in 'acs-admin'

Mark 'whos_online::interval' as public, as it is used in 'acs-subsite'

Make a bunch of apm procs public, as they are used in 'acs-admin'.

Could be worth considering moving the ones used only in 'acs-admin' to that package, and making them private again, leaving public only those who may be useful to other packages/applications (i.e. CI/CD logic).

Mark 'apm_application_new_checkbox' as public, as it is used in the site-map

Mark 'sec_get_random_cached_token_id' as public, as it is used in 'acs-subsite'

Mark 'apm_mark_version_for_reload' as public, as it is used in 'acs-automated-testing'

Check also token value in nsv in 'secret_tokens_get' test case

Whitespace changes

Change test category and rollback after execution

Add new 'secret_tokens_get' and refactor 'test_set_cookie_procs' to include cases handled by the deleted ancient tests in 'acs-admin/www/test/signed-cookies-test'

Remove ancient test for 'acs-admin', which uses obsolete API and don't work anymore

Remove ancient tests for 'acs-lang', which use obsolete API and don't work for the most part anymore

Remove 'moderator-grant' and 'moderator-revoke' pages, linked nowhere and using obsolete API

    • -24
    • +0
    /openacs-4/packages/chat/www/moderator-grant-2.tcl