hectorr in OpenACS

Fix proc name

Fix webserver version check using 'apm_version_names_compare' for rc versions.

Between 4.99.6 and 4.99.20rc1, for example, 'apm_version_names_compare' will consider the latter to be the lowest.

As this is not the expected behavior for webserver version check, this patch just removes the rc part of the version before comparing in the few cases where this is done, and should be removed if the behavior changes in the future.

Fix typos

Fix priority check in 'acs_mail_lite_inbound_procs_check' test case

Whitespace changes

Disable RSS offering in file-storage if the RSS generation service is disabled in rss-support. Bump version numbers and fix dependencies, as the RssGenActiveP parameter is only available in latest rss-support.

Whitespace changes

    • -3
    • +3
    /openacs-4/packages/news/www/index.adp
    • -7
    • +7
    /openacs-4/packages/news/www/index.tcl
    • -13
    • +4
    /openacs-4/packages/news/www/admin/index.adp
    • -17
    • +17
    /openacs-4/packages/news/www/admin/index.tcl
Disable RSS offering in news and news-portlet if the RSS generation service is disabled in rss-support. Bump version numbers and fix dependencies, as the RssGenActiveP parameter is only available in latest rss-support.

    • -7
    • +7
    /openacs-4/packages/news/www/index.adp
    • -6
    • +11
    /openacs-4/packages/news/www/index.tcl
    • -4
    • +8
    /openacs-4/packages/news/www/admin/index.adp
    • -6
    • +9
    /openacs-4/packages/news/www/admin/index.tcl
Whitespace changes

Add parameter RssGenActiveP to the rss-support package, to enable/disable the RSS generation service. Bump version number.

Fix expression logic

Add a second period to new lines starting with one ('dot-stuffing'), as defined by RFC 5321 section 4.5.2, before sending mail via nssmptd.

According to the RFC:

- "Before sending a line of mail text, the SMTP client checks the

first character of the line. If it is a period, one additional period is inserted at

the beginning of the line."

- "When a line of mail text is received by the SMTP server, it checks the line. If the

line is composed of a single period, it is treated as the end of mail indicator. If

the first character is a period and there are other characters on the line, the first

character is deleted."

This change adds the second period at the beginning of a line suggested in the first

paragraph, preventing nssmptd from deleting dots by acting as mentioned in the second one.

In the case of lines comprised of just a single period, '::mime::qp_encode' already takes

care of them by converting the '.' into '=2E', so they are not affected by this.

Fix test category misplacement

Take care of string values when these are longer than the randomized length

Whitespace changes

Set tests as 'production_safe'

Cleanup after each individual test

Remove 'check_xotcl_xocc' test case, as it has served its purpose already

Ensure a minimal connection context before checking for user_id

    • -1
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Cleanup temporary XOTcl objects after test run

Add 'package_id' for tests so it does not need to be guessed

Add 'package_id' for tests so it does not need to be guessed

Add 'check_xotcl_xocc' test case, checking for 'xo::cc'.

The intention of this test is to expose the destruction of the '::xo::cc' object, as a side effect of the 'check_xotcl' test. The test will fail if executed after it, and succeed otherwise.

The object destruction affects other tests executed in the same batch, and breaks in particular xowf's 'create_folder_with_page'.

The 'check_xotcl' test runs the 'Serializer all' method, which is calling 'xo::at_cleanup', destroying the '::xo::cc' object.

Do rollback after test run

Prefer 'namespace which' over 'info commands'

Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

  1. … 44 more files in changeset.
Reuse computations

Fix message key for SC/MC question alternatives. Many thanks to Stephan Adelsberger

Add 'package_id' for tests so it does not need to be guessed