hectorr in OpenACS

About

621 commits
  • Committer is not mapped to a user
  • First commit: 12 March 2008
  • Last commit: 15 February 2019
Last Week All Time
Commits: 0 621
Files changed: 114 8,016
Change in LOC: 3,629 40,065

Line History

Line Count Graph
Line Count Graph

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Friday 15 Feb
6:32 pm

hectorr

Rollback of 'boolean' parameter datatype, as oracle does not see necessary to have 'boolean' datatypes, and they do not even provide with a proper alternative on what to use instead. Great. See: https://asktom.oracle.com/pls/asktom/f?p=100:11:0::::P11_QUESTION_ID:6263249199595#876972400346931526

Options
    • -2
    • +2
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -2
    • +2
    /openacs-4/packages/acs-kernel/sql/oracle/apm-create.sql
    • -23
    • +0
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.0d12-5.10.0d13.sql
    • -2
    • +2
    /openacs-4/packages/acs-kernel/sql/postgresql/apm-create.sql
    • -22
    • +0
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d12-5.10.0d13.sql
6:20 pm

hectorr

Add 'boolean' parameter datatype and increase version number

Options
    • -2
    • +2
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -2
    • +2
    /openacs-4/packages/acs-kernel/sql/oracle/apm-create.sql
    • -0
    • +23
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.0d12-5.10.0d13.sql
    • -2
    • +2
    /openacs-4/packages/acs-kernel/sql/postgresql/apm-create.sql
    • -0
    • +22
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d12-5.10.0d13.sql
6:20 pm

hectorr

file upgrade-5.10.0d12-5.10.0d13.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.0d12-5.10.0d13.sql
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d12-5.10.0d13.sql
6:05 pm

hectorr

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/acs-kernel/acs-kernel.info
5:24 pm

hectorr

Whitespace changes

Options
    • -17
    • +17
    /openacs-4/packages/acs-subsite/www/shared/parameters.tcl
Tuesday 12 Feb
7:45 pm

hectorr

Whitespace changes + editor hints

Options
    • -180
    • +186
    /openacs-4/packages/adserver/tcl/adserver-procs.tcl
    • -17
    • +22
    /openacs-4/packages/adserver/www/adhref.tcl
    • -17
    • +22
    /openacs-4/packages/adserver/www/adimg.tcl
    • -22
    • +21
    /openacs-4/packages/download/tcl/download-procs.tcl
    • -3
    • +9
    /openacs-4/packages/download/www/archive-add-2.tcl
    • -1
    • +7
    /openacs-4/packages/download/www/archive-version-add-2.tcl
    • -7
    • +13
    /openacs-4/packages/download/www/admin/approve-or-reject-2.tcl
    • -84
    • +89
    /openacs-4/packages/dynamic-types/tcl/dynamic-type-procs.tcl
    • -270
    • +275
    /openacs-4/packages/dynamic-types/tcl/form-procs.tcl
    • -74
    • +74
    /openacs-4/packages/glossar/tcl/glossar-procs.tcl
    • -27
    • +33
    /openacs-4/packages/glossar/www/glossar-add.tcl
    • -15
    • +21
    /openacs-4/packages/glossar/www/glossar-edit.tcl
    • -2
    • +8
    /openacs-4/packages/image-magick/tcl/image-magick-procs.tcl
    • -91
    • +68
    /openacs-4/packages/jabber/www/edit-external-contact-2.tcl
    • -131
    • +126
    /openacs-4/packages/jabber/www/edit-user-2.tcl
  16. … 11 more files in changeset.
7:00 pm

hectorr

Replace/remove deprecated proc 'db_null'

Options
    • -2
    • +2
    /openacs-4/packages/adserver/tcl/adserver-procs.tcl
    • -2
    • +2
    /openacs-4/packages/adserver/www/adhref.tcl
    • -2
    • +2
    /openacs-4/packages/adserver/www/adimg.tcl
    • -2
    • +2
    /openacs-4/packages/download/tcl/download-procs.tcl
    • -5
    • +5
    /openacs-4/packages/download/www/archive-add-2.tcl
    • -6
    • +6
    /openacs-4/packages/download/www/archive-version-add-2.tcl
    • -2
    • +2
    /openacs-4/packages/download/www/admin/approve-or-reject-2.tcl
    • -17
    • +1
    /openacs-4/packages/dynamic-types/tcl/dynamic-type-procs.tcl
    • -7
    • +7
    /openacs-4/packages/dynamic-types/tcl/form-procs.tcl
    • -2
    • +2
    /openacs-4/packages/glossar/tcl/glossar-procs.tcl
    • -3
    • +3
    /openacs-4/packages/glossar/www/glossar-add.tcl
    • -2
    • +2
    /openacs-4/packages/glossar/www/glossar-edit.tcl
    • -8
    • +0
    /openacs-4/packages/image-magick/tcl/image-magick-procs.tcl
    • -1
    • +1
    /openacs-4/packages/jabber/www/edit-external-contact-2.tcl
    • -1
    • +1
    /openacs-4/packages/jabber/www/edit-user-2.tcl
  16. … 11 more files in changeset.
6:43 pm

hectorr

Remove deprecated proc 'db_nullify_empty_string' from doc

Options
    • -28
    • +0
    /openacs-4/packages/acs-core-docs/www/db-api.adp
    • -45
    • +1
    /openacs-4/packages/acs-core-docs/www/db-api.html
    • -52
    • +1
    /openacs-4/packages/acs-core-docs/www/xml/developers-guide/db-api.xml
6:28 pm

hectorr

Whitespace changes + editor hints

Options
    • -58
    • +58
    /openacs-4/packages/acs-admin/www/apm/package-add-2.tcl
    • -16
    • +16
    /openacs-4/packages/acs-admin/www/apm/parameter-add-2.tcl
    • -9
    • +8
    /openacs-4/packages/acs-admin/www/apm/parameter-edit-2.tcl
    • -2
    • +2
    /openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl
    • -1
    • +6
    /openacs-4/packages/acs-mail/tcl/acs-mail-procs.tcl
    • -55
    • +55
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
    • -422
    • +422
    /openacs-4/packages/assessment/tcl/as-qti-procs.tcl
    • -2
    • +2
    /openacs-4/packages/categories/tcl/categories-procs.tcl
    • -20
    • +23
    /openacs-4/packages/content-portlet/misc/admin/category-add-edit.tcl
    • -335
    • +338
    /openacs-4/packages/content-portlet/tcl/content-portlet-compare-procs.tcl
    • -131
    • +137
    /openacs-4/packages/ecommerce/www/admin/products/delete-2.tcl
    • -62
    • +62
    /openacs-4/packages/forums/tcl/forums-callback-procs.tcl
    • -16
    • +22
    /openacs-4/packages/logger/tcl/util-procs.tcl
    • -8
    • +14
    /openacs-4/packages/logger/tcl/variable-procs.tcl
    • -9
    • +9
    /openacs-4/packages/news/tcl/test/news-db-test-init.tcl
  16. … 5 more files in changeset.
6:12 pm

hectorr

Replace/remove deprecated proc 'db_null' and update doc accordingly

Options
    • -3
    • +3
    /openacs-4/packages/acs-admin/www/apm/package-add-2.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/parameter-add-2.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/parameter-edit-2.tcl
    • -13
    • +1
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
    • -17
    • +1
    /openacs-4/packages/acs-core-docs/www/db-api-detailed.adp
    • -28
    • +1
    /openacs-4/packages/acs-core-docs/www/db-api-detailed.html
    • -20
    • +2
    /openacs-4/packages/acs-core-docs/www/db-api.adp
    • -41
    • +1
    /openacs-4/packages/acs-core-docs/www/db-api.html
    • -47
    • +1
    /openacs-4/packages/acs-core-docs/www/xml/developers-guide/db-api.xml
    • -29
    • +1
    /openacs-4/packages/acs-core-docs/www/xml/kernel/db-api.xml
    • -2
    • +2
    /openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl
    • -19
    • +5
    /openacs-4/packages/acs-mail/tcl/acs-mail-procs.tcl
    • -20
    • +1
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
    • -27
    • +1
    /openacs-4/packages/acs-tcl/tcl/apm-procs.tcl
    • -4
    • +2
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
  16. … 19 more files in changeset.
5:34 pm

hectorr

Deprecate 'db_nullify_empty_string', essentially just returning the same string it receives

Options
    • -7
    • +7
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
5:29 pm

hectorr

Deprecate 'db_null'

Options
    • -6
    • +10
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
Monday 11 Feb
3:31 pm

hectorr

Trailing whitespace cleanup

Options
    • -25
    • +23
    /openacs-4/packages/dotlrn/tcl/community-procs.tcl
Wednesday 06 Feb
8:36 pm

hectorr

Refactoring of 'folder-zip-add'

Options
    • -66
    • +113
    /openacs-4/packages/file-storage/www/folder-zip-add.tcl
Tuesday 05 Feb
5:55 pm

hectorr

Fix folder creation in 'folder-zip-add'

Options
    • -3
    • +4
    /openacs-4/packages/file-storage/www/folder-zip-add.tcl
Monday 04 Feb
3:30 pm

hectorr

Whitespace changes

Options
    • -106
    • +106
    /openacs-4/packages/file-storage/www/folder-zip-add.tcl
Thursday 31 Jan
6:07 pm

hectorr

Remove backtick from the list of characters to be replaced by 'ad_sanitize_filename', as 'util::zip' deals with them properly now

Options
    • -4
    • +4
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
6:02 pm

hectorr

util::zip reform.

+ Use '::zipfile::mkzip', introduced in tcllib 1.18, if available.

+ For unix-like systems, with older tcllib versions, bash was used for changing directories. This method was problematic when using certain characters for the filenames, such as backticks, for example. In order to avoid this and properly quote everything, we use tclsh instead, in a convoluted and funny way (thanks to Nathan Coulter for the hack).

+ TODO: test this method also on windows, and unify the legacy implementations if it works.

Options
    • -20
    • +73
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
Tuesday 29 Jan
8:14 pm

hectorr

Fix typos

Options
    • -13
    • +13
    /openacs-4/packages/search/tcl/search-procs.tcl
8:06 pm

hectorr

Whitespace changes + editor hints

Options
    • -56
    • +62
    /openacs-4/packages/intermedia-driver/tcl/intermedia-procs.tcl
    • -61
    • +59
    /openacs-4/packages/search/tcl/search-procs.tcl
8:00 pm

hectorr

Deprecate broken proc 'search::is_guest_p', and replace its only occurrence in the whole codebase, in the 'intermedia-driver' package, with working code.

Options
    • -1
    • +1
    /openacs-4/packages/intermedia-driver/tcl/intermedia-procs.tcl
    • -2
    • +6
    /openacs-4/packages/search/tcl/search-procs.tcl
3:13 pm

hectorr

Remove extra whitespace

Options
    • -2
    • +2
    /openacs-4/packages/dotlrn/www/register.tcl
2:59 pm

hectorr

Whitespace changes

Options
    • -11
    • +10
    /openacs-4/packages/dotlrn/www/register.tcl
Monday 28 Jan
6:33 pm

hectorr

Add missing 'ad_script_abort' after 'ns_returnfile'

Options
    • -1
    • +2
    /openacs-4/packages/acs-subsite/www/shared/portrait-bits.tcl
Wednesday 23 Jan
11:55 am

hectorr

Bump version number due to updated message keys

Options
    • -3
    • +3
    /openacs-4/packages/acs-templating/acs-templating.info
Monday 21 Jan
7:19 pm

hectorr

Add '`' to the list of sanitazable characters by 'ad_sanitize_filename'

Options
    • -4
    • +4
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
6:58 pm

hectorr

Fix erroneus file description in page contract

Options
    • -1
    • +1
    /openacs-4/packages/file-storage/www/download-zip.tcl
Friday 18 Jan
8:33 pm

hectorr

Implement uninstantiate apm callback to delete existent FAQs in advance

Options
    • -3
    • +4
    /openacs-4/packages/faq/faq.info
    • -0
    • +13
    /openacs-4/packages/faq/tcl/apm-callback-procs.tcl
    • -0
    • +14
    /openacs-4/packages/faq/tcl/apm-callback-procs.xql
6:14 pm

hectorr

Whitespace changes + Added editor hints

Options
    • -2
    • +7
    /openacs-4/packages/chat/www/chat-room-grant.tcl
    • -9
    • +14
    /openacs-4/packages/chat/www/chat-transcript.tcl
    • -1
    • +6
    /openacs-4/packages/chat/www/chat-transcripts.tcl
    • -1
    • +7
    /openacs-4/packages/chat/www/message-delete-2.tcl
    • -2
    • +8
    /openacs-4/packages/chat/www/message-delete.tcl
    • -3
    • +9
    /openacs-4/packages/chat/www/moderator-grant-2.tcl
    • -1
    • +6
    /openacs-4/packages/chat/www/moderator-grant.tcl
    • -2
    • +8
    /openacs-4/packages/chat/www/moderator-revoke-2.tcl
    • -1
    • +7
    /openacs-4/packages/chat/www/moderator-revoke.tcl
    • -0
    • +6
    /openacs-4/packages/chat/www/noactive.tcl
    • -5
    • +7
    /openacs-4/packages/chat/www/room-delete-2.tcl
    • -2
    • +8
    /openacs-4/packages/chat/www/room-delete.tcl
    • -45
    • +51
    /openacs-4/packages/chat/www/room-edit.tcl
    • -1
    • +7
    /openacs-4/packages/chat/www/room.tcl
    • -0
    • +5
    /openacs-4/packages/chat/www/search-3.tcl
  16. … 13 more files in changeset.
5:39 pm

hectorr

Chat Redesign:

Options
    • -3
    • +4
    /openacs-4/packages/chat/chat.info
    • -1
    • +3
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
    • -1
    • +8
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
    • -13
    • +19
    /openacs-4/packages/xowiki/www/resources/chat-skins/chat-bubbles-common.js
    • -8
    • +11
    /openacs-4/packages/xowiki/www/resources/chat-skins/chat-classic-common.js