• last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Extend automated tests

    • -0
    • +124
    ./notifications/tcl/test/notifications-test-procs.tcl
Allow to specify a user that does not come from the connection

    • -2
    • +7
    ./notifications/tcl/notification-display-procs.tcl
Expand tests

    • -2
    • +80
    ./notifications/tcl/test/notifications-test-procs.tcl
Improve test a bit

    • -2
    • +9
    ./notifications/tcl/test/notifications-test-procs.tcl
Update documentation to best practices

    • -10
    • +8
    ./notifications/tcl/notification-display-procs.tcl
Fix proc signature

    • -1
    • +1
    ./assessment/tcl/as-apm-checks-procs.tcl
    • -2
    • +2
    ./dotlrn-forums/tcl/dotlrn-forums-procs.tcl
    • -2
    • +2
    ./dotlrn-news/tcl/dotlrn-news-procs.tcl
    • -2
    • +2
    ./notifications/tcl/notification-procs.tcl
    • -1
    • +1
    ./notifications/tcl/test/notifications-test-procs.tcl
    • -1
    • +1
    ./notifications/www/request-notification.tcl
Replace leftover occurrences

    • -2
    • +2
    ./notifications/tcl/notification-procs.tcl
    • -1
    • +1
    ./notifications/www/admin/sweep-now.tcl
Deprecate notification::get_delivery_method_id, same as notification::delivery::get_id and looking more established

    • -1
    • +1
    ./assessment/tcl/as-apm-checks-procs.tcl
    • -2
    • +2
    ./dotlrn-forums/tcl/dotlrn-forums-procs.tcl
    • -2
    • +2
    ./dotlrn-news/tcl/dotlrn-news-procs.tcl
    • -2
    • +7
    ./notifications/tcl/notification-procs.tcl
    • -2
    • +2
    ./notifications/tcl/test/notifications-test-procs.tcl
    • -1
    • +1
    ./notifications/www/request-notification.tcl
Replace leftover occurrence

    • -2
    • +2
    ./dotlrn-news/tcl/dotlrn-news-procs.tcl
Deprecate notification::get_interval_id, duplicated by notification::interval::get_id_from_name which appears to be more established

    • -2
    • +2
    ./dotlrn-forums/tcl/dotlrn-forums-procs.tcl
    • -3
    • +8
    ./notifications/tcl/notification-procs.tcl
    • -21
    • +38
    ./notifications/tcl/test/notifications-test-procs.tcl
    • -1
    • +1
    ./notifications/www/request-notification.tcl
Handle upcoming tDOM 0.9.3

This might need some further rethinking

Prefer flushing the cache, this addresses the automated test, where multiple insert/deletion are performed in the same request

    • -3
    • +2
    ./notifications/tcl/notification-type-procs.tcl
Extend test

    • -12
    • +36
    ./notifications/tcl/test/notifications-test-procs.tcl
Cache the new type_id immediately in the (rare) event that a type was created in a previous request with the same name and then deleted

    • -2
    • +5
    ./notifications/tcl/notification-type-procs.tcl
Expand test

    • -1
    • +10
    ./notifications/tcl/test/notifications-test-procs.tcl
Fix typo in xql file

    • -1
    • +1
    ./notifications/tcl/notification-request-procs-postgresql.xql
Extend notifications tests

    • -0
    • +154
    ./notifications/tcl/test/notifications-test-procs.tcl
Prefer the non cached api when deleting, as the id is cached in the thread and could be stale

    • -2
    • +2
    ./notifications/tcl/notification-type-procs.tcl
Some tests for the notifications api, more to come

    • -0
    • +110
    ./notifications/tcl/test/notifications-test-procs.tcl
file notifications-test-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./notifications/tcl/test/notifications-test-procs.tcl
fix compatibility with tdom 0.9.3

provided a default value for udp:// requests

added ADP:ICON to the list of accepted tags (for new instances)

Fixed variable name

    • -1
    • +1
    ./acs-subsite/www/shared/iso-codes.adp
Port of downstream commit from Markus Moser: remove terminating ; in sql statements, since the query parser complains

    • -1
    • +1
    ./caldav/tcl/caldav-interface-procs.tcl
Bump version number after catalog change

Make api public

use cookie namespace also for stored locales

security::cookie_name: since this is used in acs-lang, it has to be public

    • -11
    • +0
    ./acs-tcl/tcl/apm-procs-postgresql.xql
150px is not enough. In general, these setting should be performed via style files.