• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Styling improvements for exam answering workflows (many thanks to Monika Andergassen)

- provide explicit text to "next" and "previous" buttons in pagination menu

- align appearance of "next" and "previous" buttons in pagination menu with GitHub

- removed class "input-group" for compound fields to improve appearance

- bumped version number of xowf to 5.10.1d48

adp:icon: extended list of generic names and support reloading

- adp:icon: added "next" and "previous" to generic names

- moved variable ::template::icon::map from *init.tcl to style-procs.tcl

to support changes via dynamic reloading via package manager

- bumped version number to 5.10.1d17

    • -0
    • +105
    ./acs-templating/tcl/style-procs.tcl
Port of downstream changes: grand admin permissions also on the admins of the parent community

    • -1
    • +19
    ./dotlrn-calendar/tcl/dotlrn-calendar-procs.tcl
Improve idiom (port from downstream)

    • -5
    • +2
    ./dotlrn-calendar/tcl/dotlrn-calendar-procs.tcl
Port of downstream changes: revoke the automatically assigned calendar_admin permissions to the creation user when a new calendar is added to a community via the applet, as they are not actually needed

    • -10
    • +21
    ./dotlrn-calendar/tcl/dotlrn-calendar-procs.tcl
Allow only one format for the 'date' query parameter, bringing the page contract in line with the "Go to date"-form on this page from which this value is supplied.

Validate field names when these might come directly from the POST request and therefore contain arbitrary text

Now that oneof filter can handle a wider range of formattings, prefer this filter to manual validation

    • -9
    • +2
    ./general-comments/www/comment-add-2.tcl
    • -9
    • +2
    ./general-comments/www/comment-edit-2.tcl
    • -9
    • +2
    ./general-comments/www/comment-edit-3.tcl
Prefer literal to noquote in template properties

    • -1
    • +1
    ./contacts-lite/www/addresses/add-edit.adp
    • -2
    • +2
    ./contacts-lite/www/addresses/delete.adp
    • -2
    • +2
    ./contacts-lite/www/addresses/index.adp
    • -2
    • +2
    ./contacts-lite/www/admin/address-type/index.adp
  1. … 12 more files in changeset.
Prefer literal to noquote in template properties

    • -2
    • +2
    ./scorm-simple-lms/www/admin/confirm-delete.adp
    • -2
    • +2
    ./scorm-simple-lms/www/admin/delete-course.adp
    • -2
    • +2
    ./scorm-simple-lms/www/admin/edit-properties.adp
Handle acs-mail-lite conf regarding the recipient in the test

    • -2
    • +11
    ./acs-authentication/tcl/test/local-procs.tcl
Make sure test email is fine even when usernames are emails

Use lowercase letter to append to the fake username, so that if it should be an email, it will still be valid

Replace calls to deprecated call "util_commify_number"

Use lc_numeric instead

    • -2
    • +2
    ./schema-browser/tcl/schema-browser-procs-postgresql.tcl
revert escaped version

    • -14
    • +12
    ./acs-tcl/tcl/parameter-procs.tcl
reduce verbosity

    • -12
    • +14
    ./acs-tcl/tcl/parameter-procs.tcl
reduce verbosity

    • -2
    • +2
    ./acs-templating/tcl/element-procs.tcl
improve comments

avoid deprecated proc template::util::is_true

remove constant from deprecated message

    • -2
    • +5
    ./acs-bootstrap-installer/tcl/00-proc-procs.tcl
Give people the chance to use OpenACS with WithDeprecatedCode set to 0

When OpenACS is configured to omit loading of long deprecated code

(WithDeprecatedCode set to 0) files like deprecated-procs.tcl are not

loaded. Therefore, these files should only contain code, which was

deprecated at LEAST ONE RELEASE EARLIER, such that site admins have

one release time to fix calls to deprecated code. This is especially

important for public procs.

    • -102
    • +2
    ./acs-tcl/tcl/deprecated-procs.tcl
    • -2
    • +107
    ./acs-tcl/tcl/utilities-procs.tcl
Follow the litmus test suite and address issues reported in the "props" section:

* allow properties expressed in "high unicode" by using the database, rather than the filesystem to store them. (TODO: provide an own data-model, right now I am using persistent client properties)

* return all requested properties, reporting 404 when these properties do not exist

    • -123
    • +127
    ./oacs-dav/tcl/tDAV-procs.tcl
Cleanup debug

Follow the litmus test suite and improve standard compliance for the "copymove" test section:

- return 204 when trying to copy on an existing resource (by trimming traling slash in the destination path before checking)

- return 409 when one tries to copy/move to a non-existant resource

This makes the "copymove" section pass without warnings

Fix boolean expression, as the permission api will return a generic boolean, not necessarily 1 or 0

Fix query in oacs_dav::children_have_permission_p

    • -1
    • +1
    ./oacs-dav/tcl/oacs-dav-procs-postgresql.xql
Test oacs_dav::children_have_permission_p: this test exposes a bug in the api

    • -1
    • +108
    ./oacs-dav/tcl/test/oacs-dav-procs.tcl
Modernize tcl

    • -14
    • +22
    ./oacs-dav/tcl/test/oacs-dav-procs.tcl
    • -28
    • +1
    ./oacs-dav/tcl/test/oacs-dav-procs.xql
Make service contract implementation private and replace foreign occurrences

    • -10
    • +37
    ./file-storage/tcl/file-storage-dav-procs.tcl
    • -21
    • +25
    ./oacs-dav/tcl/oacs-dav-procs.tcl
produce error message in the error log, if the parameter value_array_list is not well formed