• last updated 16 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
whitespace changes

    • -53
    • +53
    ./acs-templating/tcl/tag-init.tcl
    • -35
    • +34
    ./acs-templating/tcl/tag-procs.tcl
add error, when we are running out of handles

reduce verbosity, deactivate usage 'ns_db currenthandles' for now

    • -13
    • +13
    ./acs-tcl/tcl/00-database-procs.tcl
reveive dotlrn community includelet

    • -0
    • +222
    ./xowiki/tcl/dotlrn-portal-procs.tcl
modernize code

prefer "array size" over llength of names

prefer "-base" parameter of export_vars

add quotes for nicer editor rendering

fix typo

db_handle reform

Use "ns_db currenthandles" (when available) to implement "db_with_handle"

instead of the old approach based on the global db_state variables.

The enws approach has the advantantge that it is

- more robust (deletion and creation of the per-request variables,

no coherency problem),

- simpler, and

- faster (less overhead per db_with_handle call, simple queries up to 20% faster)

time {db_string . {select object_id from acs_objects limit 1}} 1000

old: 200-230 microseconds per iteration

new: 160-180 microseconds per iteration

    • -113
    • +334
    ./acs-tcl/tcl/00-database-procs.tcl
Replace single quotes wuith double quotes in javascript expressions involving acs_ListBulkActionClick

this is really needed only for the URL part, but was done on the name as well for consistency. The reason

is even a properly encoded URL could still contain single quotes, therefore breaking the expression,

while double quotes are expected to be encoded in valid, urlencoded URLs. This relies on trusting the developer

to properly encode URLs, which should be expected. An alternative could involve active escaping of

javascript special characters by e.g. ad_js_escape.

    • -1
    • +1
    ./acs-templating/resources/lists/courses.adp
    • -1
    • +1
    ./acs-templating/resources/lists/table.adp
[PostgreSQL 11] Change 'with (iscachable)' to IMMUTABLE for PG11

[PostgreSQL 11] Change 'with (iscachable)' to IMMUTABLE for PG11

    • -1
    • +1
    ./acs-kernel/sql/postgresql/postgresql.sql
backport from oacs-5-9, which might avoid problems with oacs 5-8 when used with recent versions of nsf

fix typo

perform javascript escaping with more regular semantics

    • -4
    • +11
    ./acs-tcl/tcl/test/text-html-procs.tcl
Introduce new ad_js_escape with the purpose of sanitizing tcl strings used inside javascript code from escape sequences and from quotes in particular and provide some test cases

TODO: consider its usage into templates when e.g. we are putting a URL into javascript functions such as acs_ListBulkActionClick. URLs might in fact contain single and double quotes.

    • -0
    • +19
    ./acs-tcl/tcl/test/text-html-procs.tcl
Provide some basic way to create subgroups via the UI

    • -2
    • +3
    ./acs-subsite/www/admin/groups/one.adp
    • -2
    • +7
    ./acs-subsite/www/admin/groups/one.tcl
Actually store the group name in the UI by intercepting the right form var

    • -2
    • +3
    ./acs-subsite/www/admin/groups/new.tcl
Fix test test by considering that group pretty name is automatically localized

    • -3
    • +10
    ./acs-subsite/tcl/test/acs-subsite-procs.tcl
Don't quote some function defaults that are meant to be evaluated literally

    • -7
    • +17
    ./acs-subsite/tcl/plpgsql-utility-procs.tcl
New automated test doing the roundrtrip of group-type related API

Note that this is currently failing due to a bug in package_instantiate_object, which triggered the creation of this test.

    • -1
    • +53
    ./acs-subsite/tcl/test/acs-subsite-procs.tcl
Move logics to delete a group type into the API

    • -1
    • +34
    ./acs-subsite/tcl/group-type-procs-oracle.xql
    • -1
    • +31
    ./acs-subsite/tcl/group-type-procs-postgresql.xql
    • -1
    • +71
    ./acs-subsite/tcl/group-type-procs.tcl
    • -62
    • +6
    ./acs-subsite/www/admin/group-types/delete-2.tcl
    • -14
    • +0
    ./acs-subsite/www/admin/group-types/delete-2.xql
Fix quoting of group type

Remove unneeded variable

Add (trivial) ad_include_contract

Avoid unnecessary computations

    • -1
    • +0
    ./acs-subsite/lib/subsites-postgresql.xql
add index for bulk mail sweeper. was already #10 on sequential reads on learn

    • -0
    • +4
    ./bulk-mail/sql/oracle/upgrade/upgrade-2.10.0d0-2.10.0d1.sql
Reduce divergency between oracle and postgres codebase and bring portable sql inline

    • -39
    • +0
    ./acs-subsite/tcl/application-group-procs-oracle.xql
    • -41
    • +0
    ./acs-subsite/tcl/application-group-procs-postgresql.xql
    • -6
    • +39
    ./acs-subsite/tcl/application-group-procs.tcl
    • -33
    • +0
    ./acs-subsite/tcl/application-group-procs.xql
Reuse return url over subsites, remove dummy sql