• last updated 18 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
reduce error-message swallowing: remove catch operations to trigger error messages, when something goes wrong on the OS-level

fix internal redirection to beautified error pages in connection with host-node-mapped subsites

    • -6
    • +17
    ./acs-tcl/tcl/request-processor-procs.tcl
clean up expression: no need to use backslashes in tcl expression

    • -7
    • +7
    ./acs-tcl/tcl/tcl-documentation-procs.tcl
Upgrade fix

Execute cleanup only if explicitly uncommented, as might have performance implications.

Also, correct unaligned constraint names in old instances upgraded incrementally over the years.

Fix current date UTC query

    • -1
    • +1
    ./acs-lang/www/admin/set-system-timezone.xql
Add missing change in the data model from previous commit

Portrait management reform and correction

Moved logics to create a portrait in a proc in order to reuse it in other places

such as picture retrieval services (e.g. Bach picture retrieval at WU). Turns out

we were not doing our homeworks here: when the portrait is created into CR, a

cr_child_rel is created. When the portrait was erased though, this was not cleaned

up propely, leaving dangling acs_objects with no reference in cr_child_rels table.

On busy sites, this can grow in the ten thousands order of magnitude. Changes include

also fix for this behavior and tuples cleanup.

    • -2
    • +2
    ./acs-content-repository/acs-content-repository.info
    • -0
    • +77
    ./acs-content-repository/sql/postgresql/upgrade/upgrade-5.10.0d4-5.10.0d5.sql
    • -0
    • +80
    ./acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d3-5.10.0d4.sql
    • -16
    • +6
    ./acs-subsite/www/user/portrait/index.tcl
    • -75
    • +15
    ./acs-subsite/www/user/portrait/upload.tcl
    • -38
    • +0
    ./acs-subsite/www/user/portrait/upload.xql
    • -1
    • +14
    ./acs-tcl/tcl/community-core-procs-oracle.xql
    • -0
    • +16
    ./acs-tcl/tcl/community-core-procs-postgresql.xql
    • -7
    • +63
    ./acs-tcl/tcl/community-core-procs.tcl
    • -10
    • +0
    ./acs-tcl/tcl/community-core-procs.xql
avoid errors, when connection is already closed

    • -1
    • +8
    ./cookie-consent/tcl/cookie-consent-procs.tcl
fix more spelling issues

    • -4
    • +4
    ./acs-mail-lite/tcl/email-inbound-procs.tcl
    • -2
    • +2
    ./acs-mail-lite/tcl/imap-inbound-procs.tcl
    • -2
    • +2
    ./acs-mail-lite/www/doc/analysis-notes.adp
remove spurious "expr" in "expr"

simplfy expressions (no need for backslash), standardize writing of RFC

    • -2
    • +2
    ./acs-mail-lite/tcl/acs-mail-lite-procs.tcl
    • -48
    • +55
    ./acs-mail-lite/tcl/email-inbound-procs.tcl
    • -16
    • +18
    ./acs-mail-lite/tcl/imap-inbound-procs.tcl
    • -9
    • +9
    ./acs-mail-lite/tcl/maildir-inbound-procs.tcl
fix spelling

    • -1
    • +1
    ./acs-mail-lite/www/doc/imap-install.adp
    • -1
    • +1
    ./acs-mail-lite/www/doc/incoming-email-legacy-notes.adp
Apply pachtes #960, #961, #962 and #963 from Ben Brink, bump version number to 5.10.0d3 such that changes in .info file get picked up

    • -8
    • +52
    ./acs-mail-lite/tcl/acs-mail-lite-procs.tcl
    • -2
    • +10
    ./acs-mail-lite/tcl/email-inbound-procs.tcl
    • -18
    • +35
    ./acs-mail-lite/tcl/test/email-inbound-procs.tcl
provide templated error pages for subsite. without this, error pages for host-node-mapped subsites are a pain

CVS: ----------------------------------------------------------------------

    • -0
    • +7
    ./acs-subsite/catalog/acs-subsite.en_US.ISO-8859-1.xml
    • -0
    • +5
    ./acs-subsite/www/shared/403.adp
    • -0
    • +4
    ./acs-subsite/www/shared/404.adp
    • -0
    • +5
    ./acs-subsite/www/shared/500.adp
    • -0
    • +5
    ./acs-subsite/www/shared/503.adp
fix for bug #3338

    • -2
    • +2
    ./acs-mail-lite/tcl/acs-mail-lite-procs.tcl
fix ad_form definition (moved redirect in after_submit block, ad_return_template at the end of template outside the ad_form) (thanks to Felix Moedritscher)

    • -3
    • +5
    ./acs-subsite/www/user/portrait/upload.tcl
Improve HTML

modernize Tcl code

    • -6
    • +6
    ./acs-mail-lite/tcl/email-inbound-procs.tcl
    • -4
    • +4
    ./acs-mail-lite/tcl/imap-inbound-procs.tcl
    • -3
    • +3
    ./acs-mail-lite/tcl/maildir-inbound-procs.tcl
prefer ad_try over catch, simplify expression

    • -7
    • +13
    ./acs-mail-lite/tcl/acs-mail-lite-procs.tcl
fix typos

    • -2
    • +2
    ./acs-mail-lite/tcl/acs-mail-lite-callback-procs.tcl
    • -2
    • +2
    ./acs-mail-lite/tcl/acs-mail-lite-procs.tcl
    • -3
    • +3
    ./acs-mail-lite/tcl/email-inbound-procs.tcl
    • -2
    • +2
    ./acs-mail-lite/tcl/incoming-mail-procs.tcl
Protect Tcl's file operations against leading dashes in file names

    • -2
    • +2
    ./acs-mail-lite/tcl/acs-mail-lite-procs.tcl
    • -3
    • +3
    ./acs-mail-lite/tcl/incoming-mail-procs.tcl
    • -5
    • +5
    ./acs-mail-lite/tcl/maildir-inbound-procs.tcl
change "fetch first 1 row only" to "limit 1" to generic xql file, since Oracle started to support fetch first only with version 12c

    • -1
    • +1
    ./acs-mail-lite/tcl/acs-mail-lite-procs.xql
merge with changes from https://github.com/tekbasse/acs-mail-lite/tree/master/tcl

in essence, these changes provide support for handling email with attachments based on nsIMAP.

see https://openacs.org/forums/message-view?message_id=5378972 for more background

    • -14
    • +25
    ./acs-mail-lite/acs-mail-lite.info
    • -5
    • +134
    ./acs-mail-lite/tcl/acs-mail-lite-callback-procs.tcl
    • -13
    • +58
    ./acs-mail-lite/tcl/acs-mail-lite-init.tcl
    • -0
    • +19
    ./acs-mail-lite/tcl/acs-mail-lite-procs-oracle.xql
    • -0
    • +20
    ./acs-mail-lite/tcl/acs-mail-lite-procs-postgresql.xql
    • -14
    • +32
    ./acs-mail-lite/tcl/acs-mail-lite-procs.tcl
    • -0
    • +56
    ./acs-mail-lite/tcl/bounce-procs-oracle.xql
    • -0
    • +56
    ./acs-mail-lite/tcl/bounce-procs-postgresql.xql
    • -8
    • +48
    ./acs-mail-lite/tcl/bounce-procs.tcl
    • -0
    • +2434
    ./acs-mail-lite/tcl/email-inbound-procs.tcl
    • -0
    • +877
    ./acs-mail-lite/tcl/imap-inbound-procs.tcl
    • -18
    • +32
    ./acs-mail-lite/tcl/incoming-mail-procs.tcl
  1. … 57 more files in changeset.
Add ad_script_abort (thanks to Felix Moedritscher)

Use ad_script_abort after ns_return

Consistently use ad_script_abort after ad_returnredirect

    • -2
    • +2
    ./new-portal/www/admin/portal-config-2.tcl
Fix bad handler type error, use ad_try/finally instead of else (Thanks to Felix Moedritscher)

Fixed package version numbering

Added missing index creation statment; Fixed typo in index name

    • -0
    • +5
    ./acs-events/sql/postgresql/upgrade/upgrade-0.6-0.6.1.sql
remove obsolete comment (basic hastore support was moved to xowiki)