OpenACS / openacs-4

packages

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 139
Last Commit: 28 Dec 24
Commits this week: 0
Total Lines of Code (LoC): 5,070,804
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 12 Jul 2022
4:15 pm

antoniop

Use quicker idiom to check for existance

Options
    • -2
    • +7
    ./notifications/tcl/notification-request-procs.tcl
    • -9
    • +0
    ./notifications/tcl/notification-request-procs.xql
4:05 pm

antoniop

Whitespace cleanup

Options
    • -3
    • +3
    ./notifications/tcl/notification-display-procs.tcl
    • -3
    • +3
    ./notifications/tcl/notification-reply-procs.tcl
4:02 pm

antoniop

Whitespace changes

Options
    • -3
    • +3
    ./notifications/tcl/delivery-method-procs.tcl
3:40 pm

antoniop

Apply https://cvs.openacs.org/changelog/OpenACS?cs=MAIN%3Agustafn%3A20220711124557 to the oacs-5-10 branch

Options
    • -15
    • +18
    ./xotcl-core/tcl/ical-procs.tcl
1:30 pm

antoniop

Prefer api to retrieve the approval state of a user

Options
    • -2
    • +2
    ./notifications/tcl/notifications-security-procs.tcl
    • -14
    • +0
    ./notifications/tcl/notifications-security-procs.xql
Monday 11 Jul 2022
5:50 pm

antoniop

Complete coverage for the notification package

Options
    • -0
    • +247
    ./notifications/tcl/test/notifications-test-procs.tcl
5:09 pm

antoniop

Brutally delete the notification requests before deleting the delivery method (it's fine because it will be rolled back)

Options
    • -0
    • +1
    ./notifications/tcl/test/notifications-test-procs.tcl
2:56 pm

antoniop

Fix issue in the query logics: we actually want to check the owner of the request, there might be multiple requests associated to the same object

Options
    • -6
    • +6
    ./notifications/tcl/notifications-security-procs.tcl
    • -1
    • +10
    ./notifications/tcl/test/notifications-test-procs.tcl
2:49 pm

antoniop

Extend coverage, this will expose an api bug

Options
    • -0
    • +179
    ./notifications/tcl/test/notifications-test-procs.tcl
2:45 pm

gustafn

added proper handling of overfull recurrence rule lines

Options
    • -3
    • +3
    ./caldav/caldav.info
    • -3
    • +4
    ./caldav/tcl/caldav-interface-procs.tcl
    • -2
    • +2
    ./xotcl-core/xotcl-core.info
2:45 pm

gustafn

added proper handling of overfull recurrence rule lines

Options
    • -15
    • +18
    ./xotcl-core/tcl/ical-procs.tcl
11:59 am

antoniop

Whitespace cleanup

Options
    • -34
    • +34
    ./caldav/tcl/caldav-interface-procs.tcl
11:50 am

antoniop

Port of downstream commit by Markus Moser: do not use pg query parser to substitute user_id because substitution will take place at a time when :user_id is not available anymore

Options
    • -3
    • +3
    ./caldav/tcl/caldav-interface-procs.tcl
11:43 am

antoniop

According to thr RFC, there is no need to specify single quotes in the BYDAY rule, also because in some cornercase, they might produce a line longer than 76 characters

See https://datatracker.ietf.org/doc/html/rfc5545

Fixes downstream automated tests

Options
    • -1
    • +1
    ./caldav/tcl/caldav-interface-procs.tcl
11:32 am

antoniop

Whitespace cleanup

Options
    • -75
    • +75
    ./caldav/tcl/test/caldav-test-procs.tcl
11:29 am

hectorr

Whitespace changes

Options
    • -26
    • +25
    ./notifications/www/request-notification.tcl
10:58 am

antoniop

Extend coverage

Options
    • -1
    • +27
    ./notifications/tcl/test/notifications-test-procs.tcl
10:42 am

antoniop

Cover more api

Options
    • -0
    • +42
    ./notifications/tcl/test/notifications-test-procs.tcl
10:23 am

antoniop

Extend automated tests

Options
    • -0
    • +124
    ./notifications/tcl/test/notifications-test-procs.tcl
10:07 am

antoniop

Allow to specify a user that does not come from the connection

Options
    • -2
    • +7
    ./notifications/tcl/notification-display-procs.tcl
Friday 08 Jul 2022
6:18 pm

antoniop

Expand tests

Options
    • -2
    • +80
    ./notifications/tcl/test/notifications-test-procs.tcl
5:54 pm

antoniop

Improve test a bit

Options
    • -2
    • +9
    ./notifications/tcl/test/notifications-test-procs.tcl
5:46 pm

antoniop

Update documentation to best practices

Options
    • -10
    • +8
    ./notifications/tcl/notification-display-procs.tcl
5:16 pm

antoniop

Fix proc signature

Options
    • -1
    • +1
    ./assessment/tcl/as-apm-checks-procs.tcl
    • -2
    • +2
    ./dotlrn/www/subscribe-members.tcl
    • -2
    • +2
    ./dotlrn/www/weblog-new.tcl
    • -2
    • +2
    ./dotlrn-forums/tcl/dotlrn-forums-procs.tcl
    • -2
    • +2
    ./dotlrn-news/tcl/dotlrn-news-procs.tcl
    • -2
    • +2
    ./notifications/tcl/notification-procs.tcl
    • -1
    • +1
    ./notifications/tcl/test/notifications-test-procs.tcl
    • -1
    • +1
    ./notifications/www/request-notification.tcl
5:06 pm

antoniop

Replace leftover occurrences

Options
    • -2
    • +2
    ./notifications/tcl/notification-procs.tcl
    • -1
    • +1
    ./notifications/www/admin/sweep-now.tcl
4:53 pm

antoniop

Deprecate notification::get_delivery_method_id, same as notification::delivery::get_id and looking more established

Options
    • -1
    • +1
    ./assessment/tcl/as-apm-checks-procs.tcl
    • -2
    • +2
    ./dotlrn/www/subscribe-members.tcl
    • -2
    • +2
    ./dotlrn/www/weblog-new.tcl
    • -2
    • +2
    ./dotlrn-forums/tcl/dotlrn-forums-procs.tcl
    • -2
    • +2
    ./dotlrn-news/tcl/dotlrn-news-procs.tcl
    • -2
    • +7
    ./notifications/tcl/notification-procs.tcl
    • -2
    • +2
    ./notifications/tcl/test/notifications-test-procs.tcl
    • -1
    • +1
    ./notifications/www/request-notification.tcl
4:47 pm

antoniop

Replace leftover occurrence

Options
    • -2
    • +2
    ./dotlrn-news/tcl/dotlrn-news-procs.tcl
4:36 pm

antoniop

Deprecate notification::get_interval_id, duplicated by notification::interval::get_id_from_name which appears to be more established

Options
    • -2
    • +2
    ./dotlrn/www/subscribe-members.tcl
    • -2
    • +2
    ./dotlrn/www/weblog-new.tcl
    • -2
    • +2
    ./dotlrn-forums/tcl/dotlrn-forums-procs.tcl
    • -3
    • +8
    ./notifications/tcl/notification-procs.tcl
    • -21
    • +38
    ./notifications/tcl/test/notifications-test-procs.tcl
    • -1
    • +1
    ./notifications/www/request-notification.tcl
3:46 pm

antoniop

Handle upcoming tDOM 0.9.3

This might need some further rethinking

Options
    • -4
    • +20
    ./acs-tcl/tcl/text-html-procs.tcl
11:23 am

antoniop

Prefer flushing the cache, this addresses the automated test, where multiple insert/deletion are performed in the same request

Options
    • -3
    • +2
    ./notifications/tcl/notification-type-procs.tcl