OpenACS / openacs-4 / packages

forums

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 61
Last Commit: 26 Dec
Commits this week: 0
Total Lines of Code (LoC): 22,611
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 13 May 2020
4:31 pm

antoniop

Implement a new type of "Moderator" notification type for forums

This notification will be triggered also by unapproved messages. The UI will show the subscription link only to forum moderators, using a different color (customizable via css, vanilla color is red). Message content will always be hidden for such notifications, so user will need to have access to new message.

Options
    • -2
    • +2
    ./forums.info
    • -1
    • +87
    ./tcl/forums-install-procs.tcl
    • -3
    • +88
    ./tcl/messages-procs.tcl
    • -0
    • +7
    ./www/forum-view.adp
    • -1
    • +8
    ./www/forum-view.tcl
    • -1
    • +8
    ./www/message-view.adp
    • -1
    • +8
    ./www/message-view.tcl
    • -0
    • +8
    ./www/resources/forums.css
10:00 am

antoniop

Make clear where paragraph ends

Options
    • -1
    • +1
    ./www/forum-view.adp
Tuesday 12 May 2020
5:33 pm

antoniop

Step in the direction of implementing a new kind of "moderator notification": move current notification behavior in a private api, remove dependency on message approval in message::new (also avoids a query)

Options
    • -6
    • +25
    ./tcl/messages-procs.tcl
5:21 pm

antoniop

Fix typo

Options
    • -2
    • +3
    ./tcl/messages-procs.tcl
4:39 pm

antoniop

Comment unused computations

Options
    • -11
    • +12
    ./tcl/messages-procs.tcl
4:30 pm

antoniop

Small refactoring

Options
    • -7
    • +10
    ./tcl/messages-procs.tcl
Thursday 07 May 2020
4:43 pm

antoniop

Move logics to create forum notification type to tcl to:

- reduce code duplication

- make it simpler to extend forums with new notification types

This reform was triggered by a downstream request, where users would like a new kind of notification for forum moderators that triggers also when a forum message has not been approved

Options
    • -118
    • +0
    ./sql/oracle/forums-notifications-init.sql
    • -128
    • +0
    ./sql/oracle/forums-notifications-sanitize.sql
    • -134
    • +0
    ./sql/postgresql/forums-notifications-init.sql
    • -151
    • +0
    ./sql/postgresql/forums-notifications-sanitize.sql
    • -1
    • +95
    ./tcl/forums-install-procs.tcl
10:34 am

antoniop

Complete a long standing transition (before 5.5): rely on callbacks intead of service contracts to implement FTS datasource logics in the forums package

Options
    • -2
    • +2
    ./forums.info
    • -3
    • +14
    ./tcl/forums-install-procs.tcl
    • -11
    • +41
    ./tcl/forums-sc-procs.tcl
Wednesday 11 Mar 2020
8:50 pm

antoniop

file upgrade-1.3.1d16-1.3.1d17.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-1.3.1d16-1.3.1d17.sql
8:50 pm

antoniop

Redefine forum charter as text, therefore without length limit

Options
    • -2
    • +2
    ./forums.info
    • -3
    • +17
    ./sql/postgresql/forums-forums-create.sql
    • -0
    • +27
    ./sql/postgresql/upgrade/upgrade-1.3.1d16-1.3.1d17.sql
Tuesday 25 Feb 2020
5:55 pm

hectorr

Prefer acs::test::reply_has_status_code over manually checking status code in the reply

Options
    • -17
    • +28
    ./tcl/test/webtest-procs.tcl
Tuesday 18 Feb 2020
6:20 pm

hectorr

Fix close tag

Options
    • -1
    • +1
    ./lib/message/attachment-list.adp
Sunday 09 Feb 2020
4:30 pm

gustafn

added editor hints and white-space cleanup

Options
    • -242
    • +248
    ./tcl/test/webtest-procs.tcl
  2. … 24 more files in changeset.
4:09 pm

gustafn

whitespace changes

Options
    • -5
    • +5
    ./www/forum-view.tcl
  2. … 2 more files in changeset.
9:11 am

gustafn

remove print.css and include its content in forums.css

Options
    • -2
    • +1
    ./www/forum-view.tcl
    • -2
    • +1
    ./www/message-view.tcl
    • -0
    • +34
    ./www/resources/forums.css
    • -28
    • +0
    ./www/resources/print.css
Tuesday 04 Feb 2020
11:24 am

antoniop

Fix typo

Options
    • -2
    • +2
    ./tcl/messages-procs.tcl
Tuesday 07 Jan 2020
2:28 pm

antoniop

Use fully-qualified api names

Options
    • -2
    • +2
    ./tcl/messages-procs.tcl
2:26 pm

antoniop

Indentation changes

Options
    • -7
    • +6
    ./tcl/messages-procs.tcl
1:27 pm

antoniop

Deprecate obsolete api

Options
    • -2
    • +9
    ./tcl/messages-procs.tcl
1:20 pm

antoniop

No need to explicitly delete reading info, as both oracle and postgres define the reference constraint as on delete cascade

Options
    • -9
    • +1
    ./tcl/messages-procs.tcl
1:16 pm

antoniop

Use fully-qualified api names

Options
    • -3
    • +3
    ./tcl/messages-procs.tcl
1:12 pm

antoniop

Use fully-qualified api names, assume message is there (something went very wrong otherwise)

Options
    • -4
    • +5
    ./tcl/messages-procs.tcl
1:04 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -22
    • +0
    ./tcl/messages-procs-oracle.xql
    • -18
    • +0
    ./tcl/messages-procs-postgresql.xql
    • -3
    • +41
    ./tcl/messages-procs.tcl
12:40 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -26
    • +0
    ./tcl/messages-procs-oracle.xql
    • -26
    • +0
    ./tcl/messages-procs-postgresql.xql
    • -14
    • +37
    ./tcl/messages-procs.tcl
11:39 am

antoniop

Whitespace cleanup

Options
    • -10
    • +10
    ./tcl/messages-procs.tcl
11:39 am

antoniop

Deprecate obsolete api

Options
    • -2
    • +9
    ./tcl/messages-procs.tcl
11:28 am

antoniop

Implement operation in a way that oracle is supported

Options
    • -4
    • +5
    ./tcl/messages-procs.tcl
Friday 27 Dec 2019
5:00 pm

antoniop

Add @see for deprecated procs

Options
    • -2
    • +27
    ./tcl/forums-security-procs.tcl
Friday 20 Dec 2019
5:56 pm

antoniop

Use portable idioms

Options
    • -1
    • +2
    ./lib/message/messages-list.tcl
5:55 pm

antoniop

Use ad_include_contract

Options
    • -0
    • +7
    ./lib/message/messages-list.tcl
    • -7
    • +9
    ./lib/search/search-form.tcl