• last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Small refactoring

Move logics to create forum notification type to tcl to:

- reduce code duplication

- make it simpler to extend forums with new notification types

This reform was triggered by a downstream request, where users would like a new kind of notification for forum moderators that triggers also when a forum message has not been approved

    • -118
    • +0
    ./sql/oracle/forums-notifications-init.sql
    • -128
    • +0
    ./sql/oracle/forums-notifications-sanitize.sql
Complete a long standing transition (before 5.5): rely on callbacks intead of service contracts to implement FTS datasource logics in the forums package

file upgrade-1.3.1d16-1.3.1d17.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-1.3.1d16-1.3.1d17.sql
Redefine forum charter as text, therefore without length limit

    • -3
    • +17
    ./sql/postgresql/forums-forums-create.sql
Prefer acs::test::reply_has_status_code over manually checking status code in the reply

Fix close tag

added editor hints and white-space cleanup

    • -242
    • +248
    ./tcl/test/webtest-procs.tcl
  1. … 24 more files in changeset.
whitespace changes

  1. … 2 more files in changeset.
remove print.css and include its content in forums.css

Fix typo

Use fully-qualified api names

Indentation changes

Deprecate obsolete api

No need to explicitly delete reading info, as both oracle and postgres define the reference constraint as on delete cascade

Use fully-qualified api names

Use fully-qualified api names, assume message is there (something went very wrong otherwise)

Reduce divergency between oracle and postgres codebase

    • -18
    • +0
    ./tcl/messages-procs-postgresql.xql
Reduce divergency between oracle and postgres codebase

    • -26
    • +0
    ./tcl/messages-procs-postgresql.xql
Whitespace cleanup

Deprecate obsolete api

Implement operation in a way that oracle is supported

Add @see for deprecated procs

Use portable idioms

Use ad_include_contract

Whitespace cleanup

Reduce divergency between oracle and postgres codebase

    • -42
    • +0
    ./tcl/forums-callback-procs-oracle.xql
    • -43
    • +0
    ./tcl/forums-callback-procs-postgresql.xql
improve comments

  1. … 1 more file in changeset.
adding missing displayed_object_id, to get CKfinder working

improve spelling

  1. … 14 more files in changeset.