OpenACS / openacs-4 / packages

forums

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 61
Last Commit: 12:04
Commits this week: 0
Total Lines of Code (LoC): 22,611
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 08 Oct
4:52 pm

antoniop

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -2
    • +2
    ./tcl/messages-procs.tcl
Wednesday 11 Sep
8:11 am

gustafn

merge with missing files

Options
    • -0
    • +0
    ./lib/forums/admin-forums-chunk.tcl
    • -0
    • +0
    ./lib/forums/edit.tcl
    • -0
    • +0
    ./lib/forums/forums-chunk.tcl
    • -0
    • +0
    ./lib/forums/new.tcl
    • -0
    • +0
    ./lib/message/attachment-list.tcl
    • -0
    • +0
    ./lib/message/delete.tcl
    • -0
    • +0
    ./lib/message/post.tcl
    • -0
    • +0
    ./lib/message/row.tcl
    • -0
    • +0
    ./lib/message/row2.tcl
    • -0
    • +0
    ./lib/message/thread-chunk.tcl
    • -0
    • +0
    ./lib/message/threads-chunk.tcl
    • -0
    • +0
    ./lib/search/search-chunk.tcl
    • -0
    • +0
    ./lib/search/search-form.tcl
    • -0
    • +0
    ./lib/user/post-history-chunk.tcl
    • -0
    • +0
    ./tcl/forum-reply-procs.tcl
  16. … 1450 more files in changeset.
Tuesday 03 Sep
5:37 pm

gustafn

merge from oacs-5-10

Options
    • -11
    • +12
    ./forums.info
    • -5
    • +6
    ./catalog/forums.de_DE.ISO-8859-1.xml
    • -9
    • +10
    ./catalog/forums.en_US.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/forums.es_ES.ISO-8859-1.xml
    • -1
    • +2
    ./catalog/forums.it_IT.ISO-8859-1.xml
    • -1
    • +1
    ./lib/forums-portlet.tcl
    • -2
    • +2
    ./lib/forums/admin-forums-chunk.tcl
    • -4
    • +20
    ./lib/forums/edit.tcl
    • -19
    • +0
    ./lib/forums/forums-chunk-oracle.xql
    • -19
    • +0
    ./lib/forums/forums-chunk-postgresql.xql
    • -2
    • +13
    ./lib/forums/forums-chunk.tcl
    • -9
    • +22
    ./lib/forums/new.tcl
    • -1
    • +11
    ./lib/message/attachment-list.adp
    • -17
    • +68
    ./lib/message/attachment-list.tcl
    • -3
    • +5
    ./lib/message/delete.tcl
  16. … 8085 more files in changeset.
12:43 pm

antoniop

Cleanup leftover references to files deleted in https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Aantoniop%3A20200507144307

This was not preventing the installation or functionalities of the forums package, so it has been long missed. Upon closer inspection, errors were popping up in the installation UI.

Options
    • -2
    • +2
    ./forums.info
    • -4
    • +1
    ./sql/oracle/forums-create.sql
    • -3
    • +0
    ./sql/oracle/forums-drop.sql
    • -3
    • +0
    ./sql/postgresql/forums-create.sql
    • -3
    • +0
    ./sql/postgresql/forums-drop.sql
Monday 02 Sep
2:54 pm

gustafn

bumped version number from development version to release version

Options
    • -9
    • +9
    ./forums.info
  2. … 93 more files in changeset.
Wednesday 07 Aug
11:54 am

gustafn

Removed useless and hard to track ad_log messages in the forums:

Cannot determine package_id. Returning 0

Options
    • -11
    • +18
    ./tcl/messages-procs.tcl
Tuesday 06 Aug
12:16 pm

gustafn

reduce verbosity in the system log

Options
    • -1
    • +12
    ./tcl/forums-procs.tcl
Monday 15 Jul
2:07 pm

gustafn

improved spelling consistency

Options
    • -2
    • +2
    ./tcl/forums-procs.tcl
Wednesday 11 Oct 2023
2:03 pm

gustafn

strengthen boolean variables in page contracts

Options
    • -2
    • +2
    ./www/admin/subscribe-others-2.tcl
    • -2
    • +2
    ./www/admin/subscribe-others.tcl
    • -2
    • +2
    ./www/moderate/message-delete.tcl
    • -1
    • +1
    ./www/moderate/message-move.tcl
    • -1
    • +1
    ./www/moderate/move-thread-thread.tcl
    • -1
    • +1
    ./www/moderate/move-thread.tcl
    • -1
    • +1
    ./www/moderate/move.tcl
    • -1
    • +1
    ./www/moderate/thread-move-thread.tcl
    • -1
    • +1
    ./www/moderate/thread-move.tcl
  10. … 4 more files in changeset.
Thursday 13 Jul 2023
3:09 pm

gustafn

bumped version numbers to 5.10.1b1

Options
    • -7
    • +7
    ./forums.info
  2. … 85 more files in changeset.
Friday 14 Apr 2023
4:03 pm

antoniop

Prefer cached api

Options
    • -3
    • +5
    ./tcl/forums-procs.tcl
  2. … 1 more file in changeset.
Thursday 23 Mar 2023
1:47 pm

antoniop

Update uninstall callback:

- avoid convoluted idioms

- improve documentation

- use cross dbms api

Options
    • -11
    • +26
    ./tcl/forums-install-procs.tcl
Tuesday 21 Mar 2023
2:52 pm

antoniop

Format code in a way to avoid false positives where a column name is taken as a deprecated proc

Options
    • -9
    • +6
    ./tcl/forums-procs.tcl
2:51 pm

antoniop

Cleanup deprecated api from test

Options
    • -3
    • +2
    ./tcl/test/forums-procs.tcl
Monday 20 Mar 2023
5:07 pm

antoniop

Use UTF-8 emoji HTML entities instead of static images to convert smileys in the forums package

This has the advantage of not requiring a request to serve the images. It also avoids the need to hardcode the image size, as they will be basically treated as fonts.

Options
    • -19
    • +12
    ./tcl/messages-format-procs.tcl
    • -10
    • +11
    ./www/doc/emoticons.adp
4:35 pm

antoniop

Whitespace cleanup

Options
    • -5
    • +5
    ./tcl/messages-format-procs.tcl
4:02 pm

antoniop

Increase proc coverage, deprecate proc in the process

Options
    • -2
    • +11
    ./tcl/messages-procs.tcl
    • -6
    • +101
    ./tcl/test/forums-procs.tcl
3:15 pm

antoniop

Test cornercase behavior

Options
    • -2
    • +3
    ./tcl/test/forums-procs.tcl
2:58 pm

antoniop

Make Service Contract implementations private

Options
    • -5
    • +11
    ./tcl/forum-reply-procs.tcl
2:39 pm

antoniop

Deprecate forum::new_questions_allow and forum::new_questions_deny, one should use forum::edit, which will also track the change, or just inline the query instead

Options
    • -2
    • +6
    ./tcl/forums-callback-procs.tcl
    • -3
    • +11
    ./tcl/forums-procs.tcl
2:28 pm

antoniop

Deprecate forum::new_questions_allowed_p and replace occurrences

Options
    • -4
    • +2
    ./lib/message/threads-chunk.tcl
    • -2
    • +8
    ./tcl/forums-procs.tcl
    • -5
    • +1
    ./tcl/test/forums-procs.tcl
2:17 pm

antoniop

Increase proc coverage

Options
    • -9
    • +44
    ./tcl/test/forums-procs.tcl
Friday 24 Feb 2023
2:19 pm

antoniop

Give priority to the information provided explicitly to the api (the forum_id) in order to determine the package id and fallback to the connection context only when this is not available

Options
    • -12
    • +37
    ./tcl/forums-procs.tcl
Thursday 23 Feb 2023
5:12 pm

antoniop

Enforce data type of hidden fields, add missing parameters to the page contract

Options
    • -3
    • +6
    ./lib/message/post.tcl
Tuesday 08 Nov 2022
3:19 pm

gustafn

avoid subst in export_vars when not necessary

Options
    • -2
    • +3
    ./www/forum-view.tcl
  2. … 1 more file in changeset.
Friday 21 Oct 2022
10:52 am

gustafn

prefer adp:icon over old-style .gif images

Options
    • -1
    • +1
    ./lib/message/row.adp
  2. … 5 more files in changeset.
10:40 am

gustafn

prefer adp:icon over old-style .gif and .png mages

Options
    • -3
    • +3
    ./lib/message/attachment-list.adp
    • -4
    • +4
    ./lib/message/attachment-list.tcl
  3. … 1 more file in changeset.
Tuesday 30 Aug 2022
3:08 pm

antoniop

Reinstate the notnull validation constraint where missing

Options
    • -2
    • +2
    ./lib/message/post.tcl
    • -2
    • +2
    ./lib/message/threads-chunk.tcl
    • -2
    • +2
    ./lib/user/post-history-chunk.tcl
    • -1
    • +1
    ./www/forum-view-statistic.tcl
    • -2
    • +2
    ./www/forum-view.tcl
    • -1
    • +1
    ./www/load-message-content.tcl
    • -1
    • +1
    ./www/mark-all-read.tcl
    • -2
    • +2
    ./www/message-email.tcl
    • -2
    • +2
    ./www/user-history.tcl
    • -2
    • +2
    ./www/admin/forum-disable.tcl
    • -2
    • +2
    ./www/admin/forum-edit.tcl
    • -2
    • +2
    ./www/admin/forum-enable.tcl
    • -2
    • +2
    ./www/admin/permissions-user-add.tcl
    • -5
    • +5
    ./www/admin/subscribe-others-2.tcl
    • -2
    • +2
    ./www/admin/subscribe-others.tcl
  16. … 10 more files in changeset.
2:22 pm

gustafn

re-add notnull value constraint on message_id

This constraint was removed about 14 days ago. Without this constraint,

errors like the following will show up....

[30/Aug/2022:14:07:29.820625][3102633.7f152c28d700][-conn:openacs.org:default:0:196214-] Error: rp_handler no-script-abort: errorMsg can't read "message(forum_id)": no such variable while serving GE

T /forums/message-view?message_id HTTP/1.1

: ad_url </forums/message-view> maps to file </var/www/openacs.org/packages/forums/www/message-view.adp>

: TCL LOOKUP VARNAME message

: can't read "message(forum_id)": no such variable

: while executing

: "forum::get -forum_id $message(forum_id) -array forum"

Probably, in many more cases, the incorrect removal of the notnull constrain performed by [1]

requires the same fix.

[1] https://github.com/openacs/forums/commit/c403e3134ce4e73ba94a80540a8b0f3cb1651ed0#diff-d35c736495ede0174fb39791ab660c5cd1a4ca467db2c4741cfc935167d7e5a8

Options
    • -2
    • +2
    ./www/message-view.tcl
Monday 29 Aug 2022
4:17 pm

antoniop

Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

Options
    • -2
    • +2
    ./lib/forums/admin-forums-chunk.tcl
  2. … 33 more files in changeset.