• last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Url attachments in forums: use URL icon and avoid showing the size

Show attachment size in forum messages

Use the attachment icon, available since 10+ years, for forums attachments.

  1. … 1 more file in changeset.
Only show the possibility to allow/disallow attachments in the forum new/edit pages if the attachments package is already mounted under the forums package instance

  1. … 1 more file in changeset.
Whitespace changes

  1. … 2 more files in changeset.
Modify user interface to allow/disallow attachments per forum, on forum creation and editing. Added message keys and bumped version as well.

  1. … 7 more files in changeset.
Cleanup trailing whitespace

Extend 'forum::attachments_enabled_p' with 'forum_id', so attachments ca be enabled per forum (see previous commit), and update underliying logic to make use of it.

  1. … 2 more files in changeset.
Reduce divergency between oracle and postgres codebase

    • -19
    • +0
    ./forums/forums-chunk-postgresql.xql
  1. … 3 more files in changeset.
fix invalid markup

follow usual indentation

ad_sign: generalize last ad_sign handling to

allow user and csrf binding

  1. … 2 more files in changeset.
use user-specific sign operations for protecting delete operations

  1. … 1 more file in changeset.
Secure forums delete button by protecting the message_id with a timed signature

  1. … 1 more file in changeset.
improve spelling

  1. … 8 more files in changeset.
show forum-edit link only, if the current forum is from the current package (see admin/forum-edit)

use consistently bind variables

improve rowcount expressions

  1. … 66 more files in changeset.
Prefer 'person::name' to 'acs_user::get_element ... -name'

  1. … 8 more files in changeset.
Use new fine grained api for the screen name

Remove hotfix and use new user api

Remove user hotfix and replace with new api (which won't fail for non-registered users)

Re-estate query variable, as programs around expect it

Fix typos

  1. … 5 more files in changeset.
Fix regressions in forums when user is not logged in

  1. … 1 more file in changeset.
Avoid two times the same query just because we might filter by forum

    • -20
    • +2
    ./search/search-chunk-postgresql.xql
Pass user_name through the message array, as message-view expects it there

This obscure script doesn't do much (basically, displays the content of a message), but nevertheless was passing arrays, defining queries, duplicating code... streamlined to the bones

    • -46
    • +0
    ./message/content-updater-oracle.xql
    • -51
    • +0
    ./message/content-updater-postgresql.xql
  1. … 2 more files in changeset.
Remove redundant variables, dead code and bring variables closer to where they are actually used... still room for improvement here

    • -10
    • +4
    ./message/thread-chunk-postgresql.xql
Reduce divergencies between oracle and postgres codebase, reduce the need for joins and stored procedures

    • -41
    • +0
    ./message/threads-chunk-postgresql.xql