• last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
This obscure script doesn't do much (basically, displays the content of a message), but nevertheless was passing arrays, defining queries, duplicating code... streamlined to the bones

    • -46
    • +0
    ./message/content-updater-oracle.xql
    • -51
    • +0
    ./message/content-updater-postgresql.xql
  1. … 2 more files in changeset.
Remove redundant variables, dead code and bring variables closer to where they are actually used... still room for improvement here

    • -10
    • +4
    ./message/thread-chunk-postgresql.xql
Reduce divergencies between oracle and postgres codebase, reduce the need for joins and stored procedures

    • -41
    • +0
    ./message/threads-chunk-postgresql.xql
Centralize templating cache "black magic"

Use the new proc into forum api

  1. … 1 more file in changeset.
Replace deprecated 'forum::security::can_moderate_forum_p' by 'permission::permission_p'

  1. … 2 more files in changeset.
Create 'ad_include_contract' for forums portlet

Prefer literal in adp expressions + Whitespace changes

  1. … 6 more files in changeset.
Exploit users cache, simplify SQL

Shorten expression, exploit cache

use more consistent spelling of names

Prefer individual 'set' operations over 'lassign' in these particular cases

  1. … 6 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 474 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 224 more files in changeset.
Rework variable assignment (set -> lassign)

  1. … 11 more files in changeset.
remove parens

  1. … 1 more file in changeset.
delete unreferenced .xql queries

  1. … 1 more file in changeset.
Fix boolean expressions in -adp files, make termination after connection closing commands explicit

  1. … 18 more files in changeset.
Reduce divergencies between oracle and postgres codebase

    • -11
    • +0
    ./forums/forums-chunk-postgresql.xql
    • -0
    • +15
    ./forums/forums-chunk.xql
  1. … 3 more files in changeset.
Reduce divergencies between oracle and postgres codebase

    • -32
    • +0
    ./message/threads-chunk-postgresql.xql
Make forum::use_ReadingInfo_p more robust when UseReadingInfo parameter in forums is not set

  1. … 2 more files in changeset.
make boolean test strict

  1. … 1 more file in changeset.
Hot fix for latest changes concerning reading info

  1. … 1 more file in changeset.
Remove deprecated idioms and unneded queries

Implement post anonymously through explicit forum attribute in table

Now moderators can explicitly decide whether a forum will enable posting anonymously or not.

Forum must be in a policy different from closed and the anonymous flag must be set accordingly for this to happen.

Also:

- normalize api in a way it can accomodate all current attributes. In particular,

now edit api will now leave every unspecified attribute unchanged, instead of

setting it to some default.

- fix some usability issues when managing forum parameters (e.g. values not

retrieved in form when editing existing forum)

- introduce missing Oracle upgrade script for the whole forum reform

- fix oracle creation script

  1. … 9 more files in changeset.
Normalize boolean expressions in .adp code

  1. … 4 more files in changeset.
Normalize boolean expressions in .adp files

normalize boolean expressions in .adp files

Bug fix: avoid confusion between command argument and option, when argument starts with "-"

  1. … 81 more files in changeset.
Show moderate button only when forum is actually moderated

check truth by lean and mean tcl idiom

Forum reform

- remove hardcoded dependency with registered_users group. Target is to improve suitability in convoluted multi groups/multi subsites context

- in place of previous permission-based machinery, use plain table columns to detect whether user can or cannot post replies/new threads

- remove permission check at the message level in favor of that on forum level

  1. … 18 more files in changeset.