OpenACS / openacs-4 / packages / forums

lib

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 26 Dec
Commits this week: 0
Total Lines of Code (LoC): 3,368
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 8 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 27 Jun 2018
7:09 pm

antoniop

Remove user hotfix and replace with new api (which won't fail for non-registered users)

Options
    • -9
    • +3
    ./message/post.tcl
Tuesday 26 Jun 2018
12:39 pm

antoniop

Re-estate query variable, as programs around expect it

Options
    • -3
    • +4
    ./search/search-chunk.tcl
Monday 25 Jun 2018
2:44 pm

hectorr

Fix typos

Options
    • -1
    • +1
    ./message/post.adp
  2. … 5 more files in changeset.
11:15 am

antoniop

Fix regressions in forums when user is not logged in

Options
    • -7
    • +23
    ./forums/forums-history-chunk.tcl
    • -3
    • +8
    ./message/post.tcl
    • -2
    • +3
    ./message/row.adp
    • -4
    • +10
    ./message/row.tcl
    • -8
    • +13
    ./message/threads-chunk.tcl
  6. … 1 more file in changeset.
Friday 15 Jun 2018
10:55 pm

antoniop

Avoid two times the same query just because we might filter by forum

Options
    • -20
    • +2
    ./search/search-chunk-oracle.xql
    • -20
    • +2
    ./search/search-chunk-postgresql.xql
    • -12
    • +10
    ./search/search-chunk.tcl
10:50 pm

antoniop

Pass user_name through the message array, as message-view expects it there

Options
    • -2
    • +2
    ./message/row.adp
    • -4
    • +4
    ./message/row.tcl
10:26 pm

antoniop

This obscure script doesn't do much (basically, displays the content of a message), but nevertheless was passing arrays, defining queries, duplicating code... streamlined to the bones

Options
    • -46
    • +0
    ./message/content-updater-oracle.xql
    • -51
    • +0
    ./message/content-updater-postgresql.xql
    • -8
    • +0
    ./message/content-updater.adp
    • -45
    • +0
    ./message/content-updater.tcl
  5. … 2 more files in changeset.
9:59 pm

antoniop

Remove redundant variables, dead code and bring variables closer to where they are actually used... still room for improvement here

Options
    • -3
    • +8
    ./message/row.adp
    • -16
    • +5
    ./message/row.tcl
    • -2
    • +0
    ./message/thread-chunk-oracle.xql
    • -10
    • +4
    ./message/thread-chunk-postgresql.xql
    • -19
    • +15
    ./message/thread-chunk.tcl
Monday 11 Jun 2018
4:31 pm

antoniop

Reduce divergencies between oracle and postgres codebase, reduce the need for joins and stored procedures

Options
    • -41
    • +0
    ./message/threads-chunk-oracle.xql
    • -41
    • +0
    ./message/threads-chunk-postgresql.xql
    • -5
    • +12
    ./message/threads-chunk.tcl
    • -6
    • +24
    ./message/threads-chunk.xql
4:04 pm

antoniop

Centralize templating cache "black magic"

Use the new proc into forum api

Options
    • -5
    • +1
    ./message/post.tcl
  2. … 1 more file in changeset.
Thursday 07 Jun 2018
8:08 pm

hectorr

Replace deprecated 'forum::security::can_moderate_forum_p' by 'permission::permission_p'

Options
    • -21
    • +21
    ./message/post.tcl
  2. … 2 more files in changeset.
Wednesday 06 Jun 2018
4:34 pm

hectorr

Create 'ad_include_contract' for forums portlet

Options
    • -1
    • +1
    ./forums-portlet.adp
    • -41
    • +29
    ./forums-portlet.tcl
Tuesday 22 May 2018
7:07 pm

hectorr

Prefer literal in adp expressions + Whitespace changes

Options
    • -31
    • +31
    ./forums-portlet.adp
  2. … 6 more files in changeset.
5:59 pm

antoniop

Exploit users cache, simplify SQL

Options
    • -2
    • +16
    ./forums/forums-history-chunk.tcl
    • -12
    • +0
    ./forums/forums-history-chunk.xql
5:27 pm

antoniop

Shorten expression, exploit cache

Options
    • -6
    • +2
    ./search/search-chunk.tcl
Thursday 17 May 2018
9:41 am

gustafn

use more consistent spelling of names

Options
    • -2
    • +2
    ./message/thread-chunk.tcl
12:04 am

hectorr

Prefer individual 'set' operations over 'lassign' in these particular cases

Options
    • -2
    • +3
    ./message/attachment-list.tcl
  2. … 6 more files in changeset.
Wednesday 09 May 2018
5:33 pm

hectorr

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

Options
    • -2
    • +2
    ./forums/forums-chunk.tcl
    • -2
    • +2
    ./message/threads-chunk.tcl
  3. … 474 more files in changeset.
Thursday 26 Apr 2018
10:56 am

hectorr

Prefer '{}' to '[list]' when creating empty lists

Options
    • -2
    • +2
    ./forums/forums-chunk.tcl
    • -2
    • +2
    ./message/threads-chunk.tcl
  3. … 224 more files in changeset.
Tuesday 24 Apr 2018
4:28 pm

hectorr

Rework variable assignment (set -> lassign)

Options
    • -7
    • +4
    ./forums-portlet.tcl
    • -3
    • +2
    ./message/attachment-list.tcl
  3. … 11 more files in changeset.
Saturday 07 Apr 2018
9:07 pm

gustafn

remove parens

Options
    • -2
    • +2
    ./forums/admin-forums-chunk.tcl
    • -2
    • +2
    ./forums/forums-chunk.tcl
    • -1
    • +1
    ./forums/forums-history-chunk.tcl
    • -2
    • +2
    ./message/delete.tcl
    • -2
    • +2
    ./message/messages-table.tcl
    • -2
    • +2
    ./message/pending-list-chunk.tcl
    • -2
    • +2
    ./message/threads-chunk.tcl
    • -2
    • +2
    ./search/search-chunk.tcl
  9. … 1 more file in changeset.
Saturday 27 Jan 2018
6:01 pm

gustafn

delete unreferenced .xql queries

Options
    • -35
    • +0
    ./search/search-chunk-oracle.xql
  2. … 1 more file in changeset.
Saturday 20 Jan 2018
11:49 pm

gustafn

Fix boolean expressions in -adp files, make termination after connection closing commands explicit

Options
    • -2
    • +3
    ./message/attachment-list.tcl
  2. … 18 more files in changeset.
Thursday 23 Nov 2017
1:33 pm

antoniop

Reduce divergencies between oracle and postgres codebase

Options
    • -10
    • +0
    ./forums/forums-chunk-oracle.xql
    • -11
    • +0
    ./forums/forums-chunk-postgresql.xql
    • -0
    • +15
    ./forums/forums-chunk.xql
  4. … 3 more files in changeset.
Wednesday 22 Nov 2017
3:02 pm

antoniop

Reduce divergencies between oracle and postgres codebase

Options
    • -29
    • +0
    ./message/threads-chunk-oracle.xql
    • -32
    • +0
    ./message/threads-chunk-postgresql.xql
    • -0
    • +34
    ./message/threads-chunk.xql
Thursday 16 Nov 2017
1:40 pm

antoniop

Make forum::use_ReadingInfo_p more robust when UseReadingInfo parameter in forums is not set

Options
    • -2
    • +2
    ./forums/forums-chunk.tcl
    • -2
    • +2
    ./message/threads-chunk.tcl
  3. … 2 more files in changeset.
12:03 pm

gustafn

make boolean test strict

Options
    • -2
    • +2
    ./forums/forums-chunk.tcl
    • -2
    • +2
    ./message/threads-chunk.tcl
  3. … 1 more file in changeset.
11:58 am

gustafn

Hot fix for latest changes concerning reading info

Options
    • -2
    • +2
    ./forums/forums-chunk.tcl
    • -2
    • +2
    ./message/threads-chunk.tcl
  3. … 1 more file in changeset.
Thursday 09 Nov 2017
6:28 pm

antoniop

Remove deprecated idioms and unneded queries

Options
    • -8
    • +0
    ./message/post-oracle.xql
    • -8
    • +0
    ./message/post-postgresql.xql
    • -14
    • +13
    ./message/post.tcl
    • -13
    • +0
    ./message/post.xql
Wednesday 08 Nov 2017
1:05 pm

antoniop

Implement post anonymously through explicit forum attribute in table

Now moderators can explicitly decide whether a forum will enable posting anonymously or not.

Forum must be in a policy different from closed and the anonymous flag must be set accordingly for this to happen.

Also:

- normalize api in a way it can accomodate all current attributes. In particular,

now edit api will now leave every unspecified attribute unchanged, instead of

setting it to some default.

- fix some usability issues when managing forum parameters (e.g. values not

retrieved in form when editing existing forum)

- introduce missing Oracle upgrade script for the whole forum reform

- fix oracle creation script

Options
    • -22
    • +32
    ./forums/edit.tcl
    • -18
    • +18
    ./forums/new.tcl
  3. … 9 more files in changeset.