• last updated 17 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Modify user interface to allow/disallow attachments per forum, on forum creation and editing. Added message keys and bumped version as well.

  1. … 7 more files in changeset.
Cleanup trailing whitespace

Extend 'forum::attachments_enabled_p' with 'forum_id', so attachments ca be enabled per forum (see previous commit), and update underliying logic to make use of it.

  1. … 2 more files in changeset.
Reduce divergency between oracle and postgres codebase

    • -19
    • +0
  1. … 3 more files in changeset.
fix invalid markup

follow usual indentation

ad_sign: generalize last ad_sign handling to

allow user and csrf binding

  1. … 2 more files in changeset.
use user-specific sign operations for protecting delete operations

  1. … 1 more file in changeset.
Secure forums delete button by protecting the message_id with a timed signature

  1. … 1 more file in changeset.
improve spelling

  1. … 8 more files in changeset.
show forum-edit link only, if the current forum is from the current package (see admin/forum-edit)

use consistently bind variables

improve rowcount expressions

  1. … 66 more files in changeset.
Prefer 'person::name' to 'acs_user::get_element ... -name'

  1. … 8 more files in changeset.
Use new fine grained api for the screen name

Remove hotfix and use new user api

Remove user hotfix and replace with new api (which won't fail for non-registered users)

Re-estate query variable, as programs around expect it

Fix typos

  1. … 5 more files in changeset.
Fix regressions in forums when user is not logged in

  1. … 1 more file in changeset.
Avoid two times the same query just because we might filter by forum

    • -20
    • +2
Pass user_name through the message array, as message-view expects it there

This obscure script doesn't do much (basically, displays the content of a message), but nevertheless was passing arrays, defining queries, duplicating code... streamlined to the bones

    • -46
    • +0
    • -51
    • +0
  1. … 2 more files in changeset.
Remove redundant variables, dead code and bring variables closer to where they are actually used... still room for improvement here

    • -10
    • +4
Reduce divergencies between oracle and postgres codebase, reduce the need for joins and stored procedures

    • -41
    • +0
Centralize templating cache "black magic"

Use the new proc into forum api

  1. … 1 more file in changeset.
Replace deprecated 'forum::security::can_moderate_forum_p' by 'permission::permission_p'

  1. … 2 more files in changeset.
Create 'ad_include_contract' for forums portlet

Prefer literal in adp expressions + Whitespace changes

  1. … 6 more files in changeset.
Exploit users cache, simplify SQL