OpenACS / openacs-4

packages

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 9
Total Committers: 139
Last Commit: 01 Oct
Commits this week: 9
Total Lines of Code (LoC): 5,069,238
Net change in LoC this week: -3,787

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 01 Sep 2020
5:19 pm

antoniop

Improve sql portability

Options
    • -4
    • +7
    ./forums/www/admin/subscribe-others-2.tcl
5:11 pm

antoniop

Replace limit idiom with portable idiom

Options
    • -8
    • +0
    ./assessment/tcl/as-apm-action-procs-oracle.xql
    • -10
    • +0
    ./assessment/tcl/as-apm-action-procs-postgresql.xql
    • -1
    • +5
    ./assessment/tcl/as-apm-action-procs.tcl
4:40 pm

antoniop

Avoid the not portable limit idiom, just kill the recursive part using the flag instead

...although one should point out that Oracle does not support the boolean type...

Options
    • -5
    • +4
    ./acs-tcl/tcl/site-nodes-procs.tcl
4:35 pm

antoniop

Improve portability of test code

Options
    • -3
    • +3
    ./acs-tcl/tcl/test/db-proc-test-procs.tcl
4:32 pm

antoniop

Replace limit with a portable idiom

Options
    • -5
    • +5
    ./acs-subsite/tcl/group-procs.tcl
4:28 pm

antoniop

Improve sql portability

Options
    • -2
    • +3
    ./acs-mail-lite/tcl/email-inbound-procs.tcl
    • -2
    • +3
    ./acs-mail-lite/tcl/imap-inbound-procs.tcl
4:26 pm

antoniop

Replace limit (pg only) with fetch idiom, which should be portable on "modern" Oracle

Options
    • -2
    • +9
    ./acs-mail-lite/tcl/acs-mail-lite-procs.tcl
    • -13
    • +0
    ./acs-mail-lite/tcl/acs-mail-lite-procs.xql
4:18 pm

antoniop

Reduce divergencies between oracle and postgres codebase

Options
    • -9
    • +0
    ./acs-authentication/tcl/test/acs-authentication-procs-oracle.xql
    • -10
    • +0
    ./acs-authentication/tcl/test/acs-authentication-procs-postgresql.xql
    • -2
    • +6
    ./acs-authentication/tcl/test/acs-authentication-procs.tcl
4:13 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -20
    • +0
    ./acs-api-browser/www/index-oracle.xql
    • -20
    • +0
    ./acs-api-browser/www/index-postgresql.xql
    • -2
    • +8
    ./acs-api-browser/www/index.tcl
4:09 pm

antoniop

Improve portability, fetch idiom should be supported by "modern Oracle"

Options
    • -2
    • +2
    ./acs-admin/www/auth/authority-set-sort-order.tcl
4:04 pm

antoniop

Rewrite idiom to be portable (limit is psql only)

Options
    • -2
    • +8
    ./notifications/tcl/notification-callback-procs.tcl
    • -10
    • +0
    ./notifications/tcl/notification-callback-procs.xql
2:40 pm

antoniop

Pass check_active_p from the including page

Options
    • -0
    • +1
    ./proctoring-support/www/upload.adp
    • -0
    • +1
    ./proctoring-support/www/upload.tcl
2:00 pm

antoniop

Disable proctored-session expiration check based on proctoring-support datamodel using the new flag, enable preview as before (upstream code has it disabled by default), disable examination statement as intended

Options
    • -5
    • +4
    ./xowf/lib/inclass-exam.wf
1:54 pm

antoniop

Pass the check_active_p flag down to the backend from the proctored page, update doc

Options
    • -0
    • +1
    ./proctoring-support/lib/proctored-page.adp
    • -5
    • +16
    ./proctoring-support/lib/proctored-page.tcl
    • -0
    • +1
    ./proctoring-support/www/resources/proctored-page.js
1:36 pm

antoniop

Add semicolon (just for consistency, code was working before as well)

Options
    • -1
    • +1
    ./proctoring-support/www/resources/proctored-page.js
1:34 pm

antoniop

Add a new flag to disable check on proctoring start/end time for applications that do not store this info in the package datamodel, improve doc

Options
    • -1
    • +18
    ./proctoring-support/lib/proctoring-upload.tcl
12:48 pm

antoniop

Fix retrieving the template

Options
    • -2
    • +2
    ./xowf/lib/inclass-exam.wf
Monday 31 Aug 2020
7:14 pm

hectorr

Add 'dotlrn_chat__applet_portlet' test case, covering 'dotlrn_chat::add_applet', 'dotlrn_chat::add_portlet', 'dotlrn_chat::add_portlet_helper', 'dotlrn_chat::remove_portlet' and 'dotlrn_chat::remove_applet'

Options
    • -0
    • +84
    ./dotlrn-chat/tcl/test/dotlrn-chat-test-procs.tcl
7:10 pm

hectorr

Implement the 'dotlrn_applet::remove_applet_from_dotlrn' proc, called from different remove_applet procs, but never implemented

Options
    • -0
    • +17
    ./dotlrn/tcl/applets-procs.tcl
    • -0
    • +19
    ./dotlrn/tcl/applets-procs.xql
5:40 pm

antoniop

Replace xowf proctoring implementation with that coming from proctoring-support

TODO: nicer detection of whether proctoring-support package is actually installed

Options
    • -7
    • +9
    ./xowf/lib/inclass-exam.wf
    • -239
    • +0
    ./xowf/lib/proctored-page.adp
    • -208
    • +0
    ./xowf/lib/proctored-page.tcl
    • -67
    • +0
    ./xowf/lib/proctoring-upload.tcl
    • -3
    • +0
    ./xowf/www/resources/proctoring/gif.js
    • -1
    • +0
    ./xowf/www/resources/proctoring/gif.js.map
    • -3
    • +0
    ./xowf/www/resources/proctoring/gif.worker.js
    • -1
    • +0
    ./xowf/www/resources/proctoring/gif.worker.js.map
    • -754
    • +0
    ./xowf/www/resources/proctoring/proctoring.js
4:35 pm

gustafn

prefer SQL max() function over sort and limit 1

Options
    • -2
    • +1
    ./rss-support/tcl/rss-utilities-procs.xql
    • -3
    • +4
    ./xowiki/tcl/package-procs.tcl
2:42 pm

antoniop

Make apm callbacks private and move them together with the others

Options
    • -0
    • +70
    ./acs-subsite/tcl/apm-callback-procs.tcl
    • -73
    • +1
    ./acs-subsite/tcl/subsite-procs.tcl
2:41 pm

antoniop

Maintain also the has_child cache when mounting a package

Options
    • -1
    • +3
    ./acs-tcl/tcl/site-nodes-procs.tcl
1:56 pm

antoniop

Fix typo

Options
    • -2
    • +2
    ./acs-tcl/tcl/site-nodes-procs.tcl
9:46 am

antoniop

Make installation procs private

Options
    • -8
    • +8
    ./news/tcl/news-apm-callback-procs.tcl
Friday 28 Aug 2020
6:45 pm

antoniop

When a new group is created, flush all the group::get_id caches with the same name so that the new group has a chance to be retrieved

Note that it is wrong to assume a group_name will be unique, although this is normally not far from the truth in our everyday practice

Options
    • -1
    • +7
    ./acs-subsite/tcl/group-procs.tcl
6:42 pm

antoniop

Cover more group api

this also exposes a potential problem with group::get_id when a group is created, deleted, and then a new one is created with the same name (e.g. executing the test multiple times). As the memoize cache is not maintained, the returned group_id will be incorrect.

Options
    • -1
    • +18
    ./acs-subsite/tcl/test/acs-subsite-procs.tcl
5:25 pm

antoniop

Increase proc coverage

Options
    • -1
    • +3
    ./acs-subsite/tcl/test/acs-subsite-procs.tcl
4:51 pm

antoniop

Reinstate lost queries for content::item::content_is_null

Options
    • -0
    • +15
    ./acs-content-repository/tcl/content-item-procs-oracle.xql
    • -0
    • +15
    ./acs-content-repository/tcl/content-item-procs-postgresql.xql
4:51 pm

antoniop

file content-item-procs-postgresql.xql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./acs-content-repository/tcl/content-item-procs-postgresql.xql