• last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improve portability, fetch idiom should be supported by "modern Oracle"

Rewrite idiom to be portable (limit is psql only)

    • -2
    • +8
    ./notifications/tcl/notification-callback-procs.tcl
    • -10
    • +0
    ./notifications/tcl/notification-callback-procs.xql
Pass check_active_p from the including page

Disable proctored-session expiration check based on proctoring-support datamodel using the new flag, enable preview as before (upstream code has it disabled by default), disable examination statement as intended

Pass the check_active_p flag down to the backend from the proctored page, update doc

    • -0
    • +1
    ./proctoring-support/lib/proctored-page.adp
    • -5
    • +16
    ./proctoring-support/lib/proctored-page.tcl
Add semicolon (just for consistency, code was working before as well)

Add a new flag to disable check on proctoring start/end time for applications that do not store this info in the package datamodel, improve doc

    • -1
    • +18
    ./proctoring-support/lib/proctoring-upload.tcl
Fix retrieving the template

Add 'dotlrn_chat__applet_portlet' test case, covering 'dotlrn_chat::add_applet', 'dotlrn_chat::add_portlet', 'dotlrn_chat::add_portlet_helper', 'dotlrn_chat::remove_portlet' and 'dotlrn_chat::remove_applet'

Implement the 'dotlrn_applet::remove_applet_from_dotlrn' proc, called from different remove_applet procs, but never implemented

Replace xowf proctoring implementation with that coming from proctoring-support

TODO: nicer detection of whether proctoring-support package is actually installed

    • -3
    • +0
    ./xowf/www/resources/proctoring/gif.js
    • -1
    • +0
    ./xowf/www/resources/proctoring/gif.js.map
prefer SQL max() function over sort and limit 1

    • -2
    • +1
    ./rss-support/tcl/rss-utilities-procs.xql
Make apm callbacks private and move them together with the others

    • -0
    • +70
    ./acs-subsite/tcl/apm-callback-procs.tcl
    • -73
    • +1
    ./acs-subsite/tcl/subsite-procs.tcl
Maintain also the has_child cache when mounting a package

Fix typo

Make installation procs private

    • -8
    • +8
    ./news/tcl/news-apm-callback-procs.tcl
When a new group is created, flush all the group::get_id caches with the same name so that the new group has a chance to be retrieved

Note that it is wrong to assume a group_name will be unique, although this is normally not far from the truth in our everyday practice

Cover more group api

this also exposes a potential problem with group::get_id when a group is created, deleted, and then a new one is created with the same name (e.g. executing the test multiple times). As the memoize cache is not maintained, the returned group_id will be incorrect.

    • -1
    • +18
    ./acs-subsite/tcl/test/acs-subsite-procs.tcl
Increase proc coverage

    • -1
    • +3
    ./acs-subsite/tcl/test/acs-subsite-procs.tcl
Reinstate lost queries for content::item::content_is_null

    • -0
    • +15
    ./acs-content-repository/tcl/content-item-procs-oracle.xql
    • -0
    • +15
    ./acs-content-repository/tcl/content-item-procs-postgresql.xql
file content-item-procs-oracle.xql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./acs-content-repository/tcl/content-item-procs-oracle.xql
file content-item-procs-postgresql.xql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./acs-content-repository/tcl/content-item-procs-postgresql.xql
Move examination statement acceptance as last step of the proctoring wizard, localize the accept button, bind ajax logging of acceptance to the actual clicking of the accept button

    • -2
    • +2
    ./proctoring-support/proctoring-support.info
    • -0
    • +1
    ./proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml
    • -0
    • +1
    ./proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml
    • -5
    • +6
    ./proctoring-support/lib/proctored-page.adp
Improve test

    • -8
    • +13
    ./acs-lang/tcl/test/acs-lang-localization-procs.tcl
New test for lang::util::convert_to_i18n pinpointing some expected behaviors of this proc

    • -0
    • +67
    ./acs-lang/tcl/test/acs-lang-localization-procs.tcl
Upgrade CKEditor to 4.14.1

    • -4
    • +4
    ./richtext-ckeditor4/richtext-ckeditor4.info
    • -4
    • +4
    ./richtext-ckeditor4/tcl/richtext-procs.tcl
Improve doc and minor refactoring to reduce the diff with possible upcoming change

Fix typo

cache method "has_children" to avoid frequent (but cheap) DB calls

    • -16
    • +30
    ./acs-tcl/tcl/site-nodes-procs.tcl
improve handling of errors, which are triggerd by the error template

    • -2
    • +10
    ./acs-tcl/tcl/request-processor-procs.tcl