OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 3
Total Committers: 73
Last Commit: 17 May
Commits this week: 3
Total Lines of Code (LoC): 68,337
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 25 Jul 2018
7:44 pm

hectorr

Harmonize parameter names in proc documentation removing unnecessary hyphens

Options
    • -2
    • +2
    ./tcl/apm-file-procs.tcl
    • -4
    • +4
    ./tcl/defs-procs.tcl
    • -4
    • +4
    ./tcl/deprecated-procs.tcl
    • -2
    • +2
    ./tcl/utilities-procs.tcl
  5. … 1 more file in changeset.
7:36 pm

hectorr

Fix parameter name

Options
    • -3
    • +3
    ./tcl/deprecated-procs.tcl
7:35 pm

hectorr

Allow square brackets in proc doc. In particular, this fixed a false positive with [doc_string] in 'ad_proc'

Options
    • -2
    • +1
    ./tcl/test/doc-check-procs.tcl
7:15 pm

hectorr

Improve 'args' check in 'documentation__check_parameters' test case by using the built-in 'varargs_p' variable.

Options
    • -4
    • +2
    ./tcl/test/doc-check-procs.tcl
6:47 pm

hectorr

Add 'args' parameter to the real parameter list of the 'documentation__check_parameters', as it is not included into 'switches' or 'positionals'.

Options
    • -1
    • +13
    ./tcl/test/doc-check-procs.tcl
6:15 pm

hectorr

Use 'apm_get_package_files -file_types' instead of filtering the 'www' and 'lib' directories manually.

Options
    • -10
    • +10
    ./tcl/test/file-test-procs.tcl
4:53 pm

hectorr

Take care of '_p' boolean parameters when checking for discrepancies between real and documented proc parameters.

Options
    • -9
    • +11
    ./tcl/test/doc-check-procs.tcl
3:42 pm

gustafn

Overhaul of test cases:

- make tested API calls explict

- reduce dependency on twt

Options
    • -9
    • +16
    ./tcl/test/acs-tcl-apm-procs.tcl
    • -5
    • +11
    ./tcl/test/ad-proc-test-procs.tcl
    • -1
    • +98
    ./tcl/test/apm-parameter-test-procs.tcl
    • -113
    • +141
    ./tcl/test/application-data-link-procs.tcl
    • -8
    • +28
    ./tcl/test/community-core-test-procs.tcl
    • -15
    • +33
    ./tcl/test/datamodel-test-procs.tcl
    • -3
    • +60
    ./tcl/test/doc-check-procs.tcl
    • -26
    • +64
    ./tcl/test/file-test-procs.tcl
    • -29
    • +174
    ./tcl/test/html-conversion-procs.tcl
    • -1
    • +4
    ./tcl/test/html-email-procs.tcl
    • -2
    • +8
    ./tcl/test/memoizing-procs.tcl
    • -41
    • +24
    ./tcl/test/navigation-procs.tcl
    • -8
    • +6
    ./tcl/test/object-test-case-procs.tcl
    • -12
    • +20
    ./tcl/test/openacs-kernel-procs.tcl
    • -12
    • +21
    ./tcl/test/test-membership-rel-procs.tcl
  16. … 4 more files in changeset.
5:10 am

gustafn

don't leak user_ids from regression test case

Options
    • -10
    • +9
    ./tcl/test/community-core-test-procs.tcl
4:51 am

gustafn

make tested API calls explicit

Options
    • -4
    • +19
    ./tcl/test/acs-tcl-test-procs.tcl
    • -3
    • +4
    ./tcl/test/navigation-procs.tcl
    • -7
    • +23
    ./tcl/test/site-nodes-test-procs.tcl
3:50 am

gustafn

prefer built-in ns_dbquotevalue over DoubleApos

Options
    • -6
    • +4
    ./tcl/00-database-procs.tcl
    • -2
    • +2
    ./tcl/json-procs.tcl
    • -8
    • +14
    ./tcl/utilities-procs.tcl
3:38 am

gustafn

make former private functions, used in several packages to public functions

Options
    • -3
    • +3
    ./tcl/00-database-procs.tcl
    • -4
    • +4
    ./tcl/apm-file-procs.tcl
    • -2
    • +2
    ./tcl/apm-xml-procs.tcl
    • -3
    • +3
    ./tcl/exception-procs.tcl
    • -3
    • +3
    ./tcl/tcl-documentation-procs.tcl
Tuesday 24 Jul 2018
9:42 pm

gustafn

improve spelling

Options
    • -2
    • +7
    ./tcl/security-procs.tcl
  2. … 2 more files in changeset.
9:29 pm

hectorr

Add new test case 'documentation__check_parameters', which checks if parameters defined in the proc doc (@param) are really proc parameters.

Sometimes proc parameter changes are not reflected in the proc doc, this should take care of some of these cases.

Options
    • -1
    • +62
    ./tcl/test/doc-check-procs.tcl
7:57 pm

gustafn

improve spelling

Options
    • -3
    • +3
    ./tcl/apm-install-procs.tcl
5:48 pm

hectorr

Improve the list of common typos for the 'documentation__check_typos' test case, including some from Wikipedia: https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines

Options
    • -1
    • +3354
    ./tcl/test/doc-check-procs-common-typos.txt
4:59 pm

hectorr

Remove apparent leftover + trailing whitespace

Options
    • -4
    • +3
    ./tcl/test/doc-check-procs.tcl
4:47 pm

hectorr

Add new test case 'files__page_contracts', which checks for the existance of both 'ad_page_contract' and 'ad_include_contract' in the .tcl files inside 'www' and 'lib' package directories.

There are cases, where includelets are not stored in 'lib' but 'www', or have 'ad_page_contract' instead of 'ad_include_contract'. Checking if the location of includelets is correct is not so clear, so we avoid doing this in this particular test.

Options
    • -1
    • +78
    ./tcl/test/file-test-procs.tcl
3:13 pm

gustafn

rework test case documentation__check_typos

- make test case more robust (don't abort tests when there is a proc_doc without a "main" section

- improve performance and sanity:

* move invariantes out of the loop

* use built-in hashes

* don't check the same term multiple times

... times went from >15 sec to <1sec

Options
    • -24
    • +39
    ./tcl/test/doc-check-procs.tcl
3:09 pm

gustafn

remove useless semicolon

Options
    • -2
    • +1
    ./tcl/test/acs-tcl-test-procs.tcl
2:28 pm

hectorr

Add new test case 'files__trailing_whitespace', which looks for trailing whitespace (spaces or tabs at the end of lines).

Currently, only .tcl files are checked.

Options
    • -2
    • +2
    ./tcl/test/doc-check-procs.tcl
    • -1
    • +57
    ./tcl/test/file-test-procs.tcl
10:35 am

gustafn

no reason for casting values to integer

Options
    • -2
    • +2
    ./tcl/test/acs-tcl-test-procs.tcl
10:14 am

antoniop

incr would return a decimal number, but test wants an integer to be returned. Restore expr and make clear that we want an integer out of it

Options
    • -2
    • +2
    ./tcl/test/acs-tcl-test-procs.tcl
10:10 am

antoniop

Streamline util_sets_equal_p (passes automated test)

Options
    • -15
    • +3
    ./tcl/utilities-procs.tcl
10:02 am

hectorr

Add more information about typos loaded and checks passed

Options
    • -2
    • +5
    ./tcl/test/doc-check-procs.tcl
12:50 am

hectorr

Fix typo + Whitespace changes

Options
    • -21
    • +15
    ./tcl/test/file-test-procs.tcl
12:27 am

hectorr

Test refactoring

Options
    • -9
    • +11
    ./tcl/test/doc-check-procs.tcl
12:05 am

hectorr

Improve test documentation.

Options
    • -4
    • +21
    ./tcl/test/doc-check-procs.tcl
Monday 23 Jul 2018
11:41 pm

hectorr

Add more common spelling errors to the 'documentation__check_typos' test case, collected from previous typo fixes in openacs.

Options
    • -1
    • +87
    ./tcl/test/doc-check-procs-common-typos.txt
7:52 pm

hectorr

Reduce test verbosity

Options
    • -2
    • +2
    ./tcl/test/doc-check-procs.tcl