• last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Add more common spelling errors to the 'documentation__check_typos' test case, collected from previous typo fixes in openacs.

    • -1
    • +87
    ./tcl/test/doc-check-procs-common-typos.txt
Reduce test verbosity

Add new test case 'documentation__check_typos', which checks for spelling errors in the proc documentation.

The test uses a file containing common spelling errors (doc-check-procs-common-typos.txt), based in the one

provided by Debian's lintian, which can be found here: https://github.com/Debian/lintian/tree/master/data/spelling

The test can take some time, depending on the amount of packages and how powerful the machine is.

    • -0
    • +4234
    ./tcl/test/doc-check-procs-common-typos.txt
prefer "aa_equals" over "aa_true"+"string equal"

    • -11
    • +11
    ./tcl/test/test-membership-rel-procs.tcl
  1. … 2 more files in changeset.
replace "expr" by "incr"

whitespace changes, added editor hints

    • -59
    • +59
    ./tcl/utilities-procs-aolserver.tcl
  1. … 1 more file in changeset.
add partial abckword compatibility for ns_getcontent for AOLserver

    • -5
    • +54
    ./tcl/utilities-procs-aolserver.tcl
Cache the portrait in the right cache (Thanks to Felix Mödritscher)

Translation of file descriptor must be binary as well when flushing in-memory payload to the spool file, or we would corrupt this content

util::http performance improvements:

- cache util::http::available as namespace variable, as in the worst case it would go to the db

- replace array idioms with dict idioms

Trim whitespace

fix typo

Fix typo

Replace array idioms with dict idioms

improve testcases by removing useless expr commands

    • -14
    • +14
    ./tcl/test/application-data-link-procs.tcl
    • -16
    • +16
    ./tcl/test/test-permissions-procs.tcl
Declass constraint names breaking the very strict OpenACS naming convention from errors to warnings

Rationale: it is sometimes impossible to have constraint names that are both < 30 chars and consistent with the naming scheme 'table_name'_'column_name'_'constraint_type' for all those defined on a particular table (see e.g. acs_named_objects).

Breaking this convention might be suboptimal, but is not harmful in itself.

flush per-request cache (fixes regression test properly)

simplify code

improve test cases: align comment with operations, remove useless "expr" commands

    • -25
    • +26
    ./tcl/test/acs-tcl-apm-procs.tcl
improve log message to be able to distinguish between multiple commands with different parameters

Make string_truncate behave as before (looking for spaces at end_position + 1) and therefore not breaking tests for ad_html_text_convert. Update docs so this property of being less or equal than len is clearly specified

Revert change... more investigation needed

Trim whitespace

node_id shoudl probably be parent_id (fixes automated tests)

Trim whitespace

    • -10
    • +10
    ./tcl/test/site-nodes-test-procs.tcl
Whitespace cleanup

    • -22
    • +22
    ./tcl/test/html-conversion-procs.tcl
Add '-equal' parameter to 'string_truncate', which allows to truncate a string to a length shorter or *equal* than a specified length.

The fact that 'string_truncate' was producing strings strictly shorter than the specified length, was making the behavior of 'ad_html_text_convert' inconsistent, and breaking automated tests.

This small addition fixes both the behavior and the tests, while retaining compatibility.

Add 'Markdown' tests for 'ad_html_text_convert'

    • -0
    • +14
    ./tcl/test/html-conversion-procs.tcl
- use information from acs_testing in api-browser: provide link for

test cases.

- new function: api_add_to_proc_doc for updating apidoc information

from other packages

- bump version of acs-automated testing to 5.10.0d4 and

acs-api-browser to 5.10.0d2

- toc includelet:

* new flag: "-renderer" (default "")

specify an explicit renderer. This is an alternative to the

classic "rendering by style", where there style determines the renderer.

* new flag: "-include_in_foldertree" (default true)

it is now possible to avoid inclusion of all folder-tree element

in the standard folder tree. Default set for backwards

compatibility.

  1. … 5 more files in changeset.
improve rowcount expressions

  1. … 74 more files in changeset.