• last updated 16 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix integration with old-style error handling

Exception handling reform (part 1)

- implement ad_try based on (byte-compiled) Tcl try to make exception

handling more Tcl compliant

- Replace several "catch" operations in request-processor by ad_try

- de-spaghetti "rp_handler" and factor out "rp_handle_request"

- Provide error context in log message in a more uniform way

- handle ds stub-procs in a more uniform way:

provide as well a stub for "ds_init" instead of

wrapping it into a "catch" operation.

- move deprecated procs "ad_return" and "rp_handle_adp_request"

from request-processor-procs to deprecated-utilities-procs.tcl

- bump version number of acs-tcl to 5.10.0d2

    • -1
    • +63
    ./tcl/deprecated-utilities-procs.tcl
    • -295
    • +263
    ./tcl/request-processor-procs.tcl
Make sure, the try command is available in your installation (requires Tcl 8.5 or newer)

Backport from HEAD

  1. … 2 more files in changeset.
Fix typo in debug line

Make behind_secure_proxy_p more robust against unexpected values in X-SSL-Request

Fix broken cvs-id

Improve scalability of site-node caches

Some sites have site-node caches with more than 200k site-node entries.

Wild card operations for flushing in these caches can take a while (2-digit ms),

locks on the site-node cache can lock everything. This change separates

the caches with wild-card operations from the parts not requiring these.

improving vor sample data the scalability at least by a factor of 4.

Reduce divergency between oracle and postgres codebase

    • -73
    • +0
    ./tcl/community-core-procs-oracle.xql
    • -73
    • +0
    ./tcl/community-core-procs-postgresql.xql
Reduce divergency between oracke and postgres codebase

    • -26
    • +1
    ./tcl/security-procs-postgresql.xql
Reduce divergency between oracle and postgres codebase

Add dcommented debug line

fix debug message

Removed incorrectly placed "--" between named parameter and its value

Bug fix: avoid confusion between command argument and option, when argument starts with "-"

  1. … 67 more files in changeset.
Bug fix: avoid confusion between text argument and option, when text starts with "-"

  1. … 35 more files in changeset.
Don't throw an error, when no url2file mapping exists

Remove usage of apm_package_version__version_name_greater in favor of apm_version_names_compare proc as their logics conflict

    • -11
    • +0
    ./tcl/apm-install-procs-postgresql.xql
Create utility to retrieve pdf information using poppler utils (https://poppler.freedesktop.org/)

This includes author, number of page, encription (yes/no), pdf version etc.

Fix typo (non-commented testing line)

Perform less aggressive cache flushing

Furthermore, allow ns_cache_flush in xo::clusterwide

  1. … 1 more file in changeset.
Bugfix ad_user_login

-expire flag for ad_set_signed_cookie (and therefore ad_set_cookie) was not specified by ad_user_login and set false per-default. This prevented parameters to set cookie expiration to have an effect, even when -max_age was correctly specified.

Now we set the -expire flag according to the -forever flag.

Bugfix

Decode form variables when a payload is transformed from form-urlencoded to multipart. Fix documentation for -formvars parameter

Bugfix

Avoid double encoding when content is in the same encoding as that of tcl interpreter

Fix nonsense fconfigure -translation $encoding

Try to make code clearer

Small improvement for portrait management (deletion)

Exploit existing on delete cascade constraints when we delete a portrait, instead of deleting stuff manually.

Also, put remaining logics into a proc and use it in acs_user::delete to address legit use case of people wanting

to remove a user permanently without removing portrait in advance.

  1. … 2 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

    • -13
    • +20
    ./catalog/acs-tcl.de_DE.ISO-8859-1.xml
    • -1
    • +10
    ./catalog/acs-tcl.en_US.ISO-8859-1.xml
    • -10
    • +14
    ./catalog/acs-tcl.es_ES.ISO-8859-1.xml
    • -2
    • +104
    ./catalog/acs-tcl.it_IT.ISO-8859-1.xml
    • -1
    • +7
    ./tcl/00-database-procs-postgresql.tcl
    • -456
    • +503
    ./tcl/00-database-procs.tcl
  1. … 7820 more files in changeset.
undo untested last minute check

    • -2
    • +8
    ./tcl/apm-install-procs-postgresql.xql
Fix typo

Flush cache also for ancestors of nodes when mounting a package

Unify version comparison logics so we always use apm_version_names_compare instead of other db api as apm_package_version__version_name_greater plus handcrafted queries which also might behave slightly differently

    • -8
    • +2
    ./tcl/apm-install-procs-postgresql.xql