OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 4
Total Committers: 73
Last Commit: 31 May
Commits this week: 4
Total Lines of Code (LoC): 68,337
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 24 Jul 2018
4:59 pm

hectorr

Remove apparent leftover + trailing whitespace

Options
    • -4
    • +3
    ./tcl/test/doc-check-procs.tcl
4:47 pm

hectorr

Add new test case 'files__page_contracts', which checks for the existance of both 'ad_page_contract' and 'ad_include_contract' in the .tcl files inside 'www' and 'lib' package directories.

There are cases, where includelets are not stored in 'lib' but 'www', or have 'ad_page_contract' instead of 'ad_include_contract'. Checking if the location of includelets is correct is not so clear, so we avoid doing this in this particular test.

Options
    • -1
    • +78
    ./tcl/test/file-test-procs.tcl
3:13 pm

gustafn

rework test case documentation__check_typos

- make test case more robust (don't abort tests when there is a proc_doc without a "main" section

- improve performance and sanity:

* move invariantes out of the loop

* use built-in hashes

* don't check the same term multiple times

... times went from >15 sec to <1sec

Options
    • -24
    • +39
    ./tcl/test/doc-check-procs.tcl
3:09 pm

gustafn

remove useless semicolon

Options
    • -2
    • +1
    ./tcl/test/acs-tcl-test-procs.tcl
2:28 pm

hectorr

Add new test case 'files__trailing_whitespace', which looks for trailing whitespace (spaces or tabs at the end of lines).

Currently, only .tcl files are checked.

Options
    • -2
    • +2
    ./tcl/test/doc-check-procs.tcl
    • -1
    • +57
    ./tcl/test/file-test-procs.tcl
10:35 am

gustafn

no reason for casting values to integer

Options
    • -2
    • +2
    ./tcl/test/acs-tcl-test-procs.tcl
10:14 am

antoniop

incr would return a decimal number, but test wants an integer to be returned. Restore expr and make clear that we want an integer out of it

Options
    • -2
    • +2
    ./tcl/test/acs-tcl-test-procs.tcl
10:10 am

antoniop

Streamline util_sets_equal_p (passes automated test)

Options
    • -15
    • +3
    ./tcl/utilities-procs.tcl
10:02 am

hectorr

Add more information about typos loaded and checks passed

Options
    • -2
    • +5
    ./tcl/test/doc-check-procs.tcl
12:50 am

hectorr

Fix typo + Whitespace changes

Options
    • -21
    • +15
    ./tcl/test/file-test-procs.tcl
12:27 am

hectorr

Test refactoring

Options
    • -9
    • +11
    ./tcl/test/doc-check-procs.tcl
12:05 am

hectorr

Improve test documentation.

Options
    • -4
    • +21
    ./tcl/test/doc-check-procs.tcl
Monday 23 Jul 2018
11:41 pm

hectorr

Add more common spelling errors to the 'documentation__check_typos' test case, collected from previous typo fixes in openacs.

Options
    • -1
    • +87
    ./tcl/test/doc-check-procs-common-typos.txt
7:52 pm

hectorr

Reduce test verbosity

Options
    • -2
    • +2
    ./tcl/test/doc-check-procs.tcl
7:50 pm

hectorr

Add new test case 'documentation__check_typos', which checks for spelling errors in the proc documentation.

The test uses a file containing common spelling errors (doc-check-procs-common-typos.txt), based in the one

provided by Debian's lintian, which can be found here: https://github.com/Debian/lintian/tree/master/data/spelling

The test can take some time, depending on the amount of packages and how powerful the machine is.

Options
    • -0
    • +4234
    ./tcl/test/doc-check-procs-common-typos.txt
    • -2
    • +48
    ./tcl/test/doc-check-procs.tcl
Sunday 22 Jul 2018
11:58 am

gustafn

prefer "aa_equals" over "aa_true"+"string equal"

Options
    • -1
    • +1
    ./tcl/test/html-conversion-procs.tcl
    • -3
    • +3
    ./tcl/test/navigation-procs.tcl
    • -11
    • +11
    ./tcl/test/test-membership-rel-procs.tcl
    • -2
    • +2
    ./tcl/test/test-set-cookie-procs.tcl
  5. … 2 more files in changeset.
10:26 am

gustafn

replace "expr" by "incr"

Options
    • -2
    • +2
    ./tcl/test/acs-tcl-test-procs.tcl
10:20 am

gustafn

whitespace changes, added editor hints

Options
    • -59
    • +59
    ./tcl/utilities-procs-aolserver.tcl
  2. … 1 more file in changeset.
10:06 am

gustafn

add partial abckword compatibility for ns_getcontent for AOLserver

Options
    • -5
    • +54
    ./tcl/utilities-procs-aolserver.tcl
Friday 20 Jul 2018
2:57 pm

antoniop

Cache the portrait in the right cache (Thanks to Felix Mödritscher)

Options
    • -2
    • +2
    ./tcl/community-core-procs.tcl
12:53 pm

antoniop

Translation of file descriptor must be binary as well when flushing in-memory payload to the spool file, or we would corrupt this content

Options
    • -0
    • +1
    ./tcl/http-client-procs.tcl
12:36 pm

antoniop

util::http performance improvements:

- cache util::http::available as namespace variable, as in the worst case it would go to the db

- replace array idioms with dict idioms

Options
    • -62
    • +69
    ./tcl/http-client-procs.tcl
11:27 am

antoniop

Trim whitespace

Options
    • -11
    • +11
    ./tcl/http-client-procs.tcl
Thursday 19 Jul 2018
4:01 pm

gustafn

fix typo

Options
    • -2
    • +2
    ./tcl/00-database-procs.tcl
3:36 pm

hectorr

Fix typo

Options
    • -1
    • +1
    ./tcl/test/acs-tcl-apm-procs.tcl
3:33 pm

antoniop

Replace array idioms with dict idioms

Options
    • -24
    • +20
    ./tcl/site-nodes-procs.tcl
1:43 pm

gustafn

improve testcases by removing useless expr commands

Options
    • -3
    • +3
    ./tcl/test/acs-tcl-test-procs.tcl
    • -7
    • +7
    ./tcl/test/ad-proc-test-procs.tcl
    • -14
    • +14
    ./tcl/test/application-data-link-procs.tcl
    • -3
    • +6
    ./tcl/test/doc-check-procs.tcl
    • -16
    • +16
    ./tcl/test/test-permissions-procs.tcl
    • -5
    • +5
    ./tcl/test/whos-online-procs.tcl
1:17 pm

antoniop

Declass constraint names breaking the very strict OpenACS naming convention from errors to warnings

Rationale: it is sometimes impossible to have constraint names that are both < 30 chars and consistent with the naming scheme 'table_name'_'column_name'_'constraint_type' for all those defined on a particular table (see e.g. acs_named_objects).

Breaking this convention might be suboptimal, but is not harmful in itself.

Options
    • -2
    • +2
    ./tcl/test/datamodel-test-procs.tcl
12:17 pm

gustafn

flush per-request cache (fixes regression test properly)

Options
    • -1
    • +6
    ./tcl/site-nodes-procs.tcl
12:16 pm

gustafn

simplify code

Options
    • -3
    • +2
    ./tcl/test/acs-tcl-apm-procs.tcl