OpenACS

openacs-4

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 10
Total Committers: 143
Last Commit: 31 May
Commits this week: 10
Total Lines of Code (LoC): 5,629,491
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 16 Apr 2019
9:00 am

hectorr

Whitespace changes

Options
    • -14
    • +14
    ./packages/acs-admin/www/apm/packages-install.tcl
8:57 am

hectorr

Do not assume a package is installed only if it has an entry in the 'apm_package_types' table. This fixes the issue of package upgrade prompting, in not installed packages, that still have an entry in 'apm_package_types'

Options
    • -2
    • +2
    ./packages/acs-admin/www/apm/packages-install.tcl
Monday 15 Apr 2019
9:58 pm

gustafn

use "ad_log" instead of "ns_log" in "obscure case"

Options
    • -2
    • +2
    ./packages/acs-tcl/tcl/request-processor-procs.tcl
7:30 pm

hectorr

Allow to undelete a message from acs-lang 'edit-localized-message', instead of showing the option to delete it whatever the state is

Options
    • -1
    • +6
    ./packages/acs-lang/www/admin/edit-localized-message.adp
    • -1
    • +9
    ./packages/acs-lang/www/admin/edit-localized-message.tcl
6:34 pm

hectorr

Refactor acs-lang 'admin/index' page, adding the new columns 'total' and 'deleted' to the listing, and reworking the query so it is faster (53ms -> 7ms), correct (number of messages by state are computed coherently with other acs-lang pages) and gives more information

Options
    • -2
    • +22
    ./packages/acs-lang/www/admin/index.adp
    • -53
    • +50
    ./packages/acs-lang/www/admin/index.tcl
    • -0
    • +62
    ./packages/acs-lang/www/admin/index.xql
6:34 pm

hectorr

file index.xql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./packages/acs-lang/www/admin/index.xql
3:35 pm

gustafn

improve spelling

Options
    • -1
    • +1
    ./packages/assessment/www/doc/data_collection.html
    • -1
    • +1
    ./packages/assessment/www/doc/requirements.html
    • -1
    • +1
    ./packages/assessment/www/doc/user_interface/user_experience.html
3:24 pm

gernst

Improve proc documentation

Options
    • -3
    • +3
    ./packages/file-storage/tcl/file-storage-procs.tcl
2:17 pm

hectorr

Refactor acs-lang 'message-list', using a single query for counting the different message states instead of one per state, and simplifying tcl logic

Options
    • -43
    • +15
    ./packages/acs-lang/www/admin/message-list.tcl
    • -16
    • +43
    ./packages/acs-lang/www/admin/message-list.xql
    • -0
    • +1
    ./packages/acs-lang/www/admin/package-list.xql
2:04 pm

antoniop

Fix xotcl-core cr-items test: modifying IP comes in fact from the cr_item's acs_object (it is also on the revision, but on the items seems to take into account e.g. proxying)

Options
    • -5
    • +4
    ./packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
11:46 am

antoniop

Fix 3 inconsistent log messages in the test

Options
    • -3
    • +3
    ./packages/xolp/tcl/test/xolp-test-procs.tcl
10:21 am

hectorr

Fix typo

Options
    • -1
    • +1
    ./packages/acs-kernel/acs-kernel.info
Friday 12 Apr 2019
11:29 pm

gustafn

improve spelling

Options
    • -1
    • +1
    ./packages/xowf/tcl/xowf-procs.tcl
    • -2
    • +2
    ./packages/xowiki-portlet/tcl/xowiki-admin-portlet-procs.tcl
    • -2
    • +2
    ./packages/xowiki-portlet/tcl/xowiki-portlet-procs.tcl
    • -2
    • +2
    ./packages/survey/www/process-response.tcl
    • -2
    • +2
    ./packages/survey/www/admin/process-response.tcl
    • -2
    • +2
    ./packages/oacs-dav/tcl/oacs-dav-procs.tcl
    • -1
    • +1
    ./packages/notifications/www/doc/index.adp
    • -4
    • +4
    ./packages/calendar-portlet/tcl/test/tclwebtest-procs.tcl
    • -2
    • +2
    ./packages/dotlrn/www/doc/permission-portals.adp
    • -1
    • +1
    ./packages/evaluation-portlet/tcl/test/evaluation-portlet-procs.tcl
    • -13
    • +13
    ./packages/evaluation-portlet/tcl/test/tclwebtest-procs.tcl
11:19 pm

gustafn

improve spelling

Options
    • -3
    • +3
    ./packages/acs-content-repository/tcl/content-type-procs.tcl
    • -1
    • +1
    ./packages/acs-content-repository/tcl/publish-procs.tcl
    • -2
    • +2
    ./packages/acs-lang/tcl/lang-catalog-procs.tcl
    • -1
    • +1
    ./packages/acs-core-docs/www/docbook-primer.adp
    • -1
    • +1
    ./packages/ajaxhelper/tcl/ajax-procs.tcl
    • -1
    • +1
    ./packages/ajaxhelper/tcl/ajax-yahoo-procs.tcl
    • -2
    • +2
    ./packages/ajaxhelper/www/doc/blank-master.tcl
    • -20
    • +20
    ./packages/ajaxhelper/www/doc/head-procs.tcl
    • -1
    • +1
    ./packages/assessment/lib/assessment.tcl
    • -1
    • +1
    ./packages/assessment/www/asm-admin/action-params.tcl
    • -1
    • +1
    ./packages/assessment/www/asm-admin/action-select.tcl
    • -1
    • +1
    ./packages/assessment/www/asm-admin/add-edit-check.tcl
    • -1
    • +1
    ./packages/assessment/www/asm-admin/checks-admin.tcl
    • -1
    • +1
    ./packages/assessment/www/asm-admin/section-select.tcl
    • -1
    • +1
    ./packages/assessment/www/asm-admin/swap-actions.tcl
  16. … 3 more files in changeset.
3:48 pm

hectorr

Rework acs-lang 'package-list' query 'packages_locale_status' query (89ms -> 4ms)

Options
    • -52
    • +27
    ./packages/acs-lang/www/admin/package-list.xql
2:49 pm

hectorr

Rework acs-lang 'package-list' query 'packages_locale_status_default' query (48ms -> 2ms)

Options
    • -28
    • +20
    ./packages/acs-lang/www/admin/package-list.xql
2:35 pm

antoniop

Prefer portable current_timestamp idiom to NOW()

Options
    • -2
    • +2
    ./packages/xolp/tcl/xolp-activity-procs.tcl
    • -3
    • +3
    ./packages/xolp/tcl/xolp-indicator-procs.tcl
2:17 pm

antoniop

Exploit existing acs::test::user::create api

Options
    • -20
    • +3
    ./packages/xolp/tcl/xolp-util-procs.tcl
2:09 pm

antoniop

Normalize indentation, add editor hints

Options
    • -39
    • +46
    ./packages/xolp/tcl/xolp-activity-procs.tcl
    • -14
    • +21
    ./packages/xolp/tcl/xolp-competency-procs.tcl
    • -0
    • +7
    ./packages/xolp/tcl/xolp-date-procs.tcl
    • -37
    • +44
    ./packages/xolp/tcl/xolp-evaluation-procs.tcl
    • -54
    • +61
    ./packages/xolp/tcl/xolp-indicator-procs.tcl
    • -10
    • +17
    ./packages/xolp/tcl/xolp-iri-procs.tcl
    • -0
    • +7
    ./packages/xolp/tcl/xolp-procs.tcl
    • -0
    • +7
    ./packages/xolp/tcl/xolp-time-procs.tcl
    • -31
    • +38
    ./packages/xolp/tcl/xolp-user-procs.tcl
    • -10
    • +17
    ./packages/xolp/tcl/xolp-util-procs.tcl
    • -859
    • +866
    ./packages/xolp/tcl/test/xolp-test-procs.tcl
1:48 pm

antoniop

Modernize XoTcl idioms

Options
    • -10
    • +10
    ./packages/xolp/tcl/xolp-activity-procs.tcl
    • -2
    • +2
    ./packages/xolp/tcl/xolp-competency-procs.tcl
    • -11
    • +9
    ./packages/xolp/tcl/xolp-evaluation-procs.tcl
    • -17
    • +17
    ./packages/xolp/tcl/xolp-indicator-procs.tcl
    • -12
    • +11
    ./packages/xolp/tcl/xolp-iri-procs.tcl
    • -3
    • +3
    ./packages/xolp/tcl/xolp-user-procs.tcl
1:27 pm

antoniop

Use xotcl-core indentation convention

Options
    • -95
    • +96
    ./packages/xolp/tcl/xolp-apm-procs.tcl
1:17 pm

antoniop

Whitespace cleanup, normalize indentation, add editor hints

Options
    • -94
    • +100
    ./packages/xolp/tcl/xolp-apm-procs.tcl
1:15 pm

antoniop

Use xotcl db idioms

Options
    • -4
    • +4
    ./packages/xolp/tcl/test/xolp-test-procs.tcl
1:09 pm

antoniop

Rollback tests or they will interfere with the others

Options
    • -0
    • +2
    ./packages/xolp/tcl/test/xolp-test-procs.tcl
11:37 am

antoniop

Reimplement query to obtain user competencies to fix xolp.user_get_competencies automated test

Personal perplexities:

- why do we specify the competency_set_id on the indicator facts? If one fact can be e.g. an exam, this might be related with multiple competency sets

- should we take into account also the validity of an activity?

Options
    • -14
    • +36
    ./packages/xolp/tcl/xolp-user-procs.tcl
Thursday 11 Apr 2019
8:36 pm

hectorr

Add deleted column to acs-lang 'package-list', and fixed number of messages depending on status, making it coherent with 'message-list'. Also fixed translated/untranslated count on default locale in 'message-list'. Version bump.

Options
    • -4
    • +4
    ./packages/acs-lang/acs-lang.info
    • -0
    • +1
    ./packages/acs-lang/catalog/acs-lang.en_US.ISO-8859-1.xml
    • -0
    • +1
    ./packages/acs-lang/catalog/acs-lang.es_ES.ISO-8859-1.xml
    • -5
    • +6
    ./packages/acs-lang/www/admin/message-list.tcl
    • -0
    • +1
    ./packages/acs-lang/www/admin/message-list.xql
    • -0
    • +6
    ./packages/acs-lang/www/admin/package-list.adp
    • -53
    • +32
    ./packages/acs-lang/www/admin/package-list.tcl
    • -0
    • +97
    ./packages/acs-lang/www/admin/package-list.xql
8:36 pm

hectorr

file package-list.xql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./packages/acs-lang/www/admin/package-list.xql
6:28 pm

antoniop

Port downstream commit cab327aeda04f1f1f6b8f2310ddc88c7c081a84f from Günter Ernst:

Minor adjustments to ensure install- and uninstallability

Options
    • -7
    • +17
    ./packages/xolp/tcl/xolp-apm-procs.tcl
    • -1
    • +1
    ./packages/xolp/tcl/xolp-competency-procs.tcl
    • -0
    • +1
    ./packages/xolp/tcl/xolp-indicator-procs.tcl
5:36 pm

antoniop

Port of downstream commit 9cbc3f04aad075e902e64d0c67d53158160a933c from Felix Möedritscher:

feature / issue #10359: added message keys, extended the xolp API - get_competencies, get_activities_of_package, update_title

Options
    • -2
    • +2
    ./packages/xolp/xolp.info
    • -0
    • +4
    ./packages/xolp/catalog/xolp.de_DE.ISO-8859-1.xml
    • -0
    • +4
    ./packages/xolp/catalog/xolp.en_US.ISO-8859-1.xml
    • -0
    • +22
    ./packages/xolp/tcl/xolp-activity-procs.tcl
    • -0
    • +12
    ./packages/xolp/tcl/xolp-competency-procs.tcl
4:53 pm

hectorr

Fix untranslated count and view on acs-lang 'message-list' + some refactoring

Options
    • -20
    • +24
    ./packages/acs-lang/www/admin/message-list.tcl
    • -1
    • +1
    ./packages/acs-lang/www/admin/message-list.xql