• last updated 16 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix integration with old-style error handling

Use plain tcl "try" instead of "ad_try"

Use "try" instead of "ad_try"

Exception handling reform (part 1)

- implement ad_try based on (byte-compiled) Tcl try to make exception

handling more Tcl compliant

- Replace several "catch" operations in request-processor by ad_try

- de-spaghetti "rp_handler" and factor out "rp_handle_request"

- Provide error context in log message in a more uniform way

- handle ds stub-procs in a more uniform way:

provide as well a stub for "ds_init" instead of

wrapping it into a "catch" operation.

- move deprecated procs "ad_return" and "rp_handle_adp_request"

from request-processor-procs to deprecated-utilities-procs.tcl

- bump version number of acs-tcl to 5.10.0d2

    • -2
    • +4
    ./packages/acs-tcl/tcl/ds-stub-procs.tcl
    • -36
    • +107
    ./packages/acs-tcl/tcl/exception-procs.tcl
    • -295
    • +263
    ./packages/acs-tcl/tcl/request-processor-procs.tcl
Make sure, the try command is available in your installation (requires Tcl 8.5 or newer)

    • -1
    • +11
    ./packages/acs-tcl/tcl/exception-procs.tcl
add missing ',' in select statement

    • -1
    • +1
    ./packages/news/www/admin/revision-add.xql
improve error handling in case read operation fails

    • -15
    • +33
    ./packages/xotcl-core/tcl/01-debug-procs.tcl
Initial version of ckeditor5 support for acs-templating

Note that this is an initial relase. several features of CKEditor5 are coming soon (easy imaging),

the whole ckeditor5 release is alpha. Some options of the ck4ditor integration

are copied over to ckeditor5, although there is no support yet.

Configuration:

In addition to the richttext widget properties,

https://openacs.org/api-doc/proc-view?proc=template::widget::richtext&source_p=1

the CKEditor 5 allows us to specify a editor class

Note: CKEditor 5 no longer comes with a configuration setting to change its height.

https://stackoverflow.com/questions/46559354/how-to-set-the-height-of-ckeditor-5-classic-editor/46559355#46559355

    • -0
    • +88
    ./packages/richtext-ckeditor5/lib/file-browser.adp
    • -0
    • +27
    ./packages/richtext-ckeditor5/lib/file-browser.tcl
    • -0
    • +246
    ./packages/richtext-ckeditor5/tcl/ckfinder-init.tcl
    • -0
    • +1
    ./packages/richtext-ckeditor5/tcl/richtext-init.tcl
add support for editors requiring a different HTML tag for richtext (e.g. div)

bump version number to 5.10.0d2

    • -9
    • +15
    ./packages/acs-templating/tcl/widget-procs.tcl
Improve robustness of code: make sure, file is always closed after open operation, even when "read" fails

    • -2
    • +6
    ./packages/xotcl-core/tcl/01-debug-procs.tcl
Backport from HEAD

    • -2
    • +2
    ./packages/acs-tcl/tcl/memoize-procs.tcl
    • -2
    • +2
    ./packages/acs-mail-lite/tcl/utils-procs.tcl
Fix typo in debug line

    • -2
    • +2
    ./packages/acs-tcl/tcl/memoize-procs.tcl
prefer literal in adp axpressions

    • -6
    • +6
    ./packages/acs-lang/www/admin/batch-editor.adp
    • -3
    • +3
    ./packages/acs-lang/www/admin/index.adp
prefer literal in tests

standardize boolean expressions in ADP files

    • -1
    • +1
    ./packages/acs-automated-testing/www/index.adp
Modernise code: strengthen page contract, use boolean test in ADP

Modernize code: get rid of deprecated cals in .xql file and use API rather than homebrew SQL calls

    • -5
    • +6
    ./packages/acs-admin/www/apm/cvs-status.tcl
    • -20
    • +0
    ./packages/acs-admin/www/apm/cvs-status.xql
Avoid small SQL queries for frequent operations, here for computing the full file path for a revision_id

    • -5
    • +10
    ./packages/xowiki/tcl/xowiki-procs.tcl
Bump verison number for apm

fix variable name

    • -2
    • +2
    ./packages/xowiki/tcl/xowiki-procs.tcl
Fix variable name

    • -2
    • +2
    ./packages/xowiki/tcl/xowiki-procs.tcl
Make behind_secure_proxy_p more robust against unexpected values in X-SSL-Request

Revert changes not meant to be committed

    • -6
    • +34
    ./packages/xowiki/tcl/xowiki-utility-procs.tcl
Fix typo

    • -35
    • +7
    ./packages/xowiki/tcl/xowiki-utility-procs.tcl
    • -2
    • +2
    ./packages/xowiki/tcl/xowiki-www-procs.tcl
Fix broken cvs-id

Reduce divergencies between oracle and postgres codebase, replace queries with proper api, exploit on delete cascade

    • -9
    • +3
    ./packages/bug-tracker/tcl/bug-procs.tcl
    • -14
    • +174
    ./packages/bug-tracker/tcl/bug-procs.xql
Specify default for max sort order (fixes but-tracker installation)

    • -1
    • +1
    ./packages/workflow/tcl/workflow-procs.xql
Reduce divergencies between oracle and postgres codebase

    • -38
    • +0
    ./packages/bug-tracker/www/patch-oracle.xql
    • -1
    • +33
    ./packages/bug-tracker/www/patch.xql
Reduce divergencies between oracle and postgres codebase

    • -10
    • +17
    ./packages/bug-tracker/www/admin/version-release.xql
Correct non-portable usage of limit idiom