• last updated 17 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Actually store the group name in the UI by intercepting the right form var

    • -2
    • +3
    ./packages/acs-subsite/www/admin/groups/new.tcl
Fix test test by considering that group pretty name is automatically localized

Don't quote some function defaults that are meant to be evaluated literally

New automated test doing the roundrtrip of group-type related API

Note that this is currently failing due to a bug in package_instantiate_object, which triggered the creation of this test.

Move logics to delete a group type into the API

Fix quoting of group type

Remove unneeded variable

    • -7
    • +1
    ./packages/acs-subsite/tcl/subsite-procs.tcl
Add (trivial) ad_include_contract

    • -1
    • +5
    ./packages/acs-subsite/lib/subsites.tcl
Avoid unnecessary computations

    • -1
    • +0
    ./packages/acs-subsite/lib/subsites-oracle.xql
    • -9
    • +10
    ./packages/acs-subsite/lib/subsites.tcl
add index for bulk mail sweeper. was already #10 on sequential reads on learn

Reduce divergency between oracle and postgres codebase and bring portable sql inline

Reuse return url over subsites, remove dummy sql

    • -2
    • +3
    ./packages/acs-subsite/lib/subsites.tcl
Use best practice list idiom

    • -1
    • +1
    ./packages/acs-subsite/lib/subsites.tcl
Avoid useless check

    • -2
    • +1
    ./packages/acs-subsite/lib/subsites.tcl
Proc "util_get_subset_missing": make sure to return the found elements.

Added test case for this proc.

    • -2
    • +2
    ./packages/acs-tcl/tcl/utilities-procs.tcl
    • -5
    • +13
    ./packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
allow passing of pretty_names that contain content including less and greater sign

    • -2
    • +2
    ./packages/notifications/www/request-new.tcl
fix overquoting in notification-widget

    • -1
    • +1
    ./packages/forums/www/message-view.adp
    • -1
    • +1
    ./packages/fs-portlet/www/fs-portlet.adp
Localize file-size limits in the UI

    • -4
    • +5
    ./packages/file-storage/www/file-add.tcl
Introduce a client-side check for the maximum file size, inform user of current limit and improve file-size related localization

    • -2
    • +20
    ./packages/file-storage/www/file-add.tcl
Prettify code

    • -10
    • +20
    ./packages/file-storage/www/file-add.tcl
Make 'util_user_message' quote the message when the parameter 'html_p' is false, not otherwise, restoring pre-refactoring behavior and making it coherent with the parameter doc

    • -2
    • +2
    ./packages/acs-tcl/tcl/utilities-procs.tcl
Remove obsolete xql files

    • -25
    • +0
    ./packages/file-storage/www/version-delete.xql
improve log messages

    • -5
    • +5
    ./packages/xotcl-core/tcl/03-doc-procs.tcl
Simplify code and exploit parameter contract (we know flags are boolean)

    • -17
    • +10
    ./packages/acs-tcl/tcl/utilities-procs.tcl
Bugfixes et al:

- don't throw a server error if one clicks submit on the empty form without specifying a file

- allow to upload the same zipfile multiple times without throwing an error

- streamline idioms

    • -48
    • +26
    ./packages/file-storage/www/file-add.tcl
Whitespace changes

Add @see and fix typo in proc doc

Fix typo in proc doc

    • -3
    • +3
    ./packages/acs-lang/tcl/localization-procs.tcl
Repeat this block of code here as well, as vars in the checks are not kept in the script body

    • -1
    • +8
    ./packages/attachments/www/file-add-2.tcl
Fix typos in proc doc