Activity OpenACS/openacs-4

Tree
Accordion

Stats

Commits this week: 5

Total Committers:	144
Last Commit:	13 Sep
Commits this week:	5
Total Lines of Code (LoC):	6,319,984
Net change in LoC this week:	47,821

Commit Activity

last updated 11 hours ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

End Date:

Thursday 14 Jan 2021

3:40 pm

antoniop

Do not improperly rely on apm_version_names_compare to check for NaviServer version number, use a more reliable capability check instead

- -0
- +4
./packages/acs-tcl/tcl/00-icanuse-procs.tcl
- History
- Source
- Diff
./packages/acs-tcl/.../00-icanuse-procs.tcl
- -9
- +1
./packages/acs-tcl/tcl/http-client-procs.tcl
- History
- Source
- Diff
./packages/acs-tcl/.../http-client-procs.tcl

3:32 pm

antoniop

Change the regexp so that we catch multiple kinds of error pattern indicating the subcommand does not exist: NaviServer and Tcl return sligthly different error messages

- -1
- +1
./packages/acs-tcl/tcl/00-icanuse-procs.tcl
- History
- Source
- Diff
./packages/acs-tcl/.../00-icanuse-procs.tcl

3:30 pm

antoniop

Extend test to expose that we need a better idiom to detect also NaviServer commands

- -0
- +14
./packages/acs-tcl/tcl/test/00-icanuse-procs.tcl
- History
- Source
- Diff
./packages/acs-tcl/.../00-icanuse-procs.tcl

3:17 pm

antoniop

Use a different idiom to detect if a command supports a subcommand, fixing acs-tcl.acs__command_has_subcommand automated test

- -2
- +8
./packages/acs-tcl/tcl/00-icanuse-procs.tcl
- History
- Source
- Diff
./packages/acs-tcl/.../00-icanuse-procs.tcl

3:16 pm

antoniop

Fix wording

- -2
- +2
./packages/acs-tcl/tcl/test/00-icanuse-procs.tcl
- History
- Source
- Diff
./packages/acs-tcl/.../00-icanuse-procs.tcl

3:09 pm

antoniop

New test for acs::cmd_has_subcommand exposing how flags at the beginning and end of the error message are not properly recognized

- -0
- +49
./packages/acs-tcl/tcl/test/00-icanuse-procs.tcl
- History
- Source
- Diff
./packages/acs-tcl/.../00-icanuse-procs.tcl

3:09 pm

antoniop

More
MAIN:antoniop:20210114140903
deleted 1 file
MAIN

file 00-icanuse-procs.tcl was initially added on branch oacs-5-10.

- -0
- +0
./packages/acs-tcl/tcl/test/00-icanuse-procs.tcl
- History
- Source
./packages/acs-tcl/.../test/00-icanuse-procs.tcl

Wednesday 13 Jan 2021

7:19 pm

gustafn

ensure, that the minimal set of controls is provided, also, when there are hidden form fields

- -6
- +7
./packages/xowiki/tcl/includelet-procs.tcl
- History
- Source
- Diff
./packages/xowiki/tcl/includelet-procs.tcl

7:18 pm

gustafn

improve spelling

- -3
- +4
./packages/xowiki/tcl/form-field-procs.tcl
- History
- Source
- Diff
./packages/xowiki/tcl/form-field-procs.tcl

7:00 pm

gustafn

since the form-field "file" supports the file multiple attribute, the internal representation is as well a list.

this change takes now as file-name for the local renderer as well the first file name list element.

- -5
- +7
./packages/xowf/tcl/test-item-procs.tcl
- History
- Source
- Diff
./packages/xowf/tcl/test-item-procs.tcl

2:39 pm

trenner

add the original filename to the generated url, so that it is also delivered to the user

- -1
- +1
./packages/xowf/tcl/test-item-procs.tcl
- History
- Source
- Diff
./packages/xowf/tcl/test-item-procs.tcl

2:16 pm

antoniop

Keep supporting the previous proc signature, throwing a warning

- -0
- +5
./packages/acs-tcl/tcl/http-client-procs.tcl
- History
- Source
- Diff
./packages/acs-tcl/.../http-client-procs.tcl

2:10 pm

antoniop

util::http should provide enough fallback via curl already without targeting specific Naviserver versions, use other fallbacks only when no implementation is available

- -23
- +2
./packages/acs-tcl/tcl/apm-file-procs.tcl
- History
- Source
- Diff
./packages/acs-tcl/tcl/apm-file-procs.tcl
- -2
- +1
./packages/acs-tcl/tcl/http-client-procs.tcl
- History
- Source
- Diff
./packages/acs-tcl/.../http-client-procs.tcl

1:39 pm

hectorr

Fix webserver version check using 'apm_version_names_compare' for rc versions.

Between 4.99.6 and 4.99.20rc1, for example, 'apm_version_names_compare' will consider the latter to be the lowest.

As this is not the expected behavior for webserver version check, this patch just removes the rc part of the version before comparing in the few cases where this is done, and should be removed if the behavior changes in the future.

- -2
- +7
./packages/acs-tcl/tcl/apm-file-procs.tcl
- History
- Source
- Diff
./packages/acs-tcl/tcl/apm-file-procs.tcl
- -1
- +4
./packages/acs-tcl/tcl/http-client-procs.tcl
- History
- Source
- Diff
./packages/acs-tcl/.../http-client-procs.tcl

12:25 pm

antoniop

Fix version check

- -1
- +1
./packages/acs-tcl/tcl/http-client-procs.tcl
- History
- Source
- Diff
./packages/acs-tcl/.../http-client-procs.tcl

12:00 pm

antoniop

Tear down a lot of boilerplate used to support native HTTP api on Naviserver versions < 4.99.15, which will now fallback to curl

- -245
- +40
./packages/acs-tcl/tcl/http-client-procs.tcl
- History
- Source
- Diff
./packages/acs-tcl/.../http-client-procs.tcl
- -3
- +1
./packages/acs-tcl/tcl/test/http-client-procs.tcl
- History
- Source
- Diff
./packages/acs-tcl/.../http-client-procs.tcl

11:09 am

antoniop

Doc formatting changes

- -330
- +406
./packages/acs-tcl/tcl/http-client-procs.tcl
- History
- Source
- Diff
./packages/acs-tcl/.../http-client-procs.tcl

10:44 am

antoniop

Avoid markup in documentation

- -72
- +69
./packages/acs-tcl/tcl/http-client-procs.tcl
- History
- Source
- Diff
./packages/acs-tcl/.../http-client-procs.tcl

10:37 am

antoniop

Reduce people expectations

- -1
- +2
./packages/acs-tcl/tcl/http-client-procs.tcl
- History
- Source
- Diff
./packages/acs-tcl/.../http-client-procs.tcl

Tuesday 12 Jan 2021

6:36 pm

antoniop

Fix acs-tcl.logout_from_everywhere test case and support again invalidating of all existing user logins, useful e.g. to make sure no device still holds a valid login when we change our password on a device

- -15
- +24
./packages/acs-tcl/tcl/security-procs.tcl
- History
- Source
- Diff
./packages/acs-tcl/tcl/security-procs.tcl

6:32 pm

antoniop

Test the use case supposedly supported by sec_change_user_auth_token: invalidate all existing login cookies (e.g. when the users change their password) so that all devices need to log in again

the test exposes a long standing regression (~17 years) where this was broken in order to support persistent login. See e.g. https://openacs.org/forums/message-view?message_id=1691183#msg_1691183