• last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Chat Redesign: cleanup of obsolete parameters ('AppletHeight','AppletWidth','DefaultClient','ServerHost','ServerPort').

file chat-common.js was added on branch oacs-5-10 on 2019-02-25 15:35:44 +0000

    • -0
    • +0
    ./packages/xowiki/www/resources/chat-common.js
Chat Redesign:

+ Skin support.

+ New 'ChatSkin' instance parameter, with currently two possible values: 'classic' and 'bubbles'.

+ Skins are located in the new packages/xowiki/www/resources/chat-skins/ directory.

+ New 'bubbles' skin, default for the chat package.

+ Old skin renamed to 'classic', default for the xowiki includelet.

+ New skins can be created by just adding the css and js files in the skins directory, and naming them accordingly. For example, being '$skin' the name of the new skin, the files should be named chat-$skin-common.js and chat-$skin.css.

+ New '-skin' parameter to the Chat login proc, containing the name of the skin (i.e. 'classic' or 'bubbles').

+ Bump version number.

    • -2
    • +3
    ./packages/chat/tcl/chat-ajax-procs.tcl
    • -211
    • +0
    ./packages/xowiki/www/resources/chat-common.js
    • -251
    • +0
    ./packages/xowiki/www/resources/chat.css
    • -0
    • +371
    ./packages/xowiki/www/resources/chat-skins/chat-bubbles.css
    • -0
    • +251
    ./packages/xowiki/www/resources/chat-skins/chat-classic.css
File storage max upload limit reform:

the max upload limit will now default to empty. Rationale: this value is

one that ages quickly with respect to new storage requirements, and is

currently set to something incompatible with the vanilla Naviserver configuration

(500MB fs vs 20MB ns).

The upgrade script will make so that instances setting this parameter

higher than the server upload limit configuration will be

set empty as well (this would never have an effect, as server

will prevent the upload altogheter anyway).

Max upload limit in bytes is now retrieved from a proc implementing

this fallback to server configuration logics. Other than centralizing,

its purpose is to be used in client-side code checks in the future

so we could prevent a doomed upload in advance.

    • -2
    • +2
    ./packages/attachments/www/file-add-2.tcl
    • -3
    • +3
    ./packages/file-storage/file-storage.info
    • -2
    • +2
    ./packages/file-storage/www/file-add.tcl
    • -2
    • +2
    ./packages/file-storage/www/folder-zip-add.tcl
Refer to the parameter in the file-storage instance instead than on a local one to decide the maximum upload size and deprecate the one here

Rationale: makes little sense that we set and maintain separate limits referring to the same file-storage instance

    • -3
    • +3
    ./packages/attachments/attachments.info
    • -9
    • +8
    ./packages/attachments/www/file-add-2.tcl
Remove trivial default, already set by the api

    • -9
    • +1
    ./packages/attachments/www/file-add-2.tcl
Whitespace removal

    • -3
    • +3
    ./packages/attachments/www/file-add-2.tcl
Remove obsolete queries and bring remaining one inline

    • -2
    • +6
    ./packages/attachments/www/file-add-2.tcl
    • -24
    • +0
    ./packages/attachments/www/file-add-2.xql
Speed up referential integrity by avoiding sequential scans

Whitespace changes

    • -27
    • +27
    ./packages/acs-tcl/tcl/acs-kernel-procs.tcl
Fix typo in proc doc

    • -2
    • +2
    ./packages/acs-tcl/tcl/acs-kernel-procs.tcl
Whitespace changes

    • -62
    • +60
    ./packages/acs-tcl/tcl/document-procs.tcl
Fix typo in proc doc

    • -2
    • +2
    ./packages/acs-tcl/tcl/document-procs.tcl
Whitespace changes

    • -84
    • +84
    ./packages/acs-tcl/tcl/util-diff-procs.tcl
Remove duplicated comments

    • -2
    • +0
    ./packages/acs-tcl/tcl/util-diff-procs.tcl
Whitespace changes

    • -12
    • +18
    ./packages/acs-tcl/lib/check-installed.tcl
Add missing parameter to include doc

    • -0
    • +1
    ./packages/acs-tcl/lib/check-installed.tcl
fix documentation bug #3369

    • -1
    • +1
    ./packages/acs-core-docs/www/templates.adp
    • -2
    • +2
    ./packages/acs-core-docs/www/templates.html
Add ad_include_contract and documentation to this page

    • -0
    • +10
    ./packages/file-storage/lib/folder-admin.tcl
Use ad_include_contract on this page

Replace custom arg checks with proper ad_include_contract

    • -42
    • +25
    ./packages/acs-tcl/lib/static-progress-bar.tcl
Fix doc

Add @see in deprecated proc

Add some @see in deprecated procs

    • -2
    • +11
    ./packages/acs-tcl/tcl/deprecated-procs.tcl
Fix contract doc

    • -1
    • +1
    ./packages/chat/lib/transcript-view.tcl
Use ad_include_contract and revise current usages (e.g. write_p was not used anywhere)

    • -0
    • +6
    ./packages/chat/lib/transcript-view.tcl
    • -3
    • +3
    ./packages/chat/www/chat-transcript.adp
Use ad_include_contract on this page

Bring all sql inline

    • -13
    • +0
    ./packages/chat/lib/transcripts.xql
Replace silent catch idiom

    • -1
    • +2
    ./packages/chat/lib/current-messages.tcl
Use ad_include_contract

    • -0
    • +5
    ./packages/chat/lib/current-messages.tcl