• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
add log warnings when include-contract is violated, since (in most cases) the passed values should be pre-checked

    • -4
    • +13
    ./acs-tcl/tcl/tcl-documentation-procs.tcl
improve documentation

Change value-checker form "html" to "allhtml", otherwise already saved news articles containing data urls can't be viewed

Port of downstream hotfix from Gustaf Neumann

Port of downstream modification: apply trimming of zeros to all fields in advance

This allows to treat fields as real numbers without the need to trim case by case. One can also reduce dependency to api and just use plain tcl expressions to evaluate conditions

    • -18
    • +19
    ./acs-templating/tcl/date-procs.tcl
Improve doc, remove needless properties

    • -2
    • +1
    ./proctoring-support/lib/proctoring-configure.tcl
file proctoring-configure.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./proctoring-support/lib/proctoring-configure.tcl
UI include to configure proctoring on an arbitrary ACS object, meant to be integrated downstream into custom UIs

    • -2
    • +3
    ./proctoring-support/proctoring-support.info
    • -0
    • +3
    ./proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml
    • -0
    • +3
    ./proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml
    • -0
    • +1
    ./proctoring-support/lib/proctoring-configure.adp
    • -0
    • +79
    ./proctoring-support/lib/proctoring-configure.tcl
file proctoring-configure.adp was initially added on branch oacs-5-10.

    • -0
    • +0
    ./proctoring-support/lib/proctoring-configure.adp
Port of downstream HTML5 date and time form widgets by Günter Ernst

These widgets provide a better and more consistent user experience and client-side validation across multiple platforms. They should in time become the preferred alternative for dates and time for template forms.

    • -0
    • +6
    ./acs-templating/catalog/acs-templating.en_US.ISO-8859-1.xml
    • -1
    • +329
    ./acs-templating/tcl/date-procs.tcl
Comment noop result of a 18 years old typo, add remarks

    • -9
    • +15
    ./acs-templating/tcl/date-procs.tcl
Arrays might or not have been a better choice for the date object, however, such decision happened very long ago and it has worked good enough... cleanup concerning remarks

Whitespace change

Review concerning remark: the algotirhm is indeed correct, assuming the year is expressed in the Gregorian calendar

    • -3
    • +12
    ./acs-templating/tcl/date-procs.tcl
Replace deprecated idiom

Uniform documentation formatting and indentation, add missing documentation

    • -775
    • +911
    ./acs-templating/tcl/date-procs.tcl
For Postgres, take advantage of exclusive database api to check for permissions more efficiently, improve doc

    • -13
    • +41
    ./xotcl-core/tcl/06-package-procs.tcl
Notification request cleanup refactoring

One of the most expensive operations in large site is the cleanup for

notification_requests in situations, where the user has lost

permissions on an object, on which the user wanted to receive

notifications. This check was performed previously in

notification::sweep::cleanup_notifications via a permission check over

all notification requests, which can be very costly on large

sites. This change moves this cleanup into the actual notification

sending, where the permissions have to be sent anyhow.

    • -18
    • +54
    ./notifications/tcl/sweep-procs.tcl
Fix typo

    • -2
    • +2
    ./acs-templating/www/doc/no-quote-upgrade.adp
    • -1
    • +1
    ./acs-templating/www/doc/no-quote-upgrade.html
Fix expression to the original intention: check if ns_conn url ends by ad_conn extra_url

    • -4
    • +5
    ./acs-tcl/tcl/request-processor-procs.tcl
more cleanup for setting of potentially unencoded return_url

minor cleanup for returnurls

    • -2
    • +2
    ./xotcl-request-monitor/www/flush-url-statistics.tcl
don't hard-code "Learner" as role

streamline returnredirect commands

make sure, the provided URL is always properly encoded

Fix typo in datamodel creation, make it atomic

ad_return_url: experimental change to produce per default a proper encoded result

Background: before this change, ad_return_url encoded always the query

variables but not the URL path. This mixed result is complex to handle

to achieve ex-post a proper encoding. The function has a flag

"-urlencode", which is nowhere used in OpenACS. Other functions like

e.g. export_vars, or pretty_link return per default as well the

encoded URL. "ad_return_url" has a new flag "-path_encode=false" to

obtain the previous behavior (similar to the other mentioned

functions).

break overlong lines and improve comments

    • -75
    • +107
    ./acs-tcl/tcl/utilities-procs.tcl
bugfix: don't call get_non_empty_file_formfields in render_answers when in export mode

improve spelling

provide a compatibility function for ns_parsehostport for earlier versions of NaviServer

make spelling more consistent

    • -6
    • +6
    ./acs-automated-testing/tcl/aa-test-procs.tcl