• last updated 17 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
remove misleading comment. there should be no re-init

    • -12
    • +5
    ./acs-tcl/tcl/request-processor-init.tcl
search the form also in the site_wide_pages

Disable any conversion on the _name property (:name Page instance variable): this property is special and receives already its necessary conversion at validation time, happening before conversion time and should not be overridden

Implement 'language_specific' formfields and 'localized' FormPage properties:

- properties can be stored and retrieved specifying a -localized flag: this flag will make transparently store and retrieve the property value from a custom message key created in the acs-translations package referencing the FormPage. This localization mechanism is additional to that of language-prefixed pages and can address the need of multi-language content for non-prefixable objects such as folders

- via specifying language_specific in the formfield spec, one can enable this new localization mechanism when interacting with the FormPage via a xowiki::Form

TODO: handle export/import of pages (e.g. serializing available translation and generate the new message keys for the imported page), add some nicer UI to make the user aware of e.g. current translation context

    • -20
    • +31
    ./xowiki/tcl/form-field-procs.tcl
Reduce the threshold for images to be considered black:

in the wild it has happened that borderline-legitimate pictures of 7kbytes have triggered the check.

    • -1
    • +1
    ./proctoring-support/lib/proctored-page.adp
Fix missing column in sql statement

prefer db_0or1row +"where exists" over db_string + "select case"

    • -12
    • +14
    ./acs-authentication/tcl/authentication-procs.tcl
    • -8
    • +10
    ./dotlrn/tcl/test/community-procs.tcl
    • -10
    • +10
    ./new-portal/tcl/portal-procs.tcl
send also HEAD requests to the request monitor

    • -0
    • +2
    ./xotcl-request-monitor/tcl/throttle_mod-init.tcl
reduce usage of idiom "select 1 from dual where exists" when not necessary

some packages have high number of instances: no need to aggregate over these

Pass missing object_id flag

Do not insert object_ids that do not exist in acs_object (leftover group message keys)

Replace limit with portable idiom

prefer ad_try, since it is silent, when action is ended by a script_abort

Fix oracle query as for most recent version limit is not supported

Go straight to the database with a portable query

Improve sql portability, reduce number of statements

    • -16
    • +12
    ./news-aggregator/tcl/subscription-procs.tcl
Improve sql portability

    • -9
    • +11
    ./acs-service-contract/tcl/acs-service-contract-procs.tcl
    • -6
    • +10
    ./acs-subsite/tcl/group-type-procs.tcl
    • -12
    • +15
    ./acs-subsite/tcl/test/acs-subsite-procs.tcl
Cleanup leftover query

    • -6
    • +1
    ./acs-content-repository/tcl/content-revision-procs.xql
Whitespace cleanup

Improve sql portability

    • -22
    • +22
    ./acs-lang/tcl/test/acs-lang-localization-procs.tcl
    • -2
    • +4
    ./forums/www/admin/subscribe-others-2.tcl
Fix missing end

    • -2
    • +2
    ./acs-content-repository/tcl/test/content-extlink-procs.tcl
    • -2
    • +2
    ./dotlrn/tcl/dotlrn-security-procs.tcl
Im prove sql portability

Improve sql portability

    • -11
    • +11
    ./acs-content-repository/tcl/test/content-extlink-procs.tcl
    • -4
    • +4
    ./dotlrn/tcl/dotlrn-security-procs.tcl
Improve sql portability: oracle cannot select a boolean directly using exists

    • -3
    • +4
    ./acs-authentication/tcl/authentication-procs.tcl
Whitespace cleanup

    • -2
    • +2
    ./news-aggregator-portlet/www/news-aggregator-portlet.tcl
Make sql portable

    • -1
    • +5
    ./news-aggregator-portlet/www/news-aggregator-portlet.tcl
Improve sql portability

    • -4
    • +7
    ./forums/www/admin/subscribe-others-2.tcl
Replace limit idiom with portable idiom

    • -8
    • +0
    ./assessment/tcl/as-apm-action-procs-oracle.xql
    • -10
    • +0
    ./assessment/tcl/as-apm-action-procs-postgresql.xql
    • -1
    • +5
    ./assessment/tcl/as-apm-action-procs.tcl
Avoid the not portable limit idiom, just kill the recursive part using the flag instead

...although one should point out that Oracle does not support the boolean type...