• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[PostgreSQL 11] Change 'with (iscachable)' to IMMUTABLE for PG11

[PostgreSQL 11] Change 'with (iscachable)' to IMMUTABLE for PG11

    • -1
    • +1
    ./acs-kernel/sql/postgresql/postgresql.sql
backport from oacs-5-9, which might avoid problems with oacs 5-8 when used with recent versions of nsf

fix typo

perform javascript escaping with more regular semantics

    • -4
    • +11
    ./acs-tcl/tcl/test/text-html-procs.tcl
Introduce new ad_js_escape with the purpose of sanitizing tcl strings used inside javascript code from escape sequences and from quotes in particular and provide some test cases

TODO: consider its usage into templates when e.g. we are putting a URL into javascript functions such as acs_ListBulkActionClick. URLs might in fact contain single and double quotes.

    • -0
    • +19
    ./acs-tcl/tcl/test/text-html-procs.tcl
Provide some basic way to create subgroups via the UI

    • -2
    • +3
    ./acs-subsite/www/admin/groups/one.adp
    • -2
    • +7
    ./acs-subsite/www/admin/groups/one.tcl
Actually store the group name in the UI by intercepting the right form var

    • -2
    • +3
    ./acs-subsite/www/admin/groups/new.tcl
Fix test test by considering that group pretty name is automatically localized

    • -3
    • +10
    ./acs-subsite/tcl/test/acs-subsite-procs.tcl
Don't quote some function defaults that are meant to be evaluated literally

    • -7
    • +17
    ./acs-subsite/tcl/plpgsql-utility-procs.tcl
New automated test doing the roundrtrip of group-type related API

Note that this is currently failing due to a bug in package_instantiate_object, which triggered the creation of this test.

    • -1
    • +53
    ./acs-subsite/tcl/test/acs-subsite-procs.tcl
Move logics to delete a group type into the API

    • -1
    • +34
    ./acs-subsite/tcl/group-type-procs-oracle.xql
    • -1
    • +31
    ./acs-subsite/tcl/group-type-procs-postgresql.xql
    • -1
    • +71
    ./acs-subsite/tcl/group-type-procs.tcl
    • -62
    • +6
    ./acs-subsite/www/admin/group-types/delete-2.tcl
    • -14
    • +0
    ./acs-subsite/www/admin/group-types/delete-2.xql
Fix quoting of group type

Remove unneeded variable

Add (trivial) ad_include_contract

Avoid unnecessary computations

    • -1
    • +0
    ./acs-subsite/lib/subsites-postgresql.xql
add index for bulk mail sweeper. was already #10 on sequential reads on learn

    • -0
    • +4
    ./bulk-mail/sql/oracle/upgrade/upgrade-2.10.0d0-2.10.0d1.sql
Reduce divergency between oracle and postgres codebase and bring portable sql inline

    • -39
    • +0
    ./acs-subsite/tcl/application-group-procs-oracle.xql
    • -41
    • +0
    ./acs-subsite/tcl/application-group-procs-postgresql.xql
    • -6
    • +39
    ./acs-subsite/tcl/application-group-procs.tcl
    • -33
    • +0
    ./acs-subsite/tcl/application-group-procs.xql
Reuse return url over subsites, remove dummy sql

Use best practice list idiom

Avoid useless check

Proc "util_get_subset_missing": make sure to return the found elements.

Added test case for this proc.

    • -5
    • +13
    ./acs-tcl/tcl/test/acs-tcl-test-procs.tcl
allow passing of pretty_names that contain content including less and greater sign

    • -1
    • +1
    ./notifications/lib/notification-widget.tcl
fix overquoting in notification-widget

    • -1
    • +1
    ./fs-portlet/www/fs-contents-portlet.adp
Localize file-size limits in the UI

Introduce a client-side check for the maximum file size, inform user of current limit and improve file-size related localization

Prettify code

Make 'util_user_message' quote the message when the parameter 'html_p' is false, not otherwise, restoring pre-refactoring behavior and making it coherent with the parameter doc

Remove obsolete xql files

    • -31
    • +0
    ./file-storage/www/version-delete-oracle.xql
    • -26
    • +0
    ./file-storage/www/version-delete-postgresql.xql
    • -25
    • +0
    ./file-storage/www/version-delete.xql
improve log messages

    • -5
    • +5
    ./acs-api-browser/tcl/acs-api-documentation-procs.tcl