• last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Move logics to delete a group type into the API

    • -1
    • +34
    ./acs-subsite/tcl/group-type-procs-oracle.xql
    • -1
    • +31
    ./acs-subsite/tcl/group-type-procs-postgresql.xql
    • -1
    • +71
    ./acs-subsite/tcl/group-type-procs.tcl
    • -62
    • +6
    ./acs-subsite/www/admin/group-types/delete-2.tcl
    • -14
    • +0
    ./acs-subsite/www/admin/group-types/delete-2.xql
Fix quoting of group type

Remove unneeded variable

Add (trivial) ad_include_contract

Avoid unnecessary computations

    • -1
    • +0
    ./acs-subsite/lib/subsites-postgresql.xql
add index for bulk mail sweeper. was already #10 on sequential reads on learn

    • -0
    • +4
    ./bulk-mail/sql/oracle/upgrade/upgrade-2.10.0d0-2.10.0d1.sql
Reduce divergency between oracle and postgres codebase and bring portable sql inline

    • -39
    • +0
    ./acs-subsite/tcl/application-group-procs-oracle.xql
    • -41
    • +0
    ./acs-subsite/tcl/application-group-procs-postgresql.xql
    • -6
    • +39
    ./acs-subsite/tcl/application-group-procs.tcl
    • -33
    • +0
    ./acs-subsite/tcl/application-group-procs.xql
Reuse return url over subsites, remove dummy sql

Use best practice list idiom

Avoid useless check

Proc "util_get_subset_missing": make sure to return the found elements.

Added test case for this proc.

    • -5
    • +13
    ./acs-tcl/tcl/test/acs-tcl-test-procs.tcl
allow passing of pretty_names that contain content including less and greater sign

    • -1
    • +1
    ./notifications/lib/notification-widget.tcl
fix overquoting in notification-widget

    • -1
    • +1
    ./fs-portlet/www/fs-contents-portlet.adp
Localize file-size limits in the UI

Introduce a client-side check for the maximum file size, inform user of current limit and improve file-size related localization

Prettify code

Make 'util_user_message' quote the message when the parameter 'html_p' is false, not otherwise, restoring pre-refactoring behavior and making it coherent with the parameter doc

Remove obsolete xql files

    • -31
    • +0
    ./file-storage/www/version-delete-oracle.xql
    • -26
    • +0
    ./file-storage/www/version-delete-postgresql.xql
    • -25
    • +0
    ./file-storage/www/version-delete.xql
improve log messages

    • -5
    • +5
    ./acs-api-browser/tcl/acs-api-documentation-procs.tcl
Simplify code and exploit parameter contract (we know flags are boolean)

    • -17
    • +10
    ./acs-tcl/tcl/utilities-procs.tcl
Bugfixes et al:

- don't throw a server error if one clicks submit on the empty form without specifying a file

- allow to upload the same zipfile multiple times without throwing an error

- streamline idioms

Whitespace changes

    • -69
    • +68
    ./acs-service-contract/tcl/acs-service-contract-procs.tcl
Add @see and fix typo in proc doc

    • -2
    • +4
    ./acs-service-contract/tcl/acs-service-contract-procs.tcl
Fix typo in proc doc

Repeat this block of code here as well, as vars in the checks are not kept in the script body

Fix typos in proc doc

    • -2
    • +2
    ./acs-templating/tcl/richtext-or-file-procs.tcl
    • -1
    • +1
    ./acs-templating/tcl/richtext-procs.tcl
Fix typo in proc doc

    • -2
    • +2
    ./acs-templating/tcl/richtext-or-file-procs.tcl
Chat Redesign: add float clear after user block in user list (also in 'classic' skin)

Chat Redesign: add float clear after user block in user list

don't load deleted messages into the cache and drop conceptually broken parameter

    • -10
    • +7
    ./acs-lang/tcl/lang-message-procs.tcl