OpenACS / openacs-4 / packages

xowiki

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 20 Dec
Commits this week: 0
Total Lines of Code (LoC): 139,157
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 11 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 29 Feb
2:19 pm

antoniop

Update italian localization

Options
    • -2
    • +2
    ./xowiki.info
    • -0
    • +3
    ./catalog/xowiki.it_IT.ISO-8859-1.xml
  3. … 4 more files in changeset.
1:58 pm

antoniop

Introduce server-side validation for HTML5 date and time formfields

A "formats" parameter can be specified on the formfields indicating one or more formats that we want to enforce. The syntax for any of such format is that of the Tcl clock command.

Default values have been set according to the expected behavior of each form field type.

Empty values are always considered valid. If a field is required, this will be enforced in its own validator.

Options
    • -2
    • +2
    ./xowiki.info
    • -0
    • +3
    ./catalog/xowiki.de_DE.ISO-8859-1.xml
    • -0
    • +3
    ./catalog/xowiki.en_US.ISO-8859-1.xml
    • -11
    • +69
    ./tcl/form-field-procs.tcl
1:53 pm

antoniop

Test behavior of HTML5 date and time formfields when invalid values are submitted

Options
    • -0
    • +186
    ./tcl/test/xowiki-test-procs.tcl
Monday 26 Feb
10:58 am

gustafn

removed code, which was commented out since ages.

Options
    • -25
    • +0
    ./tcl/yui-init.tcl
10:57 am

gustafn

Cleanup of external binaries: always use "util::which" to resolve binaries

Options
    • -1
    • +3
    ./www/ckeditor-images/upload_image.tcl
  2. … 5 more files in changeset.
Friday 16 Feb
11:31 am

gustafn

Fixed unreviewed commit, which might lead to hard-to-spot errors

The last change assumed that "nls_language" can be hard-wired to

contain most 5 characters. While this not backed by the OpenACS data

model, the standard (RFC 5646) explicitly states that there is no

upper limit on the size of language tags. The tree letter language

codes have been standard since 2001 (RFC 4646).

The change accepts now all defined locales. When the specified locale

is not enabled, it provides a log notice, when the locale is not

defined at all, it provides a warning and falls back to "en_US".

Options
    • -3
    • +3
    ./xowiki.info
    • -2
    • +17
    ./tcl/xowiki-form-procs.tcl
  3. … 2 more files in changeset.
Wednesday 14 Feb
1:54 pm

antoniop

Validate as a token also the default coming from _nls_language, ensure the resulting language key is at most 5 chars long (many thanks to Markus Moser for this)

Options
    • -3
    • +5
    ./tcl/xowiki-form-procs.tcl
Friday 09 Feb
11:36 am

gustafn

improved bootstrap5 compatibility for personal notifications

This change improves the appearance of personal notifications

for bootstrap5. It still works with bootstrap3.

Many thanks to Sebastian Scheder for this contribution!

Options
    • -11
    • +24
    ./tcl/personal-notification-procs.tcl
10:49 am

antoniop

Close the connection to the EventSource before leaving the page

Some browsers such as current Firefox may complain otherwise

Many thanks to Sebastian Scheder

Options
    • -0
    • +10
    ./www/resources/chat.js
Tuesday 06 Feb
11:00 am

antoniop

Improve visualization of test info

Options
    • -2
    • +2
    ./tcl/test/xowiki-test-procs.tcl
10:32 am

antoniop

Relax test condition:

make sure potential injections are not rendered on the page response.

Options
    • -6
    • +13
    ./tcl/test/xowiki-test-procs.tcl
Friday 02 Feb
1:35 pm

gustafn

Improved consistency of appearance, when multiple CSS toolkits are in use

- This change makes sure that consistently [::xowiki::CSS toolkit] is

used instead of accessing the package parameter

"PreferredCSSToolkit" directly. This change is necessary for

handling e.g. of the parameter setting "default"

consistently. Previously, a "default" value could result in loading

the obsolete YUI .js and .css files.

- When "menu_entries" have multiple "config" entries, use the last one.

Options
    • -5
    • +11
    ./tcl/folder-procs.tcl
    • -8
    • +5
    ./tcl/table-widget-procs.tcl
1:31 pm

gustafn

Extended site-wide admin page to include link for site-wide pages

Adding a link to site-wide admin pages makes it easier for admins to locate

the site-wide pages (pages, which can be used in all xowiki instances)

Options
    • -0
    • +4
    ./www/sitewide-admin/index.adp
    • -1
    • +3
    ./www/sitewide-admin/index.tcl
1:27 pm

gustafn

Added link to parameter page in xowiki/admin page if it exists

This is a change to ease usage for novices. The "admin" pages should be replaced

in the future, but for the time being, it helps for site-admins to understand,

how to change which parameter value to obtain the desired results.

Options
    • -1
    • +7
    ./www/admin/index.tcl
1:20 pm

gustafn

Extended "Page.copy_content_vars" with a "-except" parameter

This change makes it possible to use values from template pages

without changing the name of the target page. This change also

introduces a small modernization to use dicts instead of arrays.

Options
    • -7
    • +14
    ./tcl/xowiki-procs.tcl
1:14 pm

gustafn

added URL for version checking to see, if a newer version is available from the CDN

Options
    • -1
    • +2
    ./tcl/resource-info-procs.tcl
Wednesday 31 Jan
1:48 pm

antoniop

Extend test suite

when testing FormPage validation, make sure two distinct behaviors are respected:

1) Rejected values that were part of the request are kept into their original form fields so the user can rework them and resubmit

2) Other parts of the page, such as the page title, are NOT influenced by data that faild to validate

Rationale: displaying unvalidated information as part of the response can be interpreted as a page injection.

In current codebase, that the title was changed indicates, that rejected information made its way into the :title object member of the FormPage.

The potential consequences of the FormPage setting unvalidated information into its members depends on a number of factors such as formfield logics, callbacks and proper page quoting (to name a few).

Options
    • -1
    • +17
    ./tcl/test/xowiki-test-procs.tcl
Tuesday 30 Jan
6:18 pm

gustafn

Reduced attack vectors for query and form variables while keeping semantics

- improve form_parameter and query variable validation

- revert partly change: it is intentional that in case of validation errors, the

instances variables of the in-memory object contain invalid data in order

to be able to show the use the invalid data in the form.

- prefer "string first" idiom over regular expression

Options
    • -54
    • +49
    ./tcl/xowiki-www-procs.tcl
6:17 pm

gustafn

fix typo

Options
    • -2
    • +2
    ./tcl/xowiki-form-procs.tcl
5:35 pm

antoniop

Fix typo

Options
    • -2
    • +1
    ./tcl/xowiki-www-procs.tcl
11:28 am

gustafn

removed obsolete code

Options
    • -5
    • +1
    ./tcl/includelet-procs.tcl
11:28 am

gustafn

update CDN source

The previous CDN site stopped working

Options
    • -2
    • +2
    ./tcl/yui-init.tcl
11:15 am

gustafn

generalized handling of error pages in disconnected stage

Options
    • -12
    • +8
    ./tcl/package-procs.tcl
10:35 am

antoniop

Cleanup leftover library: latest javascript assumes XMLHttpRequest is supported

Options
    • -3
    • +1
    ./tcl/chat-procs.tcl
Friday 26 Jan
5:37 pm

antoniop

Chat reform

The goal of these changes is to reduce the "mode" specific javascript code in the chat implementation and reduce server-side guessing of browser capabilities.

- In the MessageRelay class from xotcl-core, we rework the javascript code sent to the connection when doing scripted streaming to make less assumptions about the functions defined in the parent scope

- In the chat code from xowiki, we move most of the logics to guess the mode into javascript, where we can test the actual capabilities of the browser without relying on the user agent

- The previously 4 javascript files dependant on the chat mode have been made into one

Options
    • -3
    • +3
    ./xowiki.info
    • -112
    • +17
    ./tcl/chat-procs.tcl
    • -160
    • +0
    ./www/resources/chat-common.js
    • -34
    • +286
    ./www/resources/chat.js
    • -20
    • +0
    ./www/resources/scripted-streaming-chat.js
    • -31
    • +0
    ./www/resources/streaming-chat.js
  7. … 2 more files in changeset.
2:14 pm

antoniop

When the mode is "streaming", use Server Sent Events instead of a "plain" endless request

This has the advantage of a clearer, less hacky api, which, for instance, does not require manual parsing of the partial response.

Options
    • -3
    • +3
    ./xowiki.info
    • -10
    • +9
    ./tcl/chat-procs.tcl
    • -42
    • +16
    ./www/resources/streaming-chat.js
  4. … 2 more files in changeset.
11:30 am

antoniop

Cleanup leftover method: its logics were moved to the MessageRelay class

Options
    • -15
    • +1
    ./tcl/chat-procs.tcl
Thursday 25 Jan
12:44 pm

antoniop

Cleanup commented code

Options
    • -11
    • +1
    ./tcl/xowiki-form-procs.tcl
Tuesday 23 Jan
2:20 pm

antoniop

Revert to an approach that will not change the [self] object, which has unexpected consequences

Options
    • -2
    • +9
    ./tcl/xowiki-www-procs.tcl
Monday 22 Jan
3:52 pm

antoniop

Use a better idiom to revert changes on the object, that e.g. will handle the same arrays and variables

Options
    • -4
    • +2
    ./tcl/xowiki-www-procs.tcl