OpenACS / openacs-4 / packages

xowiki

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 20 Dec
Commits this week: 0
Total Lines of Code (LoC): 139,157
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 26 Jan
5:37 pm

antoniop

Chat reform

The goal of these changes is to reduce the "mode" specific javascript code in the chat implementation and reduce server-side guessing of browser capabilities.

- In the MessageRelay class from xotcl-core, we rework the javascript code sent to the connection when doing scripted streaming to make less assumptions about the functions defined in the parent scope

- In the chat code from xowiki, we move most of the logics to guess the mode into javascript, where we can test the actual capabilities of the browser without relying on the user agent

- The previously 4 javascript files dependant on the chat mode have been made into one

Options
    • -3
    • +3
    ./xowiki.info
    • -112
    • +17
    ./tcl/chat-procs.tcl
    • -160
    • +0
    ./www/resources/chat-common.js
    • -34
    • +286
    ./www/resources/chat.js
    • -20
    • +0
    ./www/resources/scripted-streaming-chat.js
    • -31
    • +0
    ./www/resources/streaming-chat.js
  7. … 2 more files in changeset.
2:14 pm

antoniop

When the mode is "streaming", use Server Sent Events instead of a "plain" endless request

This has the advantage of a clearer, less hacky api, which, for instance, does not require manual parsing of the partial response.

Options
    • -3
    • +3
    ./xowiki.info
    • -10
    • +9
    ./tcl/chat-procs.tcl
    • -42
    • +16
    ./www/resources/streaming-chat.js
  4. … 2 more files in changeset.
11:30 am

antoniop

Cleanup leftover method: its logics were moved to the MessageRelay class

Options
    • -15
    • +1
    ./tcl/chat-procs.tcl
Thursday 25 Jan
12:44 pm

antoniop

Cleanup commented code

Options
    • -11
    • +1
    ./tcl/xowiki-form-procs.tcl
Tuesday 23 Jan
2:20 pm

antoniop

Revert to an approach that will not change the [self] object, which has unexpected consequences

Options
    • -2
    • +9
    ./tcl/xowiki-www-procs.tcl
Monday 22 Jan
3:52 pm

antoniop

Use a better idiom to revert changes on the object, that e.g. will handle the same arrays and variables

Options
    • -4
    • +2
    ./tcl/xowiki-www-procs.tcl
Tuesday 16 Jan
6:35 pm

antoniop

Ensure we are still connected before we try to render the error to the user

For instance, the error may have beeen triggered by unexpected lack of connection, e.g. when we try to return content after a redirect has already been issued.

Options
    • -4
    • +12
    ./tcl/package-procs.tcl
Monday 15 Jan
12:42 pm

antoniop

Extend test: edit a different component of repeated compound 3 to also test that old and new values are stored as expected

Options
    • -0
    • +6
    ./tcl/test/xowiki-test-procs.tcl
Tuesday 09 Jan
5:17 pm

antoniop

Extend and fix xowiki.create_form_with_form_instance automated test with respect to checkbox behavior

- simple checkboxes (normal and repeated): as we do not specify a value for those, the default should be expected, not the last option

- checkboxes in repeated compound fields: upon triavial re-editing, the values should stay the same

This change exposes a bug in acs::test::xpath::get_form_values

Options
    • -8
    • +56
    ./tcl/test/xowiki-test-procs.tcl
Wednesday 20 Dec 2023
2:13 pm

antoniop

Port of downstream modification:

do not restrict the format the user can supply. Sanitize the filename later and complain only if this is made exclusively of invalid characters.

Options
    • -2
    • +12
    ./tcl/xowiki-www-procs.tcl
12:04 pm

antoniop

get_form_data reform:

when validation fails, revert all changes performed on the object while filling up the form fields.

Rationale: when validation fails, we do not persist the data. The same we should not let unvalidated data sneak into the object, as this may be e.g. displayed on the page or be otherwise used by the system.

Options
    • -1
    • +15
    ./tcl/xowiki-www-procs.tcl
Thursday 14 Dec 2023
10:57 am

antoniop

Do not retrieve extra_css from query_parameters, as this is vulnerable to injections

Many thanks to Markus Moser

Options
    • -2
    • +4
    ./tcl/xowiki-www-procs.tcl
Wednesday 29 Nov 2023
2:44 pm

gustafn

reduced verbosity

Options
    • -2
    • +2
    ./tcl/package-procs.tcl
Friday 24 Nov 2023
1:56 pm

antoniop

Fix syntax of new oneof value checker

Options
    • -3
    • +3
    ./tcl/xowiki-www-procs.tcl
  2. … 1 more file in changeset.
Thursday 23 Nov 2023
12:14 pm

antoniop

Validate nls_language so that the only values allowed are existing enabled locales

Options
    • -3
    • +3
    ./xowiki.info
    • -3
    • +15
    ./tcl/xowiki-www-procs.tcl
Tuesday 21 Nov 2023
2:30 pm

antoniop

Fix parenthesys in bulk actions

Many thanks to Sebastian Scheder

Options
    • -16
    • +16
    ./tcl/bootstrap-procs.tcl
Monday 20 Nov 2023
6:06 pm

antoniop

Get the preferred css toolkit via api, as this will introduce additional fallback logics with respect to the plain parameter

Options
    • -4
    • +1
    ./tcl/menu-procs.tcl
Friday 03 Nov 2023
6:52 pm

antoniop

Ensure scripts and internal use information are not rendered together with the content, in particular for dumber HTML renderer

Options
    • -7
    • +4
    ./tcl/chat-procs.tcl
Monday 30 Oct 2023
12:20 pm

antoniop

Make sure method variable exists, fixes automated tests

Options
    • -1
    • +2
    ./tcl/package-procs.tcl
12:17 pm

antoniop

Whitespace cleanup

Options
    • -7
    • +7
    ./tcl/package-procs.tcl
Sunday 22 Oct 2023
5:53 pm

gustafn

improve bootstrap3/bootstrap5 handling of personal notification messages

Many thanks for Monika Andergassen for providing the patch.

Options
    • -2
    • +56
    ./tcl/package-procs.tcl
    • -3
    • +12
    ./tcl/personal-notification-procs.tcl
Wednesday 18 Oct 2023
11:26 am

antoniop

Update italian localization

Options
    • -2
    • +2
    ./xowiki.info
    • -0
    • +1
    ./catalog/xowiki.it_IT.ISO-8859-1.xml
  3. … 6 more files in changeset.
Wednesday 27 Sep 2023
3:29 pm

antoniop

Export catalog via the UI to normalize sorting and quoting

Options
    • -2
    • +2
    ./xowiki.info
    • -33
    • +30
    ./catalog/xowiki.de_DE.ISO-8859-1.xml
    • -38
    • +35
    ./catalog/xowiki.en_US.ISO-8859-1.xml
Monday 25 Sep 2023
9:35 am

gustafn

fix typo

Options
    • -2
    • +2
    ./tcl/upgrade/upgrade.tcl
Thursday 14 Sep 2023
12:26 am

gustafn

move "-destroy_on_cleanup" towards the end of the parameter list

This change improves protection about ambiguous user input

Options
    • -3
    • +3
    ./tcl/chat-procs.tcl
    • -8
    • +12
    ./tcl/form-field-procs.tcl
    • -5
    • +7
    ./tcl/import-procs.tcl
    • -5
    • +6
    ./tcl/includelet-procs.tcl
    • -5
    • +7
    ./tcl/package-procs.tcl
    • -4
    • +5
    ./tcl/xowiki-www-procs.tcl
  7. … 3 more files in changeset.
Monday 04 Sep 2023
5:55 pm

gustafn

use CSSclass "form-range" for Bootstrap5

Options
    • -1
    • +4
    ./tcl/package-procs.tcl
Tuesday 08 Aug 2023
12:11 pm

gustafn

more fixups fr bootstrap5

Options
    • -1
    • +7
    ./tcl/package-procs.tcl
Thursday 03 Aug 2023
1:15 pm

gustafn

bootstrap5 bulkactions: move "ul" element to one level higher

Many thanks to Monika Andergassen for the change

Options
    • -20
    • +23
    ./tcl/bootstrap-procs.tcl
1:05 pm

gustafn

bootstrap5 dropt down menu item: add "disabled" class to the anchor element as well

Many thanks to Monika Andergassen for the suggestion

Options
    • -3
    • +4
    ./tcl/bootstrap-procs.tcl
12:35 pm

gustafn

use for bootstrap5 for select input form-select instead of form-control

Many thanks to Monika Andergassen for noting

Options
    • -1
    • +4
    ./tcl/package-procs.tcl