• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Cleanup commented code

Revert to an approach that will not change the [self] object, which has unexpected consequences

Use a better idiom to revert changes on the object, that e.g. will handle the same arrays and variables

Ensure we are still connected before we try to render the error to the user

For instance, the error may have beeen triggered by unexpected lack of connection, e.g. when we try to return content after a redirect has already been issued.

Extend test: edit a different component of repeated compound 3 to also test that old and new values are stored as expected

Extend and fix xowiki.create_form_with_form_instance automated test with respect to checkbox behavior

- simple checkboxes (normal and repeated): as we do not specify a value for those, the default should be expected, not the last option

- checkboxes in repeated compound fields: upon triavial re-editing, the values should stay the same

This change exposes a bug in acs::test::xpath::get_form_values

Port of downstream modification:

do not restrict the format the user can supply. Sanitize the filename later and complain only if this is made exclusively of invalid characters.

get_form_data reform:

when validation fails, revert all changes performed on the object while filling up the form fields.

Rationale: when validation fails, we do not persist the data. The same we should not let unvalidated data sneak into the object, as this may be e.g. displayed on the page or be otherwise used by the system.

Do not retrieve extra_css from query_parameters, as this is vulnerable to injections

Many thanks to Markus Moser

reduced verbosity

Fix syntax of new oneof value checker

  1. … 1 more file in changeset.
Validate nls_language so that the only values allowed are existing enabled locales

Fix parenthesys in bulk actions

Many thanks to Sebastian Scheder

Get the preferred css toolkit via api, as this will introduce additional fallback logics with respect to the plain parameter

Ensure scripts and internal use information are not rendered together with the content, in particular for dumber HTML renderer

Make sure method variable exists, fixes automated tests

Whitespace cleanup

improve bootstrap3/bootstrap5 handling of personal notification messages

Many thanks for Monika Andergassen for providing the patch.

    • -3
    • +12
    ./tcl/personal-notification-procs.tcl
Update italian localization

  1. … 6 more files in changeset.
Export catalog via the UI to normalize sorting and quoting

    • -33
    • +30
    ./catalog/xowiki.de_DE.ISO-8859-1.xml
    • -38
    • +35
    ./catalog/xowiki.en_US.ISO-8859-1.xml
fix typo

move "-destroy_on_cleanup" towards the end of the parameter list

This change improves protection about ambiguous user input

  1. … 3 more files in changeset.
use CSSclass "form-range" for Bootstrap5

more fixups fr bootstrap5

bootstrap5 bulkactions: move "ul" element to one level higher

Many thanks to Monika Andergassen for the change

bootstrap5 dropt down menu item: add "disabled" class to the anchor element as well

Many thanks to Monika Andergassen for the suggestion

use for bootstrap5 for select input form-select instead of form-control

Many thanks to Monika Andergassen for noting

fix indentation

minor change in comment

fix dirty-editor-buffer bug