• last updated 20 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
reveive dotlrn community includelet

    • -0
    • +222
    ./tcl/dotlrn-portal-procs.tcl
modernize code

prefer "array size" over llength of names

prefer "-base" parameter of export_vars

add quotes for nicer editor rendering

Replace single quotes wuith double quotes in javascript expressions involving acs_ListBulkActionClick

this is really needed only for the URL part, but was done on the name as well for consistency. The reason

is even a properly encoded URL could still contain single quotes, therefore breaking the expression,

while double quotes are expected to be encoded in valid, urlencoded URLs. This relies on trusting the developer

to properly encode URLs, which should be expected. An alternative could involve active escaping of

javascript special characters by e.g. ad_js_escape.

  1. … 6 more files in changeset.
Chat Redesign: add float clear after user block in user list (also in 'classic' skin)

Chat Redesign: add float clear after user block in user list

Chat Redesign:

+ Add specific container for the chat includelet (xowiki-chat-includelet).

+ Set a sensible default for the 'xowiki-chat-includelet' size.

+ Move the 'my-user-id' hidden element in the chat adp to the chat procs.

+ Rename 'my-user-id' element to 'xowiki-my-user-id'.

+ Get the ChatSkin parameter inside the login proc.

+ Include the skin parameter in the chat includelet.

  1. … 3 more files in changeset.
Make parameter comment coherent with the real default value

file chat-common.js was added on branch oacs-5-10 on 2019-02-25 15:35:44 +0000

Chat Redesign:

+ Skin support.

+ New 'ChatSkin' instance parameter, with currently two possible values: 'classic' and 'bubbles'.

+ Skins are located in the new packages/xowiki/www/resources/chat-skins/ directory.

+ New 'bubbles' skin, default for the chat package.

+ Old skin renamed to 'classic', default for the xowiki includelet.

+ New skins can be created by just adding the css and js files in the skins directory, and naming them accordingly. For example, being '$skin' the name of the new skin, the files should be named chat-$skin-common.js and chat-$skin.css.

+ New '-skin' parameter to the Chat login proc, containing the name of the skin (i.e. 'classic' or 'bubbles').

+ Bump version number.

    • -0
    • +270
    ./www/resources/chat-skins/chat-bubbles-common.js
    • -0
    • +371
    ./www/resources/chat-skins/chat-bubbles.css
    • -0
    • +211
    ./www/resources/chat-skins/chat-classic-common.js
    • -0
    • +251
    ./www/resources/chat-skins/chat-classic.css
  1. … 3 more files in changeset.
Chat Redesign: scroll down list of messages when clicking the 'Full screen' trigger

Chat Redesign: better adjust height to avoid issues on 'Full screen' mode on certain tablets

Prefer classic block comments in css to avoid potential side-effects

Chat Redesign: set min-width to the send form and the 'Full screen' trigger so they do not overlap in very small widths

Chat Redesign: set min-width to the send button, so it does not collapse in very small widths

Chat Redesign: use hyphens and overflow-wrap to manage line overflow, instead of just blindly breaking all words

Chat Redesign: hide background scroll bar in 'Full screen' mode

Chat Redesign: avoid timestamp float overlapping by clearing floats after the message block

Don't use the "javascript:" presudo-URL idiom to avoid CSP complaints from the browser

Provide a working way to configure the plain xowiki chat includelet:

at Chat class instantiation one can now specify a configuration dict that will be

persisted in an nsv and used to set option parameters (instance variables) such as login messages, logout messages

and the messages time window (and potentially other options in the future). This persistent configuration happpens whenever a client

logs in.

  1. … 1 more file in changeset.
Chat Redesign: be more explicit in the send icon padding and border, to avoid unintended theme inheritance

Retract configurability for plain xowiki includelet as, without some way of persisisting the conf over subsequent object instantiations, would really not work and also ignore chat room configs

  1. … 1 more file in changeset.
Use again more standard idiom to fix user picture border this time

Use more standard-friendly idioms when rendering user information (fixes colors in IE)

Properly close button tag (Explorer was complaining)

Use a more standard-friendly idiom to attach an event handler (fixes IE)

Allow also plain xowiki includelet to specifiy if we want login and logout messages and the past messages time window through includelet parameters

  1. … 1 more file in changeset.
Chat Redesign: avoid breakage produced by veeeeeeery long words by breaking them using the 'word-break' css property