• last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
improve spelling

  1. … 5 more files in changeset.
prefer usage of parameter::get_from_package_key over plain parameter::get

Properly escape "<" and ">" in api-doc documentation.

Since all documentation is rendered via HTML, the characters

"<" and ">" have to be HTML-quoted, otherwise strange things

(omission, unintended renderings) might occur.

E.g. the sentence

Define an interface between a page and an

ADP <include> similar to the page_contract.

was rendered as

Define an interface between a page and an

ADP similar to the page_contract.

which is incorrect.

    • -10
    • +18
    ./notification-callback-procs.tcl
  1. … 13 more files in changeset.
Whitespace cleanup

Use quicker idiom to check for existance

Whitespace cleanup

Whitespace changes

Prefer api to retrieve the approval state of a user

Complete coverage for the notification package

    • -0
    • +247
    ./test/notifications-test-procs.tcl
Brutally delete the notification requests before deleting the delivery method (it's fine because it will be rolled back)

Fix issue in the query logics: we actually want to check the owner of the request, there might be multiple requests associated to the same object

    • -1
    • +10
    ./test/notifications-test-procs.tcl
Extend coverage, this will expose an api bug

    • -0
    • +179
    ./test/notifications-test-procs.tcl
Extend coverage

    • -1
    • +27
    ./test/notifications-test-procs.tcl
Cover more api

    • -0
    • +42
    ./test/notifications-test-procs.tcl
Extend automated tests

    • -0
    • +124
    ./test/notifications-test-procs.tcl
Allow to specify a user that does not come from the connection

Expand tests

    • -2
    • +80
    ./test/notifications-test-procs.tcl
Improve test a bit

Update documentation to best practices

Fix proc signature

  1. … 6 more files in changeset.
Replace leftover occurrences

  1. … 1 more file in changeset.
Deprecate notification::get_delivery_method_id, same as notification::delivery::get_id and looking more established

  1. … 6 more files in changeset.
Deprecate notification::get_interval_id, duplicated by notification::interval::get_id_from_name which appears to be more established

    • -21
    • +38
    ./test/notifications-test-procs.tcl
  1. … 4 more files in changeset.
Prefer flushing the cache, this addresses the automated test, where multiple insert/deletion are performed in the same request

Extend test

    • -12
    • +36
    ./test/notifications-test-procs.tcl
Cache the new type_id immediately in the (rare) event that a type was created in a previous request with the same name and then deleted

Expand test

    • -1
    • +10
    ./test/notifications-test-procs.tcl
Fix typo in xql file

    • -1
    • +1
    ./notification-request-procs-postgresql.xql
Extend notifications tests

    • -0
    • +154
    ./test/notifications-test-procs.tcl
Prefer the non cached api when deleting, as the id is cached in the thread and could be stale