OpenACS / openacs-4 / packages / notifications

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 32
Last Commit: 05 Apr
Commits this week: 0
Total Lines of Code (LoC): 3,012
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 27 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 11 Jul 2022
5:50 pm

antoniop

Complete coverage for the notification package

Options
    • -0
    • +247
    ./test/notifications-test-procs.tcl
5:09 pm

antoniop

Brutally delete the notification requests before deleting the delivery method (it's fine because it will be rolled back)

Options
    • -0
    • +1
    ./test/notifications-test-procs.tcl
2:56 pm

antoniop

Fix issue in the query logics: we actually want to check the owner of the request, there might be multiple requests associated to the same object

Options
    • -6
    • +6
    ./notifications-security-procs.tcl
    • -1
    • +10
    ./test/notifications-test-procs.tcl
2:49 pm

antoniop

Extend coverage, this will expose an api bug

Options
    • -0
    • +179
    ./test/notifications-test-procs.tcl
10:58 am

antoniop

Extend coverage

Options
    • -1
    • +27
    ./test/notifications-test-procs.tcl
10:42 am

antoniop

Cover more api

Options
    • -0
    • +42
    ./test/notifications-test-procs.tcl
10:23 am

antoniop

Extend automated tests

Options
    • -0
    • +124
    ./test/notifications-test-procs.tcl
10:07 am

antoniop

Allow to specify a user that does not come from the connection

Options
    • -2
    • +7
    ./notification-display-procs.tcl
Friday 08 Jul 2022
6:18 pm

antoniop

Expand tests

Options
    • -2
    • +80
    ./test/notifications-test-procs.tcl
5:54 pm

antoniop

Improve test a bit

Options
    • -2
    • +9
    ./test/notifications-test-procs.tcl
5:46 pm

antoniop

Update documentation to best practices

Options
    • -10
    • +8
    ./notification-display-procs.tcl
5:16 pm

antoniop

Fix proc signature

Options
    • -2
    • +2
    ./notification-procs.tcl
    • -1
    • +1
    ./test/notifications-test-procs.tcl
  3. … 6 more files in changeset.
5:06 pm

antoniop

Replace leftover occurrences

Options
    • -2
    • +2
    ./notification-procs.tcl
  2. … 1 more file in changeset.
4:53 pm

antoniop

Deprecate notification::get_delivery_method_id, same as notification::delivery::get_id and looking more established

Options
    • -2
    • +7
    ./notification-procs.tcl
    • -2
    • +2
    ./test/notifications-test-procs.tcl
  3. … 6 more files in changeset.
4:36 pm

antoniop

Deprecate notification::get_interval_id, duplicated by notification::interval::get_id_from_name which appears to be more established

Options
    • -3
    • +8
    ./notification-procs.tcl
    • -21
    • +38
    ./test/notifications-test-procs.tcl
  3. … 4 more files in changeset.
11:23 am

antoniop

Prefer flushing the cache, this addresses the automated test, where multiple insert/deletion are performed in the same request

Options
    • -3
    • +2
    ./notification-type-procs.tcl
11:22 am

antoniop

Extend test

Options
    • -12
    • +36
    ./test/notifications-test-procs.tcl
10:50 am

antoniop

Cache the new type_id immediately in the (rare) event that a type was created in a previous request with the same name and then deleted

Options
    • -2
    • +5
    ./notification-type-procs.tcl
10:47 am

antoniop

Expand test

Options
    • -1
    • +10
    ./test/notifications-test-procs.tcl
Thursday 07 Jul 2022
5:52 pm

antoniop

Fix typo in xql file

Options
    • -1
    • +1
    ./notification-request-procs-postgresql.xql
5:52 pm

antoniop

Extend notifications tests

Options
    • -0
    • +154
    ./test/notifications-test-procs.tcl
4:39 pm

antoniop

Prefer the non cached api when deleting, as the id is cached in the thread and could be stale

Options
    • -2
    • +2
    ./notification-type-procs.tcl
4:31 pm

antoniop

Some tests for the notifications api, more to come

Options
    • -0
    • +110
    ./test/notifications-test-procs.tcl
4:31 pm

antoniop

file notifications-test-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./test/notifications-test-procs.tcl
Thursday 14 Apr 2022
3:30 pm

gustafn

Added parameter for sweep interval for stale notification as stated in a comment already.

Many thanks to Franz Penz for pusing this.

Options
    • -6
    • +7
    ./sweep-init.tcl
  2. … 1 more file in changeset.
Wednesday 16 Feb 2022
2:19 pm

gustafn

Fixes for Oracle 19c: make query portable to Oracle by replacing USING by explicit ON joins

This fixed the following problem, where the problem is not easy to spot on first sight:

[16/Feb/2022:13:26:09][12845.7efd2d3e1700][-sched:0:41:22-] Error: nsoracle.c:1367:OracleSelect: error in `OCIStmtExecute ()': ORA-00904: "NOTIFICATION_REQUESTS"."USER_ID": invalid identifier

: SQL:

: select notification_id,

: notif_subject,

: notif_text,

: notif_html,

: file_ids,

: user_id,

: request_id,

: type_id,

: delivery_method_id,

: response_id,

: notif_date,

: notif_user,

: acs_permission.permission_p(notification_requests.object_id, !>>>!notification_requests.user_id, 'read') as still_valid_p

: from notifications inner join notification_requests using (type_id, object_id)

: inner join acs_objects on (notification_requests.request_id = acs_objects.object_id)

: left outer join notification_user_map using (notification_id, user_id)

: where sent_date is null

: and creation_date <= notif_date

: and (notif_date is null or notif_date < current_timestamp)

: and interval_id = :interval_id

Options
    • -7
    • +10
    ./sweep-procs.tcl
Tuesday 28 Dec 2021
12:40 pm

antoniop

Deprecate oacs_util::vars_to_ns_set: modern ns_set idioms make this proc obsolete

Options
    • -6
    • +7
    ./delivery-method-procs.tcl
    • -8
    • +13
    ./notification-procs.tcl
    • -6
    • +12
    ./notification-reply-procs.tcl
    • -5
    • +11
    ./notification-request-procs.tcl
    • -3
    • +8
    ./notification-type-procs.tcl
  6. … 3 more files in changeset.
Tuesday 17 Aug 2021
11:54 am

gustafn

Notification request cleanup refactoring

One of the most expensive operations in large site is the cleanup for

notification_requests in situations, where the user has lost

permissions on an object, on which the user wanted to receive

notifications. This check was performed previously in

notification::sweep::cleanup_notifications via a permission check over

all notification requests, which can be very costly on large

sites. This change moves this cleanup into the actual notification

sending, where the permissions have to be sent anyhow.

Options
    • -18
    • +54
    ./sweep-procs.tcl
Wednesday 28 Apr 2021
7:00 pm

antoniop

Fix typo in comment

Options
    • -2
    • +2
    ./notification-email-procs.tcl
6:59 pm

antoniop

When sending a notification on behalf of a person, if the system is not configured to process replies to notification, do not set the reply-to address to anything different than the sender

Options
    • -4
    • +17
    ./notification-email-procs.tcl