OpenACS / openacs-4 / packages

forums

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 61
Last Commit: 31 May
Commits this week: 0
Total Lines of Code (LoC): 21,951
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 8 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 09 May 2018
5:33 pm

hectorr

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

Options
    • -2
    • +2
    ./lib/forums/forums-chunk.tcl
    • -2
    • +2
    ./lib/message/threads-chunk.tcl
    • -2
    • +2
    ./tcl/forums-sc-procs.tcl
  4. … 473 more files in changeset.
Monday 30 Apr 2018
11:07 am

gustafn

unify spelling of URL

Options
    • -3
    • +3
    ./tcl/forums-callback-procs.tcl
    • -2
    • +2
    ./tcl/forums-sc-procs.tcl
    • -1
    • +1
    ./tcl/test/tclwebtest-procs.tcl
  4. … 1 more file in changeset.
Thursday 26 Apr 2018
10:56 am

hectorr

Prefer '{}' to '[list]' when creating empty lists

Options
    • -2
    • +2
    ./lib/forums/forums-chunk.tcl
    • -2
    • +2
    ./lib/message/threads-chunk.tcl
  3. … 224 more files in changeset.
Wednesday 25 Apr 2018
9:47 pm

hectorr

Prefer '{}' to '[list]' when creating empty lists

Options
    • -2
    • +2
    ./tcl/forums-sc-procs.tcl
  2. … 204 more files in changeset.
Tuesday 24 Apr 2018
4:28 pm

hectorr

Rework variable assignment (set -> lassign)

Options
    • -7
    • +4
    ./lib/forums-portlet.tcl
    • -3
    • +2
    ./lib/message/attachment-list.tcl
    • -8
    • +6
    ./www/admin/subscribe-others.tcl
  4. … 10 more files in changeset.
Thursday 19 Apr 2018
12:25 am

hectorr

Fix typos

Options
    • -7
    • +7
    ./tcl/messages-procs.tcl
  2. … 7 more files in changeset.
Saturday 07 Apr 2018
9:07 pm

gustafn

remove parens

Options
    • -2
    • +2
    ./lib/forums/admin-forums-chunk.tcl
    • -2
    • +2
    ./lib/forums/forums-chunk.tcl
    • -1
    • +1
    ./lib/forums/forums-history-chunk.tcl
    • -2
    • +2
    ./lib/message/delete.tcl
    • -2
    • +2
    ./lib/message/messages-table.tcl
    • -2
    • +2
    ./lib/message/pending-list-chunk.tcl
    • -2
    • +2
    ./lib/message/threads-chunk.tcl
    • -2
    • +2
    ./lib/search/search-chunk.tcl
    • -4
    • +8
    ./www/moderate/move-thread-thread.tcl
Wednesday 04 Apr 2018
6:18 am

gustafn

improve spelliing

Options
    • -2
    • +2
    ./sql/postgresql/forums-messages-package-create.sql
    • -1
    • +1
    ./sql/postgresql/upgrade/upgrade-1.2d1-1.2d2.sql
  3. … 2 more files in changeset.
Thursday 29 Mar 2018
5:03 pm

hectorr

Fix typos

Options
    • -1
    • +1
    ./sql/postgresql/upgrade/upgrade-1.3.1d2-1.3.1d3.sql
  2. … 61 more files in changeset.
10:09 am

gustafn

fix more typos

Options
    • -2
    • +2
    ./www/admin/subscribe-others-2.tcl
  2. … 5 more files in changeset.
Wednesday 28 Mar 2018
11:55 pm

hectorr

Fix typos

Options
    • -1
    • +1
    ./forums.info
  2. … 7 more files in changeset.
11:04 pm

hectorr

Fix typos

Options
    • -1
    • +1
    ./catalog/forums.de_DE.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/forums.en_US.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/forums.es_ES.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/forums.it_IT.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/forums.ru_RU.utf-8.xml
  6. … 3 more files in changeset.
Wednesday 31 Jan 2018
9:25 pm

gustafn

fix typo

Options
    • -2
    • +2
    ./tcl/messages-procs.tcl
    • -1
    • +1
    ./www/resources/message-effects.js
Monday 29 Jan 2018
1:01 pm

gustafn

- fix inconsistency between updated versions and new intallations: check always the message format

- add text/markdown to accepted formats

Options
    • -2
    • +2
    ./forums.info
    • -0
    • +2
    ./sql/postgresql/forums-messages-create.sql
    • -0
    • +11
    ./sql/postgresql/upgrade/upgrade-1.3.1d4-1.3.1d5.sql
Saturday 27 Jan 2018
6:01 pm

gustafn

delete unreferenced .xql queries

Options
    • -35
    • +0
    ./lib/search/search-chunk-oracle.xql
    • -2
    • +2
    ./tcl/messages-procs.tcl
Sunday 21 Jan 2018
12:16 am

gustafn

Make termination after connection closing commands explicit

Options
    • -2
    • +3
    ./tcl/messages-procs.tcl
  2. … 1 more file in changeset.
Saturday 20 Jan 2018
11:49 pm

gustafn

Fix boolean expressions in -adp files, make termination after connection closing commands explicit

Options
    • -2
    • +3
    ./lib/message/attachment-list.tcl
  2. … 18 more files in changeset.
Friday 19 Jan 2018
3:20 pm

gustafn

add ad_script_abort after ad_returnredirect to make termination intent explicit

Options
    • -0
    • +1
    ./www/mark-all-read.tcl
    • -4
    • +2
    ./www/admin/forum-disable.tcl
    • -4
    • +2
    ./www/admin/forum-enable.tcl
    • -4
    • +2
    ./www/moderate/message-approve.tcl
    • -4
    • +2
    ./www/moderate/message-reject.tcl
  6. … 7 more files in changeset.
Thursday 23 Nov 2017
1:33 pm

antoniop

Reduce divergencies between oracle and postgres codebase

Options
    • -10
    • +0
    ./lib/forums/forums-chunk-oracle.xql
    • -11
    • +0
    ./lib/forums/forums-chunk-postgresql.xql
    • -0
    • +15
    ./lib/forums/forums-chunk.xql
  4. … 3 more files in changeset.
Wednesday 22 Nov 2017
3:02 pm

antoniop

Reduce divergencies between oracle and postgres codebase

Options
    • -29
    • +0
    ./lib/message/threads-chunk-oracle.xql
    • -32
    • +0
    ./lib/message/threads-chunk-postgresql.xql
    • -0
    • +34
    ./lib/message/threads-chunk.xql
Thursday 16 Nov 2017
1:40 pm

antoniop

Make forum::use_ReadingInfo_p more robust when UseReadingInfo parameter in forums is not set

Options
    • -2
    • +2
    ./lib/forums/forums-chunk.tcl
    • -2
    • +2
    ./lib/message/threads-chunk.tcl
    • -2
    • +2
    ./tcl/forums-procs.tcl
    • -2
    • +2
    ./www/message-view.tcl
12:03 pm

gustafn

make boolean test strict

Options
    • -2
    • +2
    ./lib/forums/forums-chunk.tcl
    • -2
    • +2
    ./lib/message/threads-chunk.tcl
    • -2
    • +2
    ./www/message-view.tcl
11:58 am

gustafn

Hot fix for latest changes concerning reading info

Options
    • -2
    • +2
    ./lib/forums/forums-chunk.tcl
    • -2
    • +2
    ./lib/message/threads-chunk.tcl
    • -2
    • +2
    ./www/message-view.tcl
Monday 13 Nov 2017
4:35 pm

antoniop

Fix typo

Options
    • -3
    • +3
    ./www/moderate/move.tcl
    • -1
    • +1
    ./www/moderate/move.xql
4:22 pm

antoniop

Port downstream only usage of reading info api

Also fix such api so that root message is retrieved for every given source message

Options
    • -2
    • +2
    ./forums.info
    • -5
    • +16
    ./sql/oracle/forums-reading-info-package-create.sql
    • -0
    • +163
    ./sql/oracle/upgrade/upgrade-1.3.1d3-1.3.1d4.sql
    • -2
    • +6
    ./sql/postgresql/forums-reading-info-create.sql
    • -0
    • +34
    ./sql/postgresql/upgrade/upgrade-1.3.1d3-1.3.1d4.sql
    • -1
    • +9
    ./www/moderate/move-thread-oracle.xql
    • -0
    • +8
    ./www/moderate/move-thread-postgresql.xql
    • -0
    • +5
    ./www/moderate/move-thread.tcl
3:31 pm

antoniop

Converge downstream reading_info feature with upstream

Port downstream only idiom to update reading_info table

Make more use of api when retrieving forum and message information

Optimize message existance query

Options
    • -10
    • +25
    ./www/moderate/move.tcl
    • -20
    • +14
    ./www/moderate/move.xql
1:52 pm

antoniop

Fix sql update to populate new forum_id column in existing data

Options
    • -3
    • +9
    ./sql/oracle/upgrade/upgrade-1.3.1d2-1.3.1d3.sql
    • -4
    • +9
    ./sql/postgresql/upgrade/upgrade-1.3.1d2-1.3.1d3.sql
Friday 10 Nov 2017
6:21 pm

antoniop

Maintenance of forum reading count feature

- removal of forums_reading_info_user (1Mio rows on Learn@WU).

This materialized view had to be constantly synced with

forums_reading_info table. Reimplemented as view.

- simplify logics in stored procedure due to new datamodel

- fix inconsistencies between oracle and postgres function definition

- re-enabled parameter to decide whether use these stats or not in

administration

TODO: consider further reform of this feature as stats grow very

large on busy sites for probably little value added

Options
    • -2
    • +2
    ./forums.info
    • -17
    • +10
    ./sql/oracle/forums-reading-info-create.sql
    • -3
    • +3
    ./sql/oracle/forums-reading-info-drop.sql
    • -143
    • +5
    ./sql/oracle/forums-reading-info-package-create.sql
    • -0
    • +186
    ./sql/oracle/upgrade/upgrade-1.3.1d2-1.3.1d3.sql
    • -195
    • +68
    ./sql/postgresql/forums-reading-info-create.sql
    • -9
    • +4
    ./sql/postgresql/forums-reading-info-drop.sql
    • -0
    • +173
    ./sql/postgresql/upgrade/upgrade-1.3.1d2-1.3.1d3.sql
    • -5
    • +2
    ./tcl/forums-procs.tcl
Thursday 09 Nov 2017
6:28 pm

antoniop

Remove deprecated idioms and unneded queries

Options
    • -8
    • +0
    ./lib/message/post-oracle.xql
    • -8
    • +0
    ./lib/message/post-postgresql.xql
    • -14
    • +13
    ./lib/message/post.tcl
    • -13
    • +0
    ./lib/message/post.xql
Wednesday 08 Nov 2017
1:05 pm

antoniop

Implement post anonymously through explicit forum attribute in table

Now moderators can explicitly decide whether a forum will enable posting anonymously or not.

Forum must be in a policy different from closed and the anonymous flag must be set accordingly for this to happen.

Also:

- normalize api in a way it can accomodate all current attributes. In particular,

now edit api will now leave every unspecified attribute unchanged, instead of

setting it to some default.

- fix some usability issues when managing forum parameters (e.g. values not

retrieved in form when editing existing forum)

- introduce missing Oracle upgrade script for the whole forum reform

- fix oracle creation script

Options
    • -2
    • +2
    ./forums.info
    • -22
    • +32
    ./lib/forums/edit.tcl
    • -18
    • +18
    ./lib/forums/new.tcl
    • -1
    • +7
    ./sql/oracle/forums-forums-create.sql
    • -0
    • +27
    ./sql/oracle/upgrade/upgrade-1.3.1d1-1.3.1d2.sql
    • -0
    • +3
    ./sql/postgresql/forums-forums-create.sql
    • -0
    • +13
    ./sql/postgresql/upgrade/upgrade-1.3.1d1-1.3.1d2.sql
    • -2
    • +8
    ./tcl/form-procs.tcl
    • -7
    • +27
    ./tcl/forums-procs.tcl
    • -8
    • +12
    ./tcl/forums-procs.xql
    • -9
    • +14
    ./tcl/forums-security-procs.tcl