OpenACS / openacs-4 / packages

forums

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 61
Last Commit: 28 Dec 24
Commits this week: 0
Total Lines of Code (LoC): 22,611
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 54 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 16 Nov 2017
1:40 pm

antoniop

Make forum::use_ReadingInfo_p more robust when UseReadingInfo parameter in forums is not set

Options
    • -2
    • +2
    ./lib/forums/forums-chunk.tcl
    • -2
    • +2
    ./lib/message/threads-chunk.tcl
    • -2
    • +2
    ./tcl/forums-procs.tcl
    • -2
    • +2
    ./www/message-view.tcl
12:03 pm

gustafn

make boolean test strict

Options
    • -2
    • +2
    ./lib/forums/forums-chunk.tcl
    • -2
    • +2
    ./lib/message/threads-chunk.tcl
    • -2
    • +2
    ./www/message-view.tcl
11:58 am

gustafn

Hot fix for latest changes concerning reading info

Options
    • -2
    • +2
    ./lib/forums/forums-chunk.tcl
    • -2
    • +2
    ./lib/message/threads-chunk.tcl
    • -2
    • +2
    ./www/message-view.tcl
Monday 13 Nov 2017
4:35 pm

antoniop

Fix typo

Options
    • -3
    • +3
    ./www/moderate/move.tcl
    • -1
    • +1
    ./www/moderate/move.xql
4:22 pm

antoniop

Port downstream only usage of reading info api

Also fix such api so that root message is retrieved for every given source message

Options
    • -2
    • +2
    ./forums.info
    • -5
    • +16
    ./sql/oracle/forums-reading-info-package-create.sql
    • -0
    • +163
    ./sql/oracle/upgrade/upgrade-1.3.1d3-1.3.1d4.sql
    • -2
    • +6
    ./sql/postgresql/forums-reading-info-create.sql
    • -0
    • +34
    ./sql/postgresql/upgrade/upgrade-1.3.1d3-1.3.1d4.sql
    • -1
    • +9
    ./www/moderate/move-thread-oracle.xql
    • -0
    • +8
    ./www/moderate/move-thread-postgresql.xql
    • -0
    • +5
    ./www/moderate/move-thread.tcl
3:31 pm

antoniop

Converge downstream reading_info feature with upstream

Port downstream only idiom to update reading_info table

Make more use of api when retrieving forum and message information

Optimize message existance query

Options
    • -10
    • +25
    ./www/moderate/move.tcl
    • -20
    • +14
    ./www/moderate/move.xql
1:52 pm

antoniop

Fix sql update to populate new forum_id column in existing data

Options
    • -3
    • +9
    ./sql/oracle/upgrade/upgrade-1.3.1d2-1.3.1d3.sql
    • -4
    • +9
    ./sql/postgresql/upgrade/upgrade-1.3.1d2-1.3.1d3.sql
Friday 10 Nov 2017
6:21 pm

antoniop

Maintenance of forum reading count feature

- removal of forums_reading_info_user (1Mio rows on Learn@WU).

This materialized view had to be constantly synced with

forums_reading_info table. Reimplemented as view.

- simplify logics in stored procedure due to new datamodel

- fix inconsistencies between oracle and postgres function definition

- re-enabled parameter to decide whether use these stats or not in

administration

TODO: consider further reform of this feature as stats grow very

large on busy sites for probably little value added

Options
    • -2
    • +2
    ./forums.info
    • -17
    • +10
    ./sql/oracle/forums-reading-info-create.sql
    • -3
    • +3
    ./sql/oracle/forums-reading-info-drop.sql
    • -143
    • +5
    ./sql/oracle/forums-reading-info-package-create.sql
    • -0
    • +186
    ./sql/oracle/upgrade/upgrade-1.3.1d2-1.3.1d3.sql
    • -195
    • +68
    ./sql/postgresql/forums-reading-info-create.sql
    • -9
    • +4
    ./sql/postgresql/forums-reading-info-drop.sql
    • -0
    • +173
    ./sql/postgresql/upgrade/upgrade-1.3.1d2-1.3.1d3.sql
    • -5
    • +2
    ./tcl/forums-procs.tcl
Thursday 09 Nov 2017
6:28 pm

antoniop

Remove deprecated idioms and unneded queries

Options
    • -8
    • +0
    ./lib/message/post-oracle.xql
    • -8
    • +0
    ./lib/message/post-postgresql.xql
    • -14
    • +13
    ./lib/message/post.tcl
    • -13
    • +0
    ./lib/message/post.xql
Wednesday 08 Nov 2017
1:05 pm

antoniop

Implement post anonymously through explicit forum attribute in table

Now moderators can explicitly decide whether a forum will enable posting anonymously or not.

Forum must be in a policy different from closed and the anonymous flag must be set accordingly for this to happen.

Also:

- normalize api in a way it can accomodate all current attributes. In particular,

now edit api will now leave every unspecified attribute unchanged, instead of

setting it to some default.

- fix some usability issues when managing forum parameters (e.g. values not

retrieved in form when editing existing forum)

- introduce missing Oracle upgrade script for the whole forum reform

- fix oracle creation script

Options
    • -2
    • +2
    ./forums.info
    • -22
    • +32
    ./lib/forums/edit.tcl
    • -18
    • +18
    ./lib/forums/new.tcl
    • -1
    • +7
    ./sql/oracle/forums-forums-create.sql
    • -0
    • +27
    ./sql/oracle/upgrade/upgrade-1.3.1d1-1.3.1d2.sql
    • -0
    • +3
    ./sql/postgresql/forums-forums-create.sql
    • -0
    • +13
    ./sql/postgresql/upgrade/upgrade-1.3.1d1-1.3.1d2.sql
    • -2
    • +8
    ./tcl/form-procs.tcl
    • -7
    • +27
    ./tcl/forums-procs.tcl
    • -8
    • +12
    ./tcl/forums-procs.xql
    • -9
    • +14
    ./tcl/forums-security-procs.tcl
Friday 13 Oct 2017
11:39 am

antoniop

Don't go all the way when user provides an invalid parent post to reply to

Options
    • -8
    • +7
    ./www/message-post.tcl
Wednesday 11 Oct 2017
6:20 pm

antoniop

Assume moderators have always the right to post

Options
    • -1
    • +5
    ./tcl/forums-security-procs.tcl
6:07 pm

antoniop

Let admins post in every situation

Options
    • -7
    • +11
    ./www/message-post.tcl
2:04 pm

gustafn

Normalize boolean expressions in .adp code

Options
    • -3
    • +3
    ./lib/forums/forums-chunk.tcl
  2. … 4 more files in changeset.
1:04 pm

gustafn

Normalize boolean expressions in .adp files

Options
    • -2
    • +2
    ./lib/message/threads-chunk.tcl
12:14 pm

gustafn

normalize boolean expressions in .adp files

Options
    • -1
    • +1
    ./lib/forums/forums-history-chunk.tcl
    • -1
    • +1
    ./lib/message/row.adp
Sunday 01 Oct 2017
2:09 pm

gustafn

Bug fix: avoid confusion between command argument and option, when argument starts with "-"

Options
    • -2
    • +2
    ./lib/message/threads-chunk.tcl
  2. … 81 more files in changeset.
Wednesday 27 Sep 2017
7:05 pm

antoniop

Don't tamper with permissions to remember whether we should be able to moderate or not

Options
    • -6
    • +1
    ./www/forum-view.tcl
7:01 pm

antoniop

Show moderate button only when forum is actually moderated

check truth by lean and mean tcl idiom

Options
    • -5
    • +5
    ./lib/message/threads-chunk.tcl
5:39 pm

antoniop

Ehm, fix missed occurrency of message level permission check

Options
    • -3
    • +3
    ./www/moderate/move-thread.tcl
5:33 pm

antoniop

Fix typo in deprecated proc (not used upstream anymore)

Options
    • -2
    • +2
    ./tcl/forums-security-procs.tcl
2:28 pm

trenner

reuse forum properties

Options
    • -3
    • +11
    ./tcl/forums-procs.tcl
1:07 pm

antoniop

Forum reform

- remove hardcoded dependency with registered_users group. Target is to improve suitability in convoluted multi groups/multi subsites context

- in place of previous permission-based machinery, use plain table columns to detect whether user can or cannot post replies/new threads

- remove permission check at the message level in favor of that on forum level

Options
    • -2
    • +2
    ./forums.info
    • -4
    • +1
    ./lib/forums/edit.tcl
    • -4
    • +1
    ./lib/forums/new.tcl
    • -2
    • +2
    ./lib/message/post.tcl
    • -9
    • +4
    ./lib/message/threads-chunk.tcl
    • -0
    • +6
    ./sql/oracle/forums-forums-create.sql
    • -0
    • +18
    ./sql/oracle/upgrade/upgrade-1.3-1.3d1.sql
    • -0
    • +3
    ./sql/postgresql/forums-forums-create.sql
    • -0
    • +13
    ./sql/postgresql/upgrade/upgrade-1.3-1.3.1d1.sql
    • -36
    • +37
    ./tcl/forums-procs.tcl
    • -74
    • +62
    ./tcl/forums-security-procs.tcl
    • -3
    • +2
    ./www/message-email.tcl
    • -4
    • +8
    ./www/message-post.tcl
    • -20
    • +2
    ./www/message-view.tcl
    • -2
    • +3
    ./www/moderate/message-approve.tcl
  16. … 7 more files in changeset.
Tuesday 19 Sep 2017
12:47 pm

antoniop

Use full <if @foo_p@ true> instead of undocumented shortcut idiom <if @foo_p@>

Options
    • -1
    • +1
    ./lib/forums/forums-history-chunk.tcl
  2. … 1 more file in changeset.
Friday 15 Sep 2017
9:13 am

gustafn

normalize boolean expressions in ADP files

Options
    • -3
    • +3
    ./lib/forums/forums-chunk.tcl
  2. … 14 more files in changeset.
8:58 am

gustafn

normalize boolean expressions in ADP files

Options
    • -2
    • +2
    ./lib/forums/admin-forums-chunk.tcl
    • -3
    • +3
    ./lib/forums/forums-chunk.tcl
    • -3
    • +3
    ./lib/message/threads-chunk.tcl
  4. … 8 more files in changeset.
Saturday 19 Aug 2017
7:08 pm

gustafn

set the displayed_object_id to the forum_id for edit operations

Options
    • -0
    • +2
    ./lib/message/post.adp
    • -0
    • +1
    ./www/message-post.adp
Tuesday 08 Aug 2017
1:47 am

gustafn

merged changes from the oacs-5-9 branch and resolved conflicts

Options
    • -9
    • +9
    ./forums.info
    • -2
    • +54
    ./catalog/forums.de_DE.ISO-8859-1.xml
    • -5
    • +8
    ./catalog/forums.es_ES.ISO-8859-1.xml
    • -7
    • +90
    ./catalog/forums.it_IT.ISO-8859-1.xml
    • -4
    • +10
    ./lib/forums-portlet.tcl
    • -5
    • +10
    ./lib/forums/admin-forums-chunk.tcl
    • -1
    • +7
    ./lib/forums/edit.tcl
    • -1
    • +7
    ./lib/forums/forums-chunk.tcl
    • -1
    • +1
    ./lib/forums/forums-history-chunk.adp
    • -0
    • +6
    ./lib/forums/forums-history-chunk.tcl
    • -1
    • +7
    ./lib/forums/new.tcl
    • -1
    • +7
    ./lib/message/attachment-list.tcl
    • -1
    • +7
    ./lib/message/choose-forum-move.tcl
    • -3
    • +9
    ./lib/message/choose-message-move.tcl
    • -1
    • +7
    ./lib/message/choose-thread-move.tcl
  16. … 7820 more files in changeset.
Sunday 06 Aug 2017
1:17 pm

gustafn

- do not depend on beta or development versions

- make sure that released versions are not beta or development

- align version numbers (e.g. use also 5.9.1 for xotcl-core)

- bump version numbers to 5.9.1

Options
    • -9
    • +9
    ./forums.info
  2. … 83 more files in changeset.
Saturday 29 Jul 2017
11:47 am

gustafn

Reduce number of URLs leading to a validation error (user-history with no user_id)

Options
    • -1
    • +3
    ./lib/message/threads-chunk.tcl