OpenACS / openacs-4 / packages

forums

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 61
Last Commit: 11:00
Commits this week: 0
Total Lines of Code (LoC): 21,951
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 10 Jul 2018
12:32 pm

antoniop

Deprecate (former) service contract implementations

Their body was always empty according to the cvs history and there is no mention of them in the code.

Their counterpart in the forum::notification namespace takes care of both forums and messages, therefore supersedes them.

Options
    • -5
    • +15
    ./tcl/forum-message-reply-procs.tcl
12:20 pm

antoniop

Clearly separate callback hooks from callback implementations, uniform documentation style, remove duplicated callback implementation definitions, uniform indentation, add documentation to public procs (fixes automated tests)

Options
    • -155
    • +111
    ./tcl/forums-callback-procs.tcl
12:03 pm

antoniop

Add documentation to public procs (fixes automated tests)

Options
    • -9
    • +5
    ./tcl/forum-message-reply-procs.tcl
11:54 am

antoniop

Uniform documentation style

Options
    • -16
    • +16
    ./tcl/messages-procs.tcl
Monday 09 Jul 2018
2:31 pm

antoniop

Set package_id explicitly as the main subsite package, as ad_conn package_id could not be properly initialized for tests when a system was freshly restarted

Options
    • -5
    • +11
    ./tcl/test/forums-procs.tcl
11:20 am

antoniop

Put cache flushing logics into procs and use them when forum info needs to be updated (fixes automated tests)

Options
    • -2
    • +19
    ./tcl/forums-procs.tcl
    • -6
    • +16
    ./tcl/messages-procs.tcl
10:56 am

antoniop

Add documentation and a fallback body for this deprecated proc

Options
    • -2
    • +11
    ./tcl/forums-procs.tcl
Thursday 28 Jun 2018
5:27 pm

hectorr

Provide a minimal documentation to public procs

Options
    • -4
    • +18
    ./tcl/forums-procs.tcl
    • -1
    • +9
    ./tcl/forums-security-procs.tcl
    • -4
    • +6
    ./tcl/messages-procs.tcl
12:39 pm

hectorr

Prefer 'person::name' to 'acs_user::get_element ... -name'

Options
    • -1
    • +1
    ./lib/forums/forums-history-chunk.tcl
  2. … 8 more files in changeset.
11:44 am

antoniop

Remove hotfix and exploit new api, that won't fail on the guest user

Options
    • -11
    • +5
    ./tcl/messages-procs.tcl
10:26 am

antoniop

Use finer grained person:: api to retrieve the name

Options
    • -1
    • +1
    ./www/user-history.adp
    • -5
    • +3
    ./www/user-history.tcl
10:18 am

antoniop

Use new fine grained api for the screen name

Options
    • -8
    • +5
    ./lib/user/post-history-chunk.tcl
Wednesday 27 Jun 2018
7:17 pm

antoniop

Remove hotfix and use new user api

Options
    • -11
    • +5
    ./lib/message/threads-chunk.tcl
7:09 pm

antoniop

Remove user hotfix and replace with new api (which won't fail for non-registered users)

Options
    • -9
    • +3
    ./lib/message/post.tcl
Tuesday 26 Jun 2018
4:21 pm

antoniop

Flush templating cache also when approving a message, as this might be a new root message (thread) and therefore thread list should be rebuilt

Options
    • -1
    • +3
    ./www/moderate/message-approve.tcl
12:39 pm

antoniop

Re-estate query variable, as programs around expect it

Options
    • -3
    • +4
    ./lib/search/search-chunk.tcl
Monday 25 Jun 2018
2:44 pm

hectorr

Fix typos

Options
    • -1
    • +1
    ./catalog/forums.de_DE.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/forums.en_US.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/forums.es_ES.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/forums.it_IT.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/forums.ru_RU.utf-8.xml
    • -1
    • +1
    ./lib/message/post.adp
1:07 pm

gustafn

fix diacrytical characters in german messages

Options
    • -6
    • +6
    ./catalog/forums.de_DE.ISO-8859-1.xml
11:26 am

antoniop

Fix regression when checking if user can anonimously post

Options
    • -2
    • +2
    ./tcl/forums-security-procs.tcl
11:15 am

antoniop

Fix regressions in forums when user is not logged in

Options
    • -7
    • +23
    ./lib/forums/forums-history-chunk.tcl
    • -3
    • +8
    ./lib/message/post.tcl
    • -2
    • +3
    ./lib/message/row.adp
    • -4
    • +10
    ./lib/message/row.tcl
    • -8
    • +13
    ./lib/message/threads-chunk.tcl
    • -5
    • +11
    ./tcl/messages-procs.tcl
Monday 18 Jun 2018
4:22 pm

antoniop

Disambiguate table reference in subquery

Options
    • -13
    • +13
    ./tcl/messages-procs-oracle.xql
    • -13
    • +13
    ./tcl/messages-procs-postgresql.xql
Friday 15 Jun 2018
10:55 pm

antoniop

Avoid two times the same query just because we might filter by forum

Options
    • -20
    • +2
    ./lib/search/search-chunk-oracle.xql
    • -20
    • +2
    ./lib/search/search-chunk-postgresql.xql
    • -12
    • +10
    ./lib/search/search-chunk.tcl
10:50 pm

antoniop

Pass user_name through the message array, as message-view expects it there

Options
    • -2
    • +2
    ./lib/message/row.adp
    • -4
    • +4
    ./lib/message/row.tcl
10:26 pm

antoniop

This obscure script doesn't do much (basically, displays the content of a message), but nevertheless was passing arrays, defining queries, duplicating code... streamlined to the bones

Options
    • -46
    • +0
    ./lib/message/content-updater-oracle.xql
    • -51
    • +0
    ./lib/message/content-updater-postgresql.xql
    • -8
    • +0
    ./lib/message/content-updater.adp
    • -45
    • +0
    ./lib/message/content-updater.tcl
    • -4
    • +1
    ./www/load-message-content.adp
    • -3
    • +9
    ./www/load-message-content.tcl
9:59 pm

antoniop

Remove redundant variables, dead code and bring variables closer to where they are actually used... still room for improvement here

Options
    • -3
    • +8
    ./lib/message/row.adp
    • -16
    • +5
    ./lib/message/row.tcl
    • -2
    • +0
    ./lib/message/thread-chunk-oracle.xql
    • -10
    • +4
    ./lib/message/thread-chunk-postgresql.xql
    • -19
    • +15
    ./lib/message/thread-chunk.tcl
6:46 pm

antoniop

Use more api to streamline queries and reduce divergency between oracle and postgres codebase

Options
    • -22
    • +4
    ./tcl/messages-procs-oracle.xql
    • -28
    • +6
    ./tcl/messages-procs-postgresql.xql
    • -7
    • +22
    ./tcl/messages-procs.tcl
Tuesday 12 Jun 2018
12:04 am

gustafn

move template cacheing function "cache" into template namespace (resulting in template::cache)

Options
    • -2
    • +2
    ./tcl/forums-procs.tcl
  2. … 2 more files in changeset.
Monday 11 Jun 2018
4:31 pm

antoniop

Reduce divergencies between oracle and postgres codebase, reduce the need for joins and stored procedures

Options
    • -41
    • +0
    ./lib/message/threads-chunk-oracle.xql
    • -41
    • +0
    ./lib/message/threads-chunk-postgresql.xql
    • -5
    • +12
    ./lib/message/threads-chunk.tcl
    • -6
    • +24
    ./lib/message/threads-chunk.xql
4:04 pm

antoniop

Centralize templating cache "black magic"

Use the new proc into forum api

Options
    • -5
    • +1
    ./lib/message/post.tcl
    • -4
    • +21
    ./tcl/forums-procs.tcl
Thursday 07 Jun 2018
8:08 pm

hectorr

Replace deprecated 'forum::security::can_moderate_forum_p' by 'permission::permission_p'

Options
    • -21
    • +21
    ./lib/message/post.tcl
    • -8
    • +16
    ./tcl/forums-security-procs.tcl
    • -6
    • +6
    ./www/message-post.tcl