• last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Use finer grained person:: api to retrieve the name

Use new fine grained api for the screen name

Remove hotfix and use new user api

Remove user hotfix and replace with new api (which won't fail for non-registered users)

Flush templating cache also when approving a message, as this might be a new root message (thread) and therefore thread list should be rebuilt

Re-estate query variable, as programs around expect it

Fix typos

fix diacrytical characters in german messages

Fix regression when checking if user can anonimously post

Fix regressions in forums when user is not logged in

    • -7
    • +23
    ./lib/forums/forums-history-chunk.tcl
Disambiguate table reference in subquery

    • -13
    • +13
    ./tcl/messages-procs-postgresql.xql
Avoid two times the same query just because we might filter by forum

    • -20
    • +2
    ./lib/search/search-chunk-oracle.xql
    • -20
    • +2
    ./lib/search/search-chunk-postgresql.xql
Pass user_name through the message array, as message-view expects it there

This obscure script doesn't do much (basically, displays the content of a message), but nevertheless was passing arrays, defining queries, duplicating code... streamlined to the bones

    • -46
    • +0
    ./lib/message/content-updater-oracle.xql
Remove redundant variables, dead code and bring variables closer to where they are actually used... still room for improvement here

    • -10
    • +4
    ./lib/message/thread-chunk-postgresql.xql
Use more api to streamline queries and reduce divergency between oracle and postgres codebase

    • -28
    • +6
    ./tcl/messages-procs-postgresql.xql
move template cacheing function "cache" into template namespace (resulting in template::cache)

  1. … 2 more files in changeset.
Reduce divergencies between oracle and postgres codebase, reduce the need for joins and stored procedures

    • -41
    • +0
    ./lib/message/threads-chunk-oracle.xql
    • -41
    • +0
    ./lib/message/threads-chunk-postgresql.xql
Centralize templating cache "black magic"

Use the new proc into forum api

Replace deprecated 'forum::security::can_moderate_forum_p' by 'permission::permission_p'

Replace deprecated 'can_read_forum_p' by 'permission::permission_p'

Replace deprecated procs with 'permission::require_permission'

    • -14
    • +14
    ./www/admin/subscribe-others-2.tcl
  1. … 3 more files in changeset.
Deprecate wrappers for 'permission::permission_p' and permission::require_permission.

  1. … 4 more files in changeset.
Create 'ad_include_contract' for forums portlet

Prefer literal in adp expressions + Whitespace changes

  1. … 6 more files in changeset.
Exploit users cache, simplify SQL

    • -2
    • +16
    ./lib/forums/forums-history-chunk.tcl
    • -12
    • +0
    ./lib/forums/forums-history-chunk.xql
Shorten expression, exploit cache

use more consistent spelling of names

Prefer individual 'set' operations over 'lassign' in these particular cases

  1. … 6 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 473 more files in changeset.