OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 14
Total Committers: 73
Last Commit: 20:00
Commits this week: 14
Total Lines of Code (LoC): 74,843
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 49 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 20 Aug
3:58 pm

gustafn

Fix potential problems when calling polymorphic SQL functions from Tcl

Some functions are defined in the database with the same number of

arguments but different types, e.g., first argument "package_key"

(type text) or "package_id" (type integer). This is fine from the SQL

standpoint, but when calling from Tcl via bind-vars

(e.g. ":package_id"), everything is passed as a string, and

potentially, the wrong function is called.

Now, all the automatically generated subs are generated with casts,

when the integer based variant must be called.

Some examples:

Before:

set s [ns_pg_bind 0or1row $__DB {select apm__set_value(:package_id,:parameter_name,:attr_value)}]

set s [ns_pg_bind 0or1row $__DB {select apm__get_value(:package_id,:parameter_name)}]

Now:

set s [ns_pg_bind 0or1row $__DB {select apm__set_value(CAST(:package_id AS integer),:parameter_name,:attr_value)}]

set s [ns_pg_bind 0or1row $__DB {select apm__get_value(CAST(:package_id AS integer),:parameter_name)}]

- bumped version number to 5.10.1b11

Options
    • -3
    • +3
    ./acs-tcl.info
    • -13
    • +110
    ./tcl/acs-db-12-procs.tcl
    • -2
    • +2
    ./tcl/utilities-procs.tcl
11:36 am

gustafn

fixed resource leak

Options
    • -45
    • +45
    ./tcl/test/acs-tcl-test-procs.tcl
11:30 am

gustafn

reduced verbosity

Options
    • -2
    • +2
    ./tcl/acs-cache-procs.tcl
10:41 am

antoniop

Make localurl filter more robust to invalid URLs: fail validation in this case, intead of crashing

Options
    • -5
    • +9
    ./tcl/tcl-documentation-procs.tcl
10:14 am

gustafn

fixed resource leaks

dom trees were not deleted

Options
    • -4
    • +6
    ./tcl/test/http-client-procs.tcl
9:53 am

gustafn

ad_dom_sanitize_html: fixed 2 resource leaks

in case of parsing errors in the input string the following structures leaked:

- dom tree

- stuct::tree

Options
    • -38
    • +42
    ./tcl/text-html-procs.tcl
8:59 am

gustafn

make sure to delete tdom document

Delete nodes explicitly, otherwise it survives the end of the proc.

Options
    • -2
    • +5
    ./tcl/json-procs.tcl
Monday 19 Aug
3:42 pm

gustafn

fixed icanuse-test for deleting samesite cookies

Options
    • -1
    • +1
    ./tcl/00-icanuse-procs.tcl
Saturday 17 Aug
7:07 pm

gustafn

More resource-info updates:

- fixed wrong and inconsistent naming of dict members (many thanks to Sebastian Scheder for figuring this out)

- removed duplicated slashes in resource paths

- fixed incorrect paths when CDN is used

- simplified handling of cspMaps

- added test checking consistency of resource-info dicts

Options
    • -10
    • +10
    ./tcl/utilities-procs.tcl
    • -0
    • +52
    ./tcl/test/resource-info-procs.tcl
  3. … 9 more files in changeset.
7:07 pm

gustafn

file resource-info-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/resource-info-procs.tcl
Friday 16 Aug
2:50 pm

gustafn

fix for regression test case ad_context_bar_multirow

originally, site-node entries survived the test

after the first fix, the regression test was failing (sometimes?) the complaint was about a missing package.

now, the test seems to work always correctyl, and the site-nodes entries are gone as well

Options
    • -2
    • +2
    ./tcl/test/navigation-procs.tcl
9:01 am

antoniop

Fix regression in db_multirow_group_last_row_p

Row is last when the next value changes

Many thanks to Miachel Aram for reporting the issue

Options
    • -2
    • +2
    ./tcl/01-database-procs.tcl
Wednesday 14 Aug
1:57 pm

trenner

fix typo

Options
    • -2
    • +2
    ./tcl/defs-procs.tcl
Tuesday 13 Aug
4:33 pm

gustafn

::util::resources::resource_info_procs: function to improve roustness of fetching of resource info procs

bumped version number to 5.10.1b10

Options
    • -2
    • +2
    ./acs-tcl.info
    • -3
    • +43
    ./tcl/utilities-procs.tcl
11:06 am

gustafn

improved souce code documentation

Options
    • -1
    • +7
    ./tcl/acs-db-12-procs.tcl
Monday 12 Aug
3:03 pm

gustafn

added link to snyk advisor (bumped version to 5.10.1b9)

Options
    • -2
    • +2
    ./acs-tcl.info
    • -1
    • +2
    ./lib/check-installed.adp
    • -0
    • +1
    ./lib/check-installed.tcl
    • -2
    • +6
    ./tcl/utilities-procs.tcl
Sunday 11 Aug
8:22 am

gustafn

Further simplify handling of resource_info specs

- Added convenience function "::util::resources::register_urns" to

register all URNs with CSP handling provided by a package (denoted

by its top level namespace)

- made parameter "version" in "check-installed" include optional

- bumped version number to 5.10.1b8

Options
    • -2
    • +2
    ./acs-tcl.info
    • -0
    • +3
    ./lib/check-installed.tcl
    • -1
    • +25
    ./tcl/utilities-procs.tcl
Saturday 10 Aug
4:47 pm

gustafn

reduced verbosity in the system log, provide hint to message

Options
    • -2
    • +14
    ./tcl/01-database-procs.tcl
Thursday 08 Aug
4:30 pm

gustafn

Fixed issue in cluster mode, denoted by Khy H in the OpenACS forum

A new command "ad_parameter_cache_flush_dict" was introduced to handle

the case, where a cluster node modifies a parameter value without

having it read before. This case could lead to a coherency problem for

parameter values.

Background:

This proc is necessary in cases, where a node writes a new

parameter value before it has read the old one.

Since a plain "nsv_dict unset ad_param $key $parameter_name"

raises an exception, when the pair does not exist, and we do

not want to allow in cluster requests arbitrary "catch"

commands, we allow "ad_parameter_cache_flush_dict" instead.

Probably, the best solution is to add support for

nsv_dict unset -nocomplain -- ad_param $key $parameter_nam

The existing nsv_dict was built after Tcl's "dict unset",

which does not have the "-nocomplain" option either. However,

an atomic operation would certainly be preferable over an exists/unset

pair, which is no acceptable solution.

For details, see https://openacs.org/forums/message-view?message_id=5822470

Options
    • -4
    • +5
    ./tcl/cluster-procs.tcl
    • -4
    • +29
    ./tcl/defs-procs.tcl
Wednesday 07 Aug
4:23 pm

gustafn

perform proper cleanup after regressin test

Options
    • -4
    • +6
    ./tcl/test/navigation-procs.tcl
11:56 am

gustafn

Prettify subsite admin page

- Made explicit that "Administration" means "Subsite Administration"

(use the term consistently)

- Changed message key of acs-subsite.administration to "Subsite Administration"

- added icons to subsite admin index page (full set only for bootstrap icons)

Options
    • -7
    • +16
    ./tcl/navigation-procs.tcl
  2. … 8 more files in changeset.
11:34 am

gustafn

use tag <i> for technical terms as on other places

Options
    • -2
    • +2
    ./lib/check-installed.adp
Tuesday 06 Aug
7:25 pm

gustafn

fix over-eager renaming

Options
    • -2
    • +2
    ./tcl/defs-procs.tcl
11:43 am

gustafn

spell "site-wide" consistently with a dash

Options
    • -2
    • +2
    ./tcl/community-core-procs.tcl
    • -2
    • +2
    ./tcl/defs-procs.tcl
  3. … 33 more files in changeset.
10:38 am

gustafn

improved the site-wide admin pages for external ja libraries

- add a sample for pinning the version number via the NaviServer configuration file

- privide a link to the requirements and background page explaining the implemented policies

Options
    • -4
    • +18
    ./lib/check-installed.adp
Monday 05 Aug
4:42 pm

gustafn

factored out vulerability check to make it reusable

- New proc ::util::resources::check_vulnerability

- bumped verison number to 5.10.1b7

Options
    • -2
    • +2
    ./acs-tcl.info
    • -4
    • +8
    ./lib/check-installed.adp
    • -16
    • +9
    ./lib/check-installed.tcl
    • -1
    • +40
    ./tcl/utilities-procs.tcl
Thursday 01 Aug
2:35 pm

gustafn

added titles for the action URLs to guide the user

Options
    • -4
    • +8
    ./lib/check-installed.adp
    • -0
    • +1
    ./lib/check-installed.tcl
Tuesday 30 Jul
8:03 pm

gustafn

Let site-wide admin pages of external js pages modify, create and delete package parameters

The real change escaped with the previous commit.

Options
    • -0
    • +6
    ./lib/check-installed.tcl
7:53 pm

gustafn

improved spelling

Options
    • -2
    • +7
    ./lib/check-installed.adp
    • -8
    • +32
    ./lib/check-installed.tcl
    • -2
    • +2
    ./tcl/json-procs.tcl
    • -2
    • +2
    ./tcl/utilities-procs.tcl
  5. … 1 more file in changeset.
7:49 pm

gustafn

added comment

Options
    • -1
    • +8
    ./tcl/utilities-procs.tcl