OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 14
Total Committers: 73
Last Commit: 20:00
Commits this week: 14
Total Lines of Code (LoC): 74,843
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 47 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 08 Aug
4:30 pm

gustafn

Fixed issue in cluster mode, denoted by Khy H in the OpenACS forum

A new command "ad_parameter_cache_flush_dict" was introduced to handle

the case, where a cluster node modifies a parameter value without

having it read before. This case could lead to a coherency problem for

parameter values.

Background:

This proc is necessary in cases, where a node writes a new

parameter value before it has read the old one.

Since a plain "nsv_dict unset ad_param $key $parameter_name"

raises an exception, when the pair does not exist, and we do

not want to allow in cluster requests arbitrary "catch"

commands, we allow "ad_parameter_cache_flush_dict" instead.

Probably, the best solution is to add support for

nsv_dict unset -nocomplain -- ad_param $key $parameter_nam

The existing nsv_dict was built after Tcl's "dict unset",

which does not have the "-nocomplain" option either. However,

an atomic operation would certainly be preferable over an exists/unset

pair, which is no acceptable solution.

For details, see https://openacs.org/forums/message-view?message_id=5822470

Options
    • -4
    • +5
    ./tcl/cluster-procs.tcl
    • -4
    • +29
    ./tcl/defs-procs.tcl
Wednesday 07 Aug
4:23 pm

gustafn

perform proper cleanup after regressin test

Options
    • -4
    • +6
    ./tcl/test/navigation-procs.tcl
11:56 am

gustafn

Prettify subsite admin page

- Made explicit that "Administration" means "Subsite Administration"

(use the term consistently)

- Changed message key of acs-subsite.administration to "Subsite Administration"

- added icons to subsite admin index page (full set only for bootstrap icons)

Options
    • -7
    • +16
    ./tcl/navigation-procs.tcl
  2. … 8 more files in changeset.
11:34 am

gustafn

use tag <i> for technical terms as on other places

Options
    • -2
    • +2
    ./lib/check-installed.adp
Tuesday 06 Aug
7:25 pm

gustafn

fix over-eager renaming

Options
    • -2
    • +2
    ./tcl/defs-procs.tcl
11:43 am

gustafn

spell "site-wide" consistently with a dash

Options
    • -2
    • +2
    ./tcl/community-core-procs.tcl
    • -2
    • +2
    ./tcl/defs-procs.tcl
  3. … 33 more files in changeset.
10:38 am

gustafn

improved the site-wide admin pages for external ja libraries

- add a sample for pinning the version number via the NaviServer configuration file

- privide a link to the requirements and background page explaining the implemented policies

Options
    • -4
    • +18
    ./lib/check-installed.adp
Monday 05 Aug
4:42 pm

gustafn

factored out vulerability check to make it reusable

- New proc ::util::resources::check_vulnerability

- bumped verison number to 5.10.1b7

Options
    • -2
    • +2
    ./acs-tcl.info
    • -4
    • +8
    ./lib/check-installed.adp
    • -16
    • +9
    ./lib/check-installed.tcl
    • -1
    • +40
    ./tcl/utilities-procs.tcl
Thursday 01 Aug
2:35 pm

gustafn

added titles for the action URLs to guide the user

Options
    • -4
    • +8
    ./lib/check-installed.adp
    • -0
    • +1
    ./lib/check-installed.tcl
Tuesday 30 Jul
8:03 pm

gustafn

Let site-wide admin pages of external js pages modify, create and delete package parameters

The real change escaped with the previous commit.

Options
    • -0
    • +6
    ./lib/check-installed.tcl
7:53 pm

gustafn

improved spelling

Options
    • -2
    • +7
    ./lib/check-installed.adp
    • -8
    • +32
    ./lib/check-installed.tcl
    • -2
    • +2
    ./tcl/json-procs.tcl
    • -2
    • +2
    ./tcl/utilities-procs.tcl
  5. … 1 more file in changeset.
7:49 pm

gustafn

added comment

Options
    • -1
    • +8
    ./tcl/utilities-procs.tcl
1:27 pm

antoniop

Use ns_parseurl to validate the URL and to determine the hostname

Options
    • -5
    • +7
    ./tcl/http-client-procs.tcl
1:22 pm

antoniop

Latest released NaviServer still requires for servers using SNI that the -hostname flag is specified with ns_http, while it seems that in latest code we can omit it

The wrapper utility already takes care of this

Options
    • -3
    • +3
    ./tcl/utilities-procs.tcl
12:25 pm

gustafn

Ease management of external js packages to automate admin tasks

- provide explicit information about optional package paramters

- make these accessible from site-wide admin pages

- provide information, how the configuration of the version number happend

- improve design of site-wide admin pages with action items

- further streamlined handling of external js packages

Options
    • -8
    • +16
    ./lib/check-installed.adp
    • -3
    • +39
    ./lib/check-installed.tcl
    • -3
    • +4
    ./tcl/utilities-procs.tcl
  4. … 16 more files in changeset.
Monday 29 Jul
4:00 pm

gustafn

renamed misnomer "ad_parameter_from_file"

- removed hints on "*.ini" files

- provided a name that points to the configuration file ("ad_parameter_from_configuration_file")

- deprecated old name

- updated documentation with examples

Options
    • -8
    • +35
    ./tcl/defs-procs.tcl
    • -5
    • +5
    ./tcl/parameter-procs.tcl
    • -1
    • +1
    ./tcl/test/apm-parameter-test-procs.tcl
    • -4
    • +4
    ./tcl/test/defs-procs.tcl
2:01 pm

gustafn

js-libraries: improved naming of variables

Changed name "installedVersion" to "configuredVersion", since

the former might lead to the impression, that it refers only

to the locally installed version. Instead, this refers as well

to a CDN version (when available)

Options
    • -14
    • +14
    ./tcl/utilities-procs.tcl
  2. … 18 more files in changeset.
1:56 pm

gustafn

reduced verbosity

Options
    • -1
    • +1
    ./lib/check-installed.tcl
Sunday 28 Jul
7:41 pm

gustafn

js-libraries: removed variable "resourceUrl"

The variable "resourceUrl" was always used in a single branch but set

for all branches before. To ease maintenance and simplify

comprehension, it was removed.

Options
    • -2
    • +1
    ./tcl/utilities-procs.tcl
  2. … 10 more files in changeset.
7:08 pm

gustafn

tdom: "dom parse -html" implies the "simple" parser

The flag "-simple" is not needed when parsing with the flag "-html". This meanse

that

dom parse -simple -html ...

is equivalent with

dom parse -html ...

Options
    • -2
    • +2
    ./tcl/apm-install-procs.tcl
  2. … 3 more files in changeset.
7:00 pm

gustafn

Always use "--" in "dom parse" when document is interpolated

This is a safety measure to make sure that the document parsed is

never confused with an option, when the document starts with a "-". In

the best case, the error message provided by "dom parse" might be

misleading. This might be a problem for user contributed documents

(passed as variables, or return values from functions).

The double dash is supported in tdom since version 0.9.0.

Options
    • -2
    • +2
    ./tcl/30-xml-utils-procs.tcl
    • -2
    • +2
    ./tcl/apm-install-procs.tcl
    • -1
    • +1
    ./tcl/html-procs.tcl
    • -2
    • +2
    ./tcl/text-html-procs.tcl
    • -2
    • +2
    ./tcl/test/http-client-procs.tcl
  6. … 14 more files in changeset.
6:27 pm

gustafn

In essence, this change renames "version_dir" to "version_segment" as

well as "versionDir" to "versionSegment" to reflect the fact, that

this variable does not denote a directory, but a part of the path

appended to path "resourceDir".

Options
    • -4
    • +4
    ./lib/check-installed.tcl
    • -27
    • +27
    ./tcl/utilities-procs.tcl
  3. … 3 more files in changeset.
2:15 pm

gustafn

various small fixes for js libraries

- fixed page contract in case a non-default version is downloaded

- provide always an argument "-version" to resource_info procs

- obtain current version number always via resource_info.installedVersion

(it refers to CDN and locally installed version)

- pass always versionDir via resource_info to ::util::resources::download

- always obtain version_dir from resource_info

Options
    • -4
    • +1
    ./lib/check-installed.tcl
    • -25
    • +19
    ./tcl/utilities-procs.tcl
  3. … 24 more files in changeset.
1:57 pm

gustafn

add "--" to separate argument list from potentially confusing (and externaly provided) content

Options
    • -2
    • +2
    ./tcl/json-procs.tcl
Friday 26 Jul
12:00 pm

gustafn

added handling of literal object "arraycontainer"

Options
    • -6
    • +5
    ./tcl/json-procs.tcl
    • -0
    • +8
    ./tcl/test/json-test-procs.tcl
Thursday 25 Jul
4:24 pm

gustafn

Improved resource information for external libraries

- added vulnerability check for a particular version

- centralized URL generation for cdnjs URLS (will reduce maintenance work, when external URL changes)

- improve behavior when running without an Internet connection

Options
    • -1
    • +6
    ./lib/check-installed.adp
    • -1
    • +39
    ./lib/check-installed.tcl
    • -11
    • +47
    ./tcl/utilities-procs.tcl
  4. … 9 more files in changeset.
3:24 pm

mischa

Fix permission::write_permission_p. Before, the check if the user was the creation_user was always made against the currently logged in user, not the party given by the caller.

Options
    • -6
    • +9
    ./tcl/acs-permissions-procs.tcl
2:50 pm

mischa

Fix default https port in security::configured_driver_info

Options
    • -2
    • +2
    ./tcl/security-procs.tcl
11:19 am

gustafn

Extended json2dict to cover literal objects named "objectcontainer"

Extended regression test as well

Options
    • -13
    • +20
    ./tcl/json-procs.tcl
    • -0
    • +8
    ./tcl/test/json-test-procs.tcl
Wednesday 24 Jul
3:25 pm

gustafn

Include available version number and vulnerability check on swa pages

This eases the use of external JavaScript libraries by adding

the available version number and a link for vulnerability checks

on the site-wide admin pages (when this information is available)

- bumped version number to 5.10.1b6

Options
    • -2
    • +2
    ./acs-tcl.info
    • -3
    • +4
    ./lib/check-installed.adp
    • -5
    • +14
    ./lib/check-installed.tcl
    • -11
    • +54
    ./tcl/utilities-procs.tcl