OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 14
Total Committers: 73
Last Commit: 27 Dec
Commits this week: 14
Total Lines of Code (LoC): 74,843
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 15 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 25 Jul
4:24 pm

gustafn

Improved resource information for external libraries

- added vulnerability check for a particular version

- centralized URL generation for cdnjs URLS (will reduce maintenance work, when external URL changes)

- improve behavior when running without an Internet connection

Options
    • -1
    • +6
    ./lib/check-installed.adp
    • -1
    • +39
    ./lib/check-installed.tcl
    • -11
    • +47
    ./tcl/utilities-procs.tcl
  4. … 9 more files in changeset.
3:24 pm

mischa

Fix permission::write_permission_p. Before, the check if the user was the creation_user was always made against the currently logged in user, not the party given by the caller.

Options
    • -6
    • +9
    ./tcl/acs-permissions-procs.tcl
2:50 pm

mischa

Fix default https port in security::configured_driver_info

Options
    • -2
    • +2
    ./tcl/security-procs.tcl
11:19 am

gustafn

Extended json2dict to cover literal objects named "objectcontainer"

Extended regression test as well

Options
    • -13
    • +20
    ./tcl/json-procs.tcl
    • -0
    • +8
    ./tcl/test/json-test-procs.tcl
Wednesday 24 Jul
3:25 pm

gustafn

Include available version number and vulnerability check on swa pages

This eases the use of external JavaScript libraries by adding

the available version number and a link for vulnerability checks

on the site-wide admin pages (when this information is available)

- bumped version number to 5.10.1b6

Options
    • -2
    • +2
    ./acs-tcl.info
    • -3
    • +4
    ./lib/check-installed.adp
    • -5
    • +14
    ./lib/check-installed.tcl
    • -11
    • +54
    ./tcl/utilities-procs.tcl
12:01 pm

gustafn

fix broken variable name

Options
    • -3
    • +3
    ./tcl/tcl-documentation-procs.tcl
11:06 am

gustafn

Do not allow unusual schemas like base64 and json as local URLs

This case was flagged by a vulnerability scan, but at least at the found instance

it was a false positive...

Options
    • -5
    • +9
    ./tcl/tcl-documentation-procs.tcl
10:05 am

gustafn

Extended json2dict to cover arraycontainer

Many thank to Rolf for his feedback!

Options
    • -3
    • +9
    ./tcl/json-procs.tcl
    • -1
    • +8
    ./tcl/test/json-test-procs.tcl
Tuesday 23 Jul
3:38 pm

gustafn

adjust coverage information

Options
    • -2
    • +2
    ./tcl/test/json-test-procs.tcl
3:33 pm

gustafn

Bump version number to 5.10.1b5 such we can depend on new functionality

Options
    • -2
    • +2
    ./acs-tcl.info
3:31 pm

gustafn

new API function: util::json2dict

This function is similar to the tcllib function json::json2dict, but

is based on tDOM and is several times faster.

Options
    • -4
    • +63
    ./tcl/json-procs.tcl
    • -0
    • +34
    ./tcl/test/json-test-procs.tcl
3:31 pm

gustafn

file json-test-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/json-test-procs.tcl
2:50 pm

gustafn

Mode use of new util::resources::version_dir

Options
    • -5
    • +3
    ./lib/check-installed.tcl
2:49 pm

gustafn

Made download helper more modular and added support for a version_API

Options
    • -10
    • +34
    ./tcl/utilities-procs.tcl
2:45 pm

gustafn

whitespace cleanup

Options
    • -2
    • +2
    ./tcl/acs-cache-procs.tcl
2:38 pm

gustafn

Added support for specifying -expires and -timeout with a time unit

Previously, the "integer" constrain avoided this. Now, we rely on the

error messages of NaviServer to handle incorrect values.

Options
    • -3
    • +3
    ./tcl/acs-cache-procs.tcl
Monday 22 Jul
3:41 pm

antoniop

Flush the package_url cache when we mount a new package, as this may be the first time that we instantiate this particular package

Options
    • -3
    • +10
    ./tcl/site-nodes-procs.tcl
Thursday 18 Jul
12:36 pm

gustafn

fixed test server_startup_ok

Previously, the test was returning different results depending on the order of

tests.

While it is in general better to avoid error entries in the log file during

regression test, since these testing expected behavior, while error entries

in the log file should indicated unexpected behavior. However, it is still

a long way to let the regression test run cleanly.

Options
    • -1
    • +1
    ./tcl/test/acs-tcl-test-procs.tcl
  2. … 1 more file in changeset.
12:05 pm

gustafn

Fixed regression test and make more use of "aa_test_start" and "aa_test_end"

This change reduces the errors in the log file a lets run the

regression test (on my site) without reported errors as reported by

acs_kernel__server_startup_ok.

Options
    • -5
    • +10
    ./tcl/apm-xml-procs.tcl
    • -5
    • +9
    ./tcl/text-html-procs.tcl
  3. … 2 more files in changeset.
10:50 am

gustafn

Skip test, when the optional parameter DiskCache is not defined.

Otherwise, the attempt to set the parameter will fail and will output

an error message to the log file.

Options
    • -3
    • +17
    ./tcl/test/acs-cache-procs.tcl
10:45 am

gustafn

Spelling changes

Options
    • -3
    • +3
    ./tcl/test/acs-tcl-test-procs.tcl
10:44 am

gustafn

Provide an API to check/set/clear the state of the regression test

The new calls are:

- aa_test_running_p

- aa_test_start

- aa_test_end

Options
    • -3
    • +3
    ./tcl/security-procs.tcl
  2. … 1 more file in changeset.
9:54 am

antoniop

Claim additional coverage

Options
    • -1
    • +5
    ./tcl/test/text-html-procs.tcl
Wednesday 17 Jul
3:12 pm

antoniop

Extend test suite to check URL protocol validation

Options
    • -0
    • +52
    ./tcl/test/text-html-procs.tcl
2:53 pm

antoniop

Complete the URL earlier, so that protocol-relative URLs can be correctly determined as external or not

Options
    • -7
    • +11
    ./tcl/text-html-procs.tcl
2:52 pm

antoniop

Extend test suite to check behavior validating external URLs

Options
    • -0
    • +63
    ./tcl/test/text-html-procs.tcl
2:34 pm

gustafn

Fixes for regression test: util_http_json_encoding

This change corrects 2 bugs, causing the regression test to fail under certain circumstances:

1) use for test location [::acs::test::url] instead of [ad_url]

The call [::acs::test::url] should be used for all tests in the regression tests and avoids

problems with wrong URLs when running e.g. in a container

2) When running on a setup with self-signed certificates, the curl requests require a "-k"

flag to be passed. Otherwise, the regression test fails.

Options
    • -10
    • +11
    ./tcl/http-client-procs.tcl
    • -4
    • +7
    ./tcl/test/http-client-procs.tcl
2:29 pm

antoniop

Rework URL validation in ad_dom_sanitize_html

We now prefer higher level api to determine:

- if a URL is external

- what protocol should be assumed for a URL when this is relative or protocol-relative

Options
    • -81
    • +38
    ./tcl/text-html-procs.tcl
1:23 pm

antoniop

Fix test case

Options
    • -1
    • +1
    ./tcl/test/text-html-procs.tcl
11:39 am

antoniop

Extend test suite

Options
    • -0
    • +5
    ./tcl/test/text-html-procs.tcl