OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 17
Total Committers: 73
Last Commit: 28 Dec
Commits this week: 17
Total Lines of Code (LoC): 74,868
Net change in LoC this week: 25

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 18 Jul
12:36 pm

gustafn

fixed test server_startup_ok

Previously, the test was returning different results depending on the order of

tests.

While it is in general better to avoid error entries in the log file during

regression test, since these testing expected behavior, while error entries

in the log file should indicated unexpected behavior. However, it is still

a long way to let the regression test run cleanly.

Options
    • -1
    • +1
    ./tcl/test/acs-tcl-test-procs.tcl
  2. … 1 more file in changeset.
12:05 pm

gustafn

Fixed regression test and make more use of "aa_test_start" and "aa_test_end"

This change reduces the errors in the log file a lets run the

regression test (on my site) without reported errors as reported by

acs_kernel__server_startup_ok.

Options
    • -5
    • +10
    ./tcl/apm-xml-procs.tcl
    • -5
    • +9
    ./tcl/text-html-procs.tcl
  3. … 2 more files in changeset.
10:50 am

gustafn

Skip test, when the optional parameter DiskCache is not defined.

Otherwise, the attempt to set the parameter will fail and will output

an error message to the log file.

Options
    • -3
    • +17
    ./tcl/test/acs-cache-procs.tcl
10:45 am

gustafn

Spelling changes

Options
    • -3
    • +3
    ./tcl/test/acs-tcl-test-procs.tcl
10:44 am

gustafn

Provide an API to check/set/clear the state of the regression test

The new calls are:

- aa_test_running_p

- aa_test_start

- aa_test_end

Options
    • -3
    • +3
    ./tcl/security-procs.tcl
  2. … 1 more file in changeset.
9:54 am

antoniop

Claim additional coverage

Options
    • -1
    • +5
    ./tcl/test/text-html-procs.tcl
Wednesday 17 Jul
3:12 pm

antoniop

Extend test suite to check URL protocol validation

Options
    • -0
    • +52
    ./tcl/test/text-html-procs.tcl
2:53 pm

antoniop

Complete the URL earlier, so that protocol-relative URLs can be correctly determined as external or not

Options
    • -7
    • +11
    ./tcl/text-html-procs.tcl
2:52 pm

antoniop

Extend test suite to check behavior validating external URLs

Options
    • -0
    • +63
    ./tcl/test/text-html-procs.tcl
2:34 pm

gustafn

Fixes for regression test: util_http_json_encoding

This change corrects 2 bugs, causing the regression test to fail under certain circumstances:

1) use for test location [::acs::test::url] instead of [ad_url]

The call [::acs::test::url] should be used for all tests in the regression tests and avoids

problems with wrong URLs when running e.g. in a container

2) When running on a setup with self-signed certificates, the curl requests require a "-k"

flag to be passed. Otherwise, the regression test fails.

Options
    • -10
    • +11
    ./tcl/http-client-procs.tcl
    • -4
    • +7
    ./tcl/test/http-client-procs.tcl
2:29 pm

antoniop

Rework URL validation in ad_dom_sanitize_html

We now prefer higher level api to determine:

- if a URL is external

- what protocol should be assumed for a URL when this is relative or protocol-relative

Options
    • -81
    • +38
    ./tcl/text-html-procs.tcl
1:23 pm

antoniop

Fix test case

Options
    • -1
    • +1
    ./tcl/test/text-html-procs.tcl
11:39 am

antoniop

Extend test suite

Options
    • -0
    • +5
    ./tcl/test/text-html-procs.tcl
Tuesday 16 Jul
7:12 pm

gustafn

provide a better domain name for temporal accounts in regression test

Options
    • -2
    • +2
    ./tcl/test/community-core-test-procs.tcl
3:31 pm

gustafn

made test for valid protocols case invariant

Options
    • -7
    • +13
    ./tcl/text-html-procs.tcl
Monday 15 Jul
5:34 pm

antoniop

Reflect api changes in the test suite

Options
    • -1
    • +7
    ./tcl/test/utilities-procs.tcl
2:04 pm

gustafn

improved spelling

Options
    • -2
    • +2
    ./tcl/security-procs.tcl
  2. … 14 more files in changeset.
Thursday 11 Jul
7:19 am

gustafn

Cluster updates: better support when running in containers

- generalized servers running with an INADDR_ANY address

- handling of running server with ephemeral ports

- streamline function and variable names

- added ./tcl/acs-container-procs.tcl

* make container definitions independent of cluster handling

* create container mapping based on a JSON file, which

can be obtained from docker to get information about

external addresses

* The final interface is a mapping file in Tcl providing at least

the Tcl dict ::docker::containerMapping containing the docker

mapping. A dict key like "8080/tcp" (internal port) will return a

dict containing the keys "host", "port" and "proto" (e.g. proto

https host 192.168.1.192 port 58115).

Options
    • -0
    • +100
    ./tcl/acs-container-procs.tcl
    • -4
    • +5
    ./tcl/cluster-init.tcl
    • -61
    • +202
    ./tcl/cluster-procs.tcl
    • -4
    • +10
    ./tcl/server-cluster-procs.tcl
7:19 am

gustafn

file acs-container-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/acs-container-procs.tcl
Wednesday 10 Jul
3:57 pm

antoniop

In the end we do phase out the util_expand_entities* procs for being too lame

Good riddance

Options
    • -7
    • +10
    ./tcl/text-html-procs.tcl
    • -77
    • +0
    ./tcl/test/text-html-procs.tcl
3:12 pm

gustafn

a protocol relative URL is not complete, but it can be understood as external

Options
    • -8
    • +21
    ./tcl/utilities-procs.tcl
    • -1
    • +23
    ./tcl/test/acs-tcl-test-procs.tcl
2:42 pm

antoniop

Make util_complete_url_p recognize protocl-relative URLs

Options
    • -9
    • +5
    ./tcl/utilities-procs.tcl
2:41 pm

antoniop

Extend the test cases for util_complete_url_p with a case of protocol-relative URL

Options
    • -0
    • +1
    ./tcl/test/acs-tcl-test-procs.tcl
Monday 08 Jul
5:17 pm

antoniop

Reimplement util_expand_entities_ie_style

This proc turned out to be long broken. We could consider phasing it out, but as it is a public interface used in a few places we prefer to keep it around and try to fix it.

The intended behavior has been reconstructed from the documentation. The new approach uses a single regexp to extract entities, which does not risk to loop indefinitely as before.

Options
    • -44
    • +29
    ./tcl/text-html-procs.tcl
5:10 pm

antoniop

Test util_expand_entities and util_expand_entities_ie_style

This test will show that since the long broken parenthesys in util_expand_entities_ie_style were fixed in a recent commit, this proc will just not work.

Options
    • -0
    • +77
    ./tcl/test/text-html-procs.tcl
4:10 pm

antoniop

After further consideration, ns_absoluteurl is actually sufficient to preform location header completion on its own and does not need a wrapper utility

Options
    • -3
    • +1
    ./tcl/http-client-procs.tcl
    • -46
    • +1
    ./tcl/utilities-procs.tcl
    • -104
    • +0
    ./tcl/test/utilities-procs.tcl
  4. … 1 more file in changeset.
3:20 pm

gustafn

Streamline terminology with other occurrences in OpenACS and NaviServer/AOLserver

- the term "location" is usually used in OpenACS/NaviServer/AOLserver for the

part of a URL before the path (i.e. SCHEME+HOST+PORT)

- the new function util::absolute_url is a value-added version of NaviServer's "ns_absoluteurl".

This is now documented with its differences, and aligned with its terminology

Options
    • -3
    • +3
    ./tcl/http-client-procs.tcl
    • -29
    • +29
    ./tcl/utilities-procs.tcl
    • -62
    • +66
    ./tcl/test/utilities-procs.tcl
4:07 am

gustafn

fixed broken indentation and broken nesting

Options
    • -1149
    • +1148
    ./tcl/text-html-procs.tcl
Sunday 07 Jul
12:18 pm

gustafn

fixed indentation of braces

Options
    • -2
    • +2
    ./tcl/application-data-link-procs.tcl
    • -2
    • +2
    ./tcl/json-procs.tcl
    • -2
    • +2
    ./tcl/request-processor-procs.tcl
12:16 pm

gustafn

fix incorrect nesting in switch statements

Options
    • -36
    • +36
    ./tcl/text-html-procs.tcl