OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 17
Total Committers: 73
Last Commit: 28 Dec
Commits this week: 17
Total Lines of Code (LoC): 74,868
Net change in LoC this week: 25

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 07 Jul
12:18 pm

gustafn

fixed indentation of braces

Options
    • -2
    • +2
    ./tcl/application-data-link-procs.tcl
    • -2
    • +2
    ./tcl/json-procs.tcl
    • -2
    • +2
    ./tcl/request-processor-procs.tcl
12:16 pm

gustafn

fix incorrect nesting in switch statements

Options
    • -36
    • +36
    ./tcl/text-html-procs.tcl
12:14 pm

gustafn

added "variable" declaration to avoid potential namespace confusion

Options
    • -1
    • +2
    ./tcl/site-nodes-procs.tcl
Friday 05 Jul
3:43 pm

antoniop

Introduce util::complete_location

This utility is meant to require the value of the Location header in an HTTP response to be completed vith the host coming from a reference complete URL, which is normally that of the redirected request.

It is intended for use in the context of HTTP client APIs, where we want to handle server responses affected by https://www.rfc-editor.org/rfc/rfc7231#section-7.1.2

Options
    • -1
    • +9
    ./tcl/http-client-procs.tcl
    • -1
    • +46
    ./tcl/utilities-procs.tcl
    • -0
    • +100
    ./tcl/test/utilities-procs.tcl
  4. … 1 more file in changeset.
Tuesday 02 Jul
5:00 pm

trenner

use original provided host-header-field in log statement

Options
    • -2
    • +2
    ./tcl/security-procs.tcl
1:09 pm

trenner

escape variable in log statement

Options
    • -2
    • +2
    ./tcl/security-procs.tcl
8:45 am

trenner

Fix another variable name after refactoring

Options
    • -2
    • +2
    ./tcl/security-procs.tcl
Thursday 13 Jun
4:26 pm

antoniop

Fix variable name after refactoring

Options
    • -2
    • +2
    ./tcl/security-procs.tcl
Tuesday 11 Jun
7:04 pm

gustafn

fixed typo

Options
    • -2
    • +2
    ./tcl/security-procs.tcl
11:26 am

gustafn

Updated location handling

- make use of "ns_server hosts" when available

- refactored and simplified code

- keep validated locations in an nsv array

- added support for extra white-listed hosts

in case, every other configuration fails

(should not be necessary)

ns_section ns/server/$server/acs {

ns_param whitelistedHosts {...}

}

- updated inline documentation

The new code is supposed to handle in combination of a recent NaviServer

all complex host header validation scenarios, include running behind a proxy,

in a container or cluster.

Options
    • -79
    • +183
    ./tcl/security-procs.tcl
11:15 am

gustafn

Updated icanuse registry

- added "ns_ip", "ns_subnetmatch", and "ns_server hosts"

- sorted commands alphabetically

Options
    • -7
    • +10
    ./tcl/00-icanuse-procs.tcl
Tuesday 04 Jun
3:18 pm

gustafn

whitespace changes

Options
    • -19
    • +19
    ./tcl/html-procs.tcl
3:18 pm

gustafn

modernize code

Options
    • -4
    • +2
    ./tcl/html-procs.tcl
2:20 pm

gustafn

moved long time deprecated function "ad_approval_system_inuse_p" to deprecated-procs

Options
    • -18
    • +1
    ./tcl/admin-procs.tcl
    • -2
    • +19
    ./tcl/deprecated-procs.tcl
2:14 pm

gustafn

Improved comments and make code more robust in regards of legacy setups

Options
    • -12
    • +20
    ./tcl/request-processor-procs.tcl
Monday 03 Jun
7:47 pm

gustafn

Added support for relative redirects

RFC 2616 requires an absolute URI in the "Location" header field. So

if someone calls "ns_returnredirect /", NaviServer transforms it on

the fly into an absolute URL by prefixing it with the location

(e.g. https://openacs.org/). NaviServer (and OpenACS) has some complex

code to compute the location value, especially when virtual servers

are involved (or for "host-node mapped" subsites in OpenACS). The

situation is further complicated when running behind a reverse proxy

and/or in a containerized environment. In such cases, the location is

computed from the "host" request header field, which must be

validated, otherwise an attacker could hijack a session and redirect

it to a spoofed site.

The situation changed 10 years ago (June 2014) with the introduction

of RFC 7231, which allows relative redirects (see

https://www.rfc-editor.org/rfc/rfc7231#section-7.1.2). Using relative

redirects greatly simplifies configuration and closes the attack

vector using the host header field. RFC 7231 has been superseded by

RFC 9110 (June 2022), which also supports relative redirects via the

"location" response header field (see

https://www.rfc-editor.org/rfc/rfc9110#field.location).

Since OpenACS prefixed always the URL with a location, when it

encounters are relative URL in a "ad_returnredirect", this change

makes use of the new feature of NaviServer 5.

Make sure to use a current version of NaviServer, where the support

was added recently.

Options
    • -0
    • +14
    ./tcl/00-icanuse-procs.tcl
    • -4
    • +10
    ./tcl/utilities-procs.tcl
Friday 31 May
2:01 pm

gustafn

improved robustness during bootstrap

Options
    • -7
    • +20
    ./tcl/parameter-procs.tcl
2:00 pm

gustafn

improved speling

Options
    • -2
    • +2
    ./tcl/xml-0-sgml-procs.tcl
2:00 pm

gustafn

improved spelling

Options
    • -1
    • +1
    ./tcl/acs-db-00-procs.tcl
    • -2
    • +2
    ./tcl/acs-permissions-procs.tcl
    • -2
    • +2
    ./tcl/request-processor-procs.tcl
    • -2
    • +2
    ./tcl/text-html-procs.tcl
    • -4
    • +4
    ./tcl/utilities-procs.tcl
  6. … 1 more file in changeset.
Wednesday 29 May
11:24 am

gustafn

Extended "ad_conn behind_secure_proxy_p"

This test will be now true, when either the recieved request

contains one of those request header fields.

- "X-SSL-Request: 1"

- "X-Forwarded-Proto: https"

Before, only the first variant was accepted.

The AWS load balancer uses the second variant.

Options
    • -2
    • +5
    ./tcl/request-processor-procs.tcl
Wednesday 22 May
10:34 am

trenner

fix typo

Options
    • -2
    • +2
    ./tcl/request-processor-procs.tcl
Friday 17 May
7:04 pm

gustafn

Permit "lang::message::cache" in acs::clusterwide operations

Options
    • -0
    • +1
    ./tcl/cluster-procs.tcl
7:01 pm

gustafn

improvement for ACS clusters

Incorporated changes as suggested by Jonathan Kelley

For details, see https://openacs.org/forums/message-post?parent_id=5814308

Options
    • -1
    • +2
    ./tcl/memoize-procs-naviserver.tcl
  2. … 1 more file in changeset.
4:05 pm

gustafn

Base "ad_conn behind_proxy_p" on "ns_conn details" when available

Options
    • -1
    • +6
    ./tcl/00-icanuse-procs.tcl
    • -10
    • +27
    ./tcl/request-processor-procs.tcl
Thursday 25 Apr
3:50 pm

antoniop

Make test more robust in setups where we cache permissions

Options
    • -2
    • +39
    ./tcl/test/test-permissions-procs.tcl
Friday 05 Apr
10:28 am

gustafn

Improved readability of configuration parameter "parameterSecret"

- Switched to camelCase for better readabilty and uniformity

- NaviServer configuration parameters are case insensitive, so no danger for backward compatibility

Options
    • -4
    • +4
    ./tcl/security-init.tcl
    • -6
    • +6
    ./tcl/security-procs.tcl
    • -4
    • +4
    ./tcl/tcl-documentation-procs.tcl
    • -2
    • +2
    ./tcl/utilities-procs.tcl
  5. … 2 more files in changeset.
Wednesday 27 Mar
12:46 pm

antoniop

Expand permission test suite to include definition of custom privileges in a couple of setups

Options
    • -11
    • +221
    ./tcl/test/test-permissions-procs.tcl
Tuesday 26 Mar
10:10 am

antoniop

Provide an automated test of "advanced" permission features: permission inheritance via group, or via the permission context

Options
    • -1
    • +203
    ./tcl/test/test-permissions-procs.tcl
Tuesday 19 Mar
11:47 am

antoniop

Untangle if logics

Options
    • -23
    • +30
    ./tcl/text-html-procs.tcl
11:46 am

antoniop

Reject URLs displaying multiple protocols

Options
    • -1
    • +27
    ./tcl/text-html-procs.tcl