OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 17
Total Committers: 73
Last Commit: 28 Dec
Commits this week: 17
Total Lines of Code (LoC): 74,868
Net change in LoC this week: 25

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 29 May
11:24 am

gustafn

Extended "ad_conn behind_secure_proxy_p"

This test will be now true, when either the recieved request

contains one of those request header fields.

- "X-SSL-Request: 1"

- "X-Forwarded-Proto: https"

Before, only the first variant was accepted.

The AWS load balancer uses the second variant.

Options
    • -2
    • +5
    ./tcl/request-processor-procs.tcl
Wednesday 22 May
10:34 am

trenner

fix typo

Options
    • -2
    • +2
    ./tcl/request-processor-procs.tcl
Friday 17 May
7:04 pm

gustafn

Permit "lang::message::cache" in acs::clusterwide operations

Options
    • -0
    • +1
    ./tcl/cluster-procs.tcl
7:01 pm

gustafn

improvement for ACS clusters

Incorporated changes as suggested by Jonathan Kelley

For details, see https://openacs.org/forums/message-post?parent_id=5814308

Options
    • -1
    • +2
    ./tcl/memoize-procs-naviserver.tcl
  2. … 1 more file in changeset.
4:05 pm

gustafn

Base "ad_conn behind_proxy_p" on "ns_conn details" when available

Options
    • -1
    • +6
    ./tcl/00-icanuse-procs.tcl
    • -10
    • +27
    ./tcl/request-processor-procs.tcl
Thursday 25 Apr
3:50 pm

antoniop

Make test more robust in setups where we cache permissions

Options
    • -2
    • +39
    ./tcl/test/test-permissions-procs.tcl
Friday 05 Apr
10:28 am

gustafn

Improved readability of configuration parameter "parameterSecret"

- Switched to camelCase for better readabilty and uniformity

- NaviServer configuration parameters are case insensitive, so no danger for backward compatibility

Options
    • -4
    • +4
    ./tcl/security-init.tcl
    • -6
    • +6
    ./tcl/security-procs.tcl
    • -4
    • +4
    ./tcl/tcl-documentation-procs.tcl
    • -2
    • +2
    ./tcl/utilities-procs.tcl
  5. … 2 more files in changeset.
Wednesday 27 Mar
12:46 pm

antoniop

Expand permission test suite to include definition of custom privileges in a couple of setups

Options
    • -11
    • +221
    ./tcl/test/test-permissions-procs.tcl
Tuesday 26 Mar
10:10 am

antoniop

Provide an automated test of "advanced" permission features: permission inheritance via group, or via the permission context

Options
    • -1
    • +203
    ./tcl/test/test-permissions-procs.tcl
Tuesday 19 Mar
11:47 am

antoniop

Untangle if logics

Options
    • -23
    • +30
    ./tcl/text-html-procs.tcl
11:46 am

antoniop

Reject URLs displaying multiple protocols

Options
    • -1
    • +27
    ./tcl/text-html-procs.tcl
11:44 am

antoniop

Test further improvement of injection attempt by penetration tests

Options
    • -0
    • +10
    ./tcl/test/text-html-procs.tcl
Monday 18 Mar
2:13 pm

antoniop

Strenghten validation against smarter attempts to disguise the javascript: protocol

Options
    • -10
    • +17
    ./tcl/text-html-procs.tcl
2:12 pm

antoniop

Replicate a smarter attempt by a penetration tool to disguise the javascript: protocol

Options
    • -11
    • +24
    ./tcl/test/text-html-procs.tcl
Thursday 29 Feb
12:21 pm

gustafn

Added default dbn to database drivers (acs::dc)

Align behavior with recent change in the xo::db inteface

Options
    • -5
    • +12
    ./tcl/acs-db-00-procs.tcl
Tuesday 27 Feb
5:17 pm

hectorr

Remove duplicated entry

Options
    • -5
    • +4
    ./tcl/test/acs-tcl-test-procs.tcl
Monday 26 Feb
12:54 pm

gustafn

removed legacy code from apm_transfer_file

util::http::get should be everywhere available

Options
    • -57
    • +3
    ./tcl/apm-file-procs.tcl
12:09 pm

gustafn

Rework of util::which

The new version deals now correctly with absolute paths,

where just the extensions are added, and it is checked

whether the program is executable.

Extended regression test to deal with optional and required

external dependencies. Missing optional external programs

produce warnings.

Options
    • -30
    • +46
    ./tcl/utilities-procs.tcl
    • -31
    • +91
    ./tcl/test/acs-tcl-test-procs.tcl
12:05 pm

gustafn

Reduced redundancy

call text_templates::create_pdf_from_html from

text_templates::create_pdf_content instead of replicating logic

Options
    • -31
    • +27
    ./tcl/pdf-procs.tcl
12:03 pm

gustafn

Use for new installation relative path names for external programs per default

Options
    • -1
    • +1
    ./acs-tcl.info
Sunday 25 Feb
6:25 pm

gustafn

Cleanup of external binaries: always use "util::which" to resolve binaries

Background: it is important to always use the same binaries of some

programs. This is important for security reasons, consistency, and

configurability (some operating systems have read-only file systems,

which might be on the path and should be avoided for some operations).

Options
    • -2
    • +2
    ./tcl/test/http-client-procs.tcl
5:13 pm

gustafn

Cleanup of external binaries: always use "util::which" to resolve binaries

Background: it is important to always use the same binaries of some

programs. This is important for security reasons, consistency, and

configurability (some operating systems have read-only file systems,

which might be on the path and should be avoided for some operations).

Options
    • -2
    • +2
    ./tcl/http-client-procs.tcl
  2. … 3 more files in changeset.
4:46 pm

gustafn

Use GNU grep when available

GNU grep is now used for the lookup of message keys using the

"--include=" parameter. This improves the speed of the command

significantly and reduces the number of external dependencies (no

"find", or "xargs" needed).

Options
    • -8
    • +9
    ./tcl/00-icanuse-procs.tcl
  2. … 1 more file in changeset.
11:49 am

gustafn

Cleanup of external binaries: always use "util::which" to resolve binaries

Options
    • -3
    • +3
    ./tcl/apm-file-procs.tcl
Friday 23 Feb
2:14 pm

antoniop

Improve test:

whether the html filter will accept or not a script tag is configuration-dependent. We now enforce that the outcome is consistent with the security check for HTML used in the filter itself.

Options
    • -1
    • +1
    ./tcl/test/acs-tcl-test-procs.tcl
Friday 16 Feb
12:38 pm

antoniop

Manually replace the ":" entity to prevent attempts at disguising "javascript:" links

Options
    • -1
    • +17
    ./tcl/text-html-procs.tcl
12:36 pm

antoniop

Replicate injection attempt by penetration tools

Options
    • -0
    • +14
    ./tcl/test/text-html-procs.tcl
Thursday 15 Feb
7:04 pm

gustafn

page filters with NUL value

Prefer "string first" over "regexp" since this is twice as fast.

Options
    • -4
    • +5
    ./tcl/tcl-documentation-procs.tcl
5:47 pm

gustafn

security::validated_host_header: Made acceptance of configured vhosts the first check

Under certain conditions (such as running in a container, or reverse

proxy situations) the admin of a server wants to specify accepted host

names. This can be achieved in the "*/servers" section of a network

driver. These values are used now first for accepting host header

fields. This change avoids unexpected redirects to, e.g., internal

server addresses.

Options
    • -35
    • +41
    ./tcl/security-procs.tcl
5:41 pm

gustafn

bugfix: fixed test test_ad_register_proc when running in a container

When runnig in a container, one cannot use util_current_localtion, which refers

to the URL to reach the server from the container host. To address the server

inside the container, acs::test::url should be used.

This change does not matter for non-containerized applications

Options
    • -2
    • +2
    ./tcl/test/request-processor-procs.tcl