OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 16
Total Committers: 73
Last Commit: 28 Dec 24
Commits this week: 16
Total Lines of Code (LoC): 74,868
Net change in LoC this week: 25

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 15 Feb 2024
5:41 pm

gustafn

bugfix: fixed test test_ad_register_proc when running in a container

When runnig in a container, one cannot use util_current_localtion, which refers

to the URL to reach the server from the container host. To address the server

inside the container, acs::test::url should be used.

This change does not matter for non-containerized applications

Options
    • -2
    • +2
    ./tcl/test/request-processor-procs.tcl
1:27 pm

antoniop

Provide facilities to validate against invalid SQL strings

We introduce a new page contract filter and nsf validator called "dbtext". They implement enforcing of a value to be useable in an SQL query. Currently, this means that the value should not contain the NUL character, but the definition may change in the future or become database-specific.

The html contract filter has also be extended to reject the NUL character.

The test suite has been updated/extended to reflect the changes.

Options
    • -2
    • +30
    ./tcl/tcl-documentation-procs.tcl
    • -5
    • +41
    ./tcl/test/acs-tcl-test-procs.tcl
  3. … 1 more file in changeset.
Tuesday 13 Feb 2024
5:48 pm

antoniop

Reform of error handling in ad_page_contract when template recursion is detected

A "complaint recursion" happens if a validation error takes place in one of the templates used while rendering the error page (for instance, anything we include in the master template or the master template itself).

Previously, we would give up complaining after 10 recursions were detected. This had the consequence that after 10 attempt, the failing template involved in rendering the complaint would be fed the invalid data we were trying to reject.

Now, we complain and stop the execution as soon as a recursion is detected. The error will be rendered in a very basic way that overrides the templating system, so that we can exit the recursion cycle.

In practice, only malicious page manipulation attempts should be affected by this change.

Options
    • -35
    • +60
    ./tcl/tcl-documentation-procs.tcl
Monday 12 Feb 2024
7:31 pm

gustafn

improved portability: some versions of "gzip" do not support option "-S"

Options
    • -3
    • +2
    ./tcl/apm-file-procs.tcl
7:29 pm

gustafn

improved spelling

Options
    • -1
    • +1
    ./tcl/test/apm-file-procs.tcl
Thursday 08 Feb 2024
7:43 pm

gustafn

improved logging output from install.xml files

Options
    • -6
    • +19
    ./tcl/apm-install-procs.tcl
Saturday 03 Feb 2024
9:27 am

gustafn

Removed "-debug" flag

Options
    • -2
    • +2
    ./tcl/apm-procs.tcl
9:26 am

gustafn

improved robustness of "try_cache"

Added handling of "-per_request" option

Options
    • -1
    • +1
    ./tcl/acs-cache-procs.tcl
Tuesday 30 Jan 2024
5:56 pm

antoniop

Move test from acs-kernel to acs-tcl, add remarks

Options
    • -0
    • +19
    ./tcl/test/acs-tcl-test-procs.tcl
  2. … 1 more file in changeset.
Monday 22 Jan 2024
5:23 pm

gustafn

clear diry editor buffer

Options
    • -6
    • +8
    ./tcl/install-procs.tcl
Sunday 21 Jan 2024
6:07 pm

gustafn

added support to install theme from install.xml

Options
    • -1
    • +21
    ./tcl/install-procs.tcl
Sunday 17 Dec 2023
8:28 pm

gustafn

Added support for automatic disconnect when a dynamic cluster node is shut down

When the dynamic cluster configuration has scale for certain

occasions, it makes sense to provide down scaling support when these

occasions are over, which does not rely on the configured cluster

disconnect timeout (ClusterAutodeleteInterval). The new code will send

automatically a disconnect request when a dynamic cluster node is

terminating gracefully.

Depending on the configuration, a new version of NaviServer will be

necessary to reliably execute disconnect requests. Appropriate changes

are in the NaviServer release/4.99 and main branches.

- Bumped version numbers:

* acs-tcl to 5.10.1b4

* acs-admin to 5.10.1b4

Options
    • -2
    • +2
    ./acs-tcl.info
    • -9
    • +19
    ./tcl/cluster-init.tcl
    • -41
    • +75
    ./tcl/cluster-procs.tcl
  4. … 2 more files in changeset.
Tuesday 05 Dec 2023
6:14 pm

gustafn

Adding auto-deletion of dynamic cluster nodes and small refactoring

- New kernel parameter "ClusterAutodeleteInterval" to specify, when a

dynamic cluster node is not regarded as temporarily unavailable but

as definitely gone. The default value for this parameter is 2m (2

minutes).

- small refactoring to reduce duplicated logic

- Bumped version numbers:

* acs-kernel to 5.10.1b4

* acs-tcl to 5.10.1b3

* acs-admin to 5.10.1b3

Options
    • -3
    • +3
    ./acs-tcl.info
    • -0
    • +10
    ./tcl/cluster-init.tcl
    • -10
    • +65
    ./tcl/cluster-procs.tcl
  4. … 3 more files in changeset.
Monday 04 Dec 2023
4:32 pm

gustafn

Small update for cluster support

- Improved visualization of cluster nodes that we lost contact to

- New kernel parameters to reduce hard-coded values and to make purpose more explicit

* new parameter ClusterHeartbeatInterval (default 20s),

was hardcoded before to the new default value

* renamed PreferredLocationRegexp -> ClusterPreferredLocationRegexp

* renamed EnableLoggingP -> ClusterEnableLoggingP

- Bumped version numbers:

* acs-kernel to 5.10.1b3

* acs-tcl to 5.10.1b2

* acs-admin to 5.10.1b2

acs-kernel acs-admin acs-tcl/

Options
    • -3
    • +3
    ./acs-tcl.info
    • -4
    • +9
    ./tcl/cluster-init.tcl
    • -2
    • +9
    ./tcl/cluster-procs.tcl
  4. … 5 more files in changeset.
Friday 01 Dec 2023
11:33 am

gustafn

improved spelling

Options
    • -2
    • +2
    ./tcl/security-procs.tcl
11:32 am

gustafn

provide the version directory instead of the version on the admin page

Earlier versions had just the version, but not the version directory, which is

the precise information

CVS: ----------------------------------------------------------------------

Options
    • -4
    • +4
    ./lib/check-installed.tcl
Wednesday 29 Nov 2023
8:44 pm

gustafn

cluster setup: use qualified location as well for the local host

Options
    • -6
    • +7
    ./tcl/cluster-procs.tcl
Tuesday 28 Nov 2023
4:55 pm

gustafn

added new flag to util::join_location to avoid removing the default port

this addresses the bug reported by Jonathan Kelley in the openacs.org Q&A forum

Options
    • -1
    • +1
    ./tcl/cluster-procs.tcl
    • -3
    • +9
    ./tcl/utilities-procs.tcl
Monday 27 Nov 2023
7:32 pm

gustafn

provide qualified_location for incoming join requests

Many thanks for Jonathan Kelley reporting this problem

Options
    • -1
    • +1
    ./tcl/cluster-procs.tcl
Monday 20 Nov 2023
4:04 pm

antoniop

When using ad_dom_sanitize_html to validate markup, treat failure to parse as a normal validation failure, rather than an error

Options
    • -3
    • +4
    ./tcl/text-html-procs.tcl
Friday 17 Nov 2023
2:32 pm

gustafn

db_multirow: fall back to -local behavior, when used outside of an ADP file

The old behavior was, that when "db_multirow" was called outside an ADP

environment, an error was generated, since the uplevel was determined

without the "-local" flag by [template::adp_level]. Outside ADP,

the result of the function is empty, leading to an error that

a level "#" is invalid. Depending on an optional flag is strange

for a "db_*" command.

Now, the default behavior outside ADP file is local (i.e., when

calling outside ADP, the output variables are set in the calling

scope, unless a different "upvar_level" is specified).

Options
    • -10
    • +22
    ./tcl/01-database-procs.tcl
Tuesday 07 Nov 2023
3:03 pm

gustafn

remove encoding switching command

the command was there for the deactivated test "exec_binary_input".

The way, how encoding switching was performed, was unreliable,

since the nruns value of the proxy might expire between the

switching commands. If this is really necessary, a different solution

has to be designed

Options
    • -14
    • +0
    ./tcl/proxy-procs.tcl
Tuesday 24 Oct 2023
6:11 pm

gustafn

use "ns_set stats" when available in memory statistics of ::xo::stats

Options
    • -0
    • +1
    ./tcl/00-icanuse-procs.tcl
  2. … 1 more file in changeset.
11:25 am

antoniop

Make URLs assumed to be hosted on openacs.org absolute

Options
    • -2
    • +2
    ./tcl/test/text-html-procs.tcl
  2. … 3 more files in changeset.
Thursday 12 Oct 2023
12:43 pm

antoniop

Flushing the cache completely is actually the right thing to do if we want to be more robust to cache pollution: see e.g. executing acs-authentication and acs-tcl automated tests during the same request

Options
    • -3
    • +3
    ./tcl/parameter-procs.tcl
12:25 pm

antoniop

For consistency with other apis, cache the updated parameter value immediately and return it

Options
    • -2
    • +2
    ./tcl/parameter-procs.tcl
Wednesday 11 Oct 2023
3:55 pm

antoniop

Flush the cache only

this will behave as before, because specifying -delete will supersede all other flags and -set would not be applied.

Options
    • -2
    • +2
    ./tcl/parameter-procs.tcl
3:53 pm

antoniop

Improve test for singleton package parameters (aka instance parameters of singleton packages):

- do not choose a parameter at random, test them all instead

- do not test for global parameters. For those, the api will behave differently

- do not test for parameters coming from the configuration file. The parameter::* api does not allow to manipulate those

- do not check for packages that are not mounted. A value would not be found for those

Options
    • -45
    • +73
    ./tcl/test/apm-parameter-test-procs.tcl
Thursday 05 Oct 2023
5:52 pm

gustafn

added standard parameterizations for Argon2 when supported.

Options
    • -0
    • +1
    ./tcl/00-icanuse-procs.tcl
    • -1
    • +52
    ./tcl/security-procs.tcl
  3. … 1 more file in changeset.
Monday 04 Sep 2023
5:25 pm

gustafn

added support for icanuse "ns_crypto::scrypt"

it looks as if this was lost over time

Options
    • -0
    • +1
    ./tcl/00-icanuse-procs.tcl