OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 73
Last Commit: 28 Dec 24
Commits this week: 0
Total Lines of Code (LoC): 74,868
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 10 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 27 Aug 2022
10:35 pm

gustafn

use icanuse "ns_parsehtml" and new interface

Options
    • -5
    • +4
    ./tcl/test/doc-check-procs.tcl
10:34 pm

gustafn

added icanuse rule for ns_parsehtml

Options
    • -0
    • +1
    ./tcl/00-icanuse-procs.tcl
10:30 pm

gustafn

Give people the chance to use OpenACS with WithDeprecatedCode set to 0

When OpenACS is configured with loading of deprecated procs

deactivated, files like deprecated-procs.tcl are not

loaded. Therefore, these files should only contain code, which was

deprecated at LEAST ONE RELEASE EARLIER, such that site admins have one

release time to fix calls to deprecated code.

This change reverts in part Antonio's commit from 26 Aug 2022 which

causes errors like the following on openacs.org:

Error in include template "/var/www/openacs.org/packages/news/lib/news":

invalid command name "ad_parameter_all_values_as_list"

Options
    • -4
    • +24
    ./tcl/defs-procs.tcl
    • -22
    • +10
    ./tcl/deprecated-procs.tcl
Friday 26 Aug 2022
3:00 pm

antoniop

Deprecate ad_parameter_all_values_as_list: it does not provide much value and was also often use improperly

Options
    • -2
    • +2
    ./tcl/apm-file-procs.tcl
    • -15
    • +1
    ./tcl/defs-procs.tcl
    • -2
    • +21
    ./tcl/deprecated-procs.tcl
    • -30
    • +9
    ./tcl/text-html-procs.tcl
    • -2
    • +0
    ./tcl/test/html-conversion-procs.tcl
2:06 pm

antoniop

tmpfile page contract filter reform:

do not allow acs-subsite TmpDir parameter to define where the tmpfolder is located anymore. This MUST be the one configured in the server-wide configuration. Tmpfiles cannot be in a subfolder of the tmpfolder, they MUST be direct children instead. A tmpfile MUST exist beforehand and be owned, be readable and writable by the user running the nsd process. This complies with the definition of a tmpfile by AolServer/NaviServer when they are created to store content coming from a file upload.

Options
    • -2
    • +2
    ./acs-tcl.info
    • -36
    • +2
    ./tcl/security-procs.tcl
    • -24
    • +10
    ./tcl/tcl-documentation-procs.tcl
    • -28
    • +0
    ./tcl/test/security-procs.tcl
  5. … 1 more file in changeset.
Thursday 25 Aug 2022
6:01 pm

antoniop

Extend tmpfile filter to behave in the "old way" (default), or in strict mode e.g. tmpfile(strict), enforcing the behavior for tmpfile in Aolserver/Naviserver when a form is processed

Options
    • -12
    • +30
    ./tcl/tcl-documentation-procs.tcl
5:37 pm

antoniop

Reimplement ad_page_contract_filter_proc_tmpfile using security::safe_tmpfile_p

Some of the features implemented by this filter have been ported into the api, namely the possibility to fetch the valid temp folders from the subsite TmpDir parameter and the possibility to relax the check and allow also files deeper in the tmpfolder hierachy.

Notably, the hardcoded tmpfolders "/var/tmp" and "/tmp" have NOT been ported. One should configure these values via the many available options. security::safe_tmpfile_p is also more restrictive when a file exists, because it checks for ownership and read and write permissions on the file.

Options
    • -3
    • +42
    ./tcl/security-procs.tcl
    • -17
    • +8
    ./tcl/tcl-documentation-procs.tcl
    • -1
    • +30
    ./tcl/test/security-procs.tcl
4:16 pm

antoniop

Comment WIP

Options
    • -6
    • +6
    ./tcl/parameter-procs.tcl
3:12 pm

antoniop

Declare proc coverage

Options
    • -0
    • +2
    ./tcl/test/http-client-procs.tcl
  2. … 1 more file in changeset.
3:09 pm

antoniop

Factor the payload building behavior in util::http::post into its own proc, so that it can be reused elsewhere

Options
    • -69
    • +170
    ./tcl/http-client-procs.tcl
2:37 pm

antoniop

Add must_exist flag to enforce a safe tmpfile to already exist

Options
    • -2
    • +2
    ./acs-tcl.info
    • -4
    • +9
    ./tcl/security-procs.tcl
    • -1
    • +6
    ./tcl/test/security-procs.tcl
1:44 pm

gustafn

Fixed bug in util_convert_line_breaks_to_html

The code deleted spaces around certain tags, while - according to the

documentation, only line breaks should be removed from there.

Extended regression test.

Options
    • -4
    • +5
    ./tcl/text-html-procs.tcl
    • -5
    • +14
    ./tcl/test/html-conversion-procs.tcl
1:25 pm

antoniop

Introduce security::safe_tmpfile_p checking whether a file belongs to the configured tmpfolder and respects other constraints

The plan is to use it to improve input validations

Options
    • -2
    • +2
    ./acs-tcl.info
    • -1
    • +54
    ./tcl/security-procs.tcl
    • -0
    • +45
    ./tcl/test/security-procs.tcl
Wednesday 24 Aug 2022
4:51 pm

gustafn

Deactivated script-dynamic again

activating "script-dynamic" for script-src prevents resources as the following from loading

<script type="text/javascript" src="/resources/xowiki/bootstrap-treeview/1.2.0/bootstrap-treeview.min.js" nonce="F8843D5CD542FB1CDB4C94C5D13C4E5ECC2E1DCA">

Options
    • -2
    • +2
    ./tcl/security-procs.tcl
4:30 pm

gustafn

improve test coverage of apm_* API

Options
    • -0
    • +24
    ./tcl/test/apm-procs.tcl
2:13 pm

gustafn

added test for checking documentation in regard of valid HTML markup

Options
    • -2
    • +53
    ./tcl/test/doc-check-procs.tcl
Tuesday 23 Aug 2022
8:44 pm

gustafn

Properly escape "<" and ">" in api-doc documentation.

Since all documentation is rendered via HTML, the characters

"<" and ">" have to be HTML-quoted, otherwise strange things

(omission, unintended renderings) might occur.

E.g. the sentence

Define an interface between a page and an

ADP <include> similar to the page_contract.

was rendered as

Define an interface between a page and an

ADP similar to the page_contract.

which is incorrect.

Options
    • -6
    • +7
    ./tcl/deprecated-procs.tcl
    • -5
    • +9
    ./tcl/security-procs.tcl
    • -17
    • +22
    ./tcl/tcl-documentation-procs.tcl
    • -7
    • +6
    ./tcl/utilities-procs.tcl
  5. … 10 more files in changeset.
1:10 pm

gustafn

Changed "db_multirow" to use "db_list_of_lists" instead of "db_list_of_ns_sets"

Thanks to the recent improvements in NaviServer for

"db_list_of_lists", it is more efficient to use this in "db_multirow"

(actually in "db_multirow_helper"). The implementation revealed a bug

in "db_list_of_lists", when both options "-columns_var" and

"-with_headers" were set.

Extended regression test to cover the former bug.

Options
    • -9
    • +19
    ./tcl/01-database-procs.tcl
    • -1
    • +17
    ./tcl/test/db-proc-test-procs.tcl
Friday 19 Aug 2022
12:16 pm

antoniop

Relax tdom tolerance for non-standard markup

Options
    • -2
    • +3
    ./tcl/apm-install-procs.tcl
12:15 pm

antoniop

Test apm_get_repository_channels proc

Options
    • -0
    • +25
    ./tcl/test/apm-install-procs.tcl
12:15 pm

antoniop

file apm-install-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl/test/apm-install-procs.tcl
Wednesday 17 Aug 2022
12:43 pm

antoniop

Fix typo

Options
    • -1
    • +1
    ./tcl/test/db-proc-test-procs.tcl
Thursday 11 Aug 2022
3:49 pm

gustafn

Generalized "version_dir" handling a little for download specs

The problem was that bootstrap5 uses a version directory, which

consists of the version plus an extra string element. The previous

version assumed that the version is always used as a directory name.

Whe track now the versionDir information in the resource_info dict and

use this, when available (otherwise the version number is used as before).

The resource_info dict contains now the following path components:

# Provide paths for loading either via /resources/ or CDN

#

# "resourceDir" is the absolute path in the filesystem

# "resourceUrl" is the URL path provided to the request processor

# "versionDir" is the version-specific element both in the

# URL and in the filesystem.

#

bumped acs-tcl to 5.10.1d19

Options
    • -2
    • +2
    ./acs-tcl.info
    • -2
    • +8
    ./lib/check-installed.tcl
    • -1
    • +27
    ./tcl/utilities-procs.tcl
Monday 08 Aug 2022
4:48 pm

gustafn

fix several bugs in "acs_object_type::supertype" and improve code sanity

Options
    • -8
    • +8
    ./tcl/object-type-procs-postgresql.xql
    • -8
    • +8
    ./tcl/object-type-procs.tcl
    • -1
    • +10
    ./tcl/test/object-test-case-procs.tcl
1:01 pm

antoniop

Replace not portable sql idiom with existing api, improve caching, extend regression test

Options
    • -26
    • +32
    ./tcl/object-procs.tcl
    • -4
    • +7
    ./tcl/object-type-procs.tcl
    • -1
    • +19
    ./tcl/test/object-test-case-procs.tcl
Friday 29 Jul 2022
8:54 pm

gustafn

whitespace fixes

Options
    • -10
    • +10
    ./tcl/object-procs.tcl
8:53 pm

gustafn

Quick fix for problems with recursive query for type hierarchy on openacs.org

On OpenACS.org, the types for object_type in acs_objects and acs_object_types differs,

leading to a hard error in PostgreSQL. This is just a quick fix, the proper

fix is to investigate, why the types differ (other sites might be as well

affected by this) and to provide a proper update script.

Furthermore, the query is not Oracle compliant.

Options
    • -3
    • +3
    ./tcl/object-procs.tcl
7:27 pm

gustafn

fix testcase as indicated by hector, extend regression test

Options
    • -2
    • +2
    ./tcl/01-database-procs.tcl
    • -6
    • +20
    ./tcl/test/db-proc-test-procs.tcl
Wednesday 27 Jul 2022
3:54 pm

hectorr

Extend 'db__db_foreach' test case, exposing a regression in 'db_foreach' with an uneven number of columns

Options
    • -0
    • +14
    ./tcl/test/db-proc-test-procs.tcl
Wednesday 20 Jul 2022
1:50 pm

gustafn

added memory units to default values

Options
    • -1
    • +1
    ./tcl/acs-cache-init.tcl
    • -2
    • +2
    ./tcl/acs-permissions-init.tcl
    • -24
    • +24
    ./tcl/community-core-init.tcl