OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 1
Total Committers: 73
Last Commit: 12:10
Commits this week: 1
Total Lines of Code (LoC): 74,843
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 22 Oct
11:37 am

gustafn

Use tdom 0.9.5 feature when available

Prefer the builtin json2dict implementation of tDOM when available

Options
    • -0
    • +1
    ./tcl/00-icanuse-procs.tcl
    • -47
    • +53
    ./tcl/json-procs.tcl
    • -1
    • +0
    ./tcl/test/json-test-procs.tcl
Monday 21 Oct
5:49 pm

gustafn

improved inline documentation

Options
    • -24
    • +40
    ./tcl/01-database-procs.tcl
    • -1
    • +4
    ./tcl/utilities-procs.tcl
Sunday 20 Oct
12:13 pm

gustafn

improved API documentation

Options
    • -6
    • +6
    ./tcl/01-database-procs.tcl
    • -13
    • +22
    ./tcl/utilities-procs.tcl
Friday 18 Oct
2:02 pm

gustafn

fixed test cases and improve documentation, added :util::block_request

Options
    • -6
    • +36
    ./tcl/utilities-procs.tcl
Wednesday 16 Oct
11:21 am

gustafn

Added code to skip suspicious looking query variables

On openacs.org, we are experiencing numerous requests with

multiply very long and strange query variables like in the example

below. So far, it is not clear, whether these requests are the

consequence of a double encoding or a deliberate attack. Many (most)

of the requests contain the query variable names containing the

(decoded) pattern "*amp;*".

This is a relatively new phenomenon. I cannot exclude that this is a

bug introduced lately in OpenACS, or a bug in an external bot, or

whatever. The problem with these query variables is that OpenACS

propagates these further, e.g., when updating query variables in

ad_dimensional, via export_vars, or return_urls.

Since OpenACS never uses these query-variables, these can be safely

skipped, without loosing functionality in OpenACS. It is possible to

construct examples, where skipping such variables can change the

semantics. Therefore, the change introduces a single function

util::suspicious_query_variable where in case of problems, the

skipping feature can be deactivated.

GET /api-doc/proc-browse?amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3borderby=name&type=All&amp%3btype=All&amp%3bamp%3btype=All&amp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3borderby=name&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=Private&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3borderby=name&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All HTTP/1.1" 200 62378 "" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/605.1.15 (KHTML, like Gecko; compatible; FriendlyCrawler/1.0) Chrome/120.0.6099.216 Safari/605.1.15" "1729029614.331581 0.109805 0.000434 0.004026 0.215927

Options
    • -2
    • +2
    ./acs-tcl.info
    • -4
    • +56
    ./tcl/utilities-procs.tcl
  3. … 5 more files in changeset.
10:49 am

gustafn

make skipping reason explicit

Options
    • -1
    • +1
    ./tcl/test/http-client-procs.tcl
Wednesday 09 Oct
4:42 pm

antoniop

Finish array reform in this proc

Options
    • -8
    • +9
    ./tcl/apm-install-procs.tcl
2:42 pm

antoniop

Rework array idioms

Options
    • -14
    • +12
    ./tcl/test/doc-check-procs.tcl
    • -13
    • +15
    ./tcl/test/file-test-procs.tcl
2:14 pm

antoniop

Formatting changes

Options
    • -12
    • +12
    ./tcl/test/db-proc-test-procs.tcl
2:10 pm

antoniop

Prefer unset to array unset when no pattern matching is needed

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -2
    • +2
    ./tcl/test/db-proc-test-procs.tcl
Tuesday 08 Oct
5:20 pm

antoniop

No need to fiddle in the ad_conn array if we just reset it

Options
    • -6
    • +2
    ./tcl/request-processor-procs.tcl
5:16 pm

antoniop

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -9
    • +7
    ./tcl/apm-install-procs.tcl
  2. … 3 more files in changeset.
4:13 pm

antoniop

Prefer unset to array unset when the whole array should be deleted, rework array idioms into dict idioms to avoid unsetting the array, where appropriate

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -5
    • +7
    ./tcl/apm-install-procs.tcl
    • -5
    • +5
    ./tcl/apm-procs.tcl
    • -1
    • +1
    ./tcl/form-processing-procs.tcl
    • -8
    • +6
    ./tcl/site-nodes-procs.tcl
    • -2
    • +2
    ./tcl/text-html-procs.tcl
11:30 am

antoniop

Limit files__tcl_file_common_errors test to installed packages

Unmaintained packages may ship files with invalid encodings, which tcl9 won't tolerate anymore.

Options
    • -2
    • +13
    ./tcl/test/file-test-procs.tcl
Monday 07 Oct
6:02 pm

antoniop

Improve test

- skip packages that are not installed before we check the info file

- ensure all installed packages have an info file

This fixes the test for tcl9, where some unmaintained packages may fail the file parsing because of invalid encoding.

Options
    • -5
    • +21
    ./tcl/test/file-test-procs.tcl
Tuesday 01 Oct
2:52 pm

gustafn

Tcl9 regression test: deactivated case broken in tcl9 with unclear semantics

Options
    • -40
    • +45
    ./tcl/test/http-client-procs.tcl
2:50 pm

gustafn

whitespace change

Options
    • -4
    • +4
    ./tcl/acs-db-12-procs.tcl
2:44 pm

gustafn

tcl9 changes: "string bytelength" does not exist in tcl9

Options
    • -13
    • +12
    ./tcl/test/00-icanuse-procs.tcl
  2. … 1 more file in changeset.
Sunday 29 Sep
6:29 am

gustafn

removed file deleted in branch oacs-5-10

Options
    • -3810
    • +0
    ./tcl/00-database-procs.tcl
Tuesday 24 Sep
1:44 pm

antoniop

Ensure we fail the check and complain when a localurl is invalid

Options
    • -10
    • +15
    ./tcl/tcl-documentation-procs.tcl
Thursday 19 Sep
12:59 pm

antoniop

Fix passing complaints info to the complain template

Options
    • -3
    • +5
    ./tcl/tcl-documentation-procs.tcl
Wednesday 11 Sep
8:11 am

gustafn

merge with missing files

Options
    • -0
    • +0
    ./lib/page-error.tcl
    • -0
    • +0
    ./tcl/01-database-procs-oracle.tcl
    • -0
    • +0
    ./tcl/01-database-procs-postgresql.tcl
    • -0
    • +0
    ./tcl/01-database-procs.tcl
    • -0
    • +0
    ./tcl/10-charset-compat-procs.tcl
    • -0
    • +0
    ./tcl/acs-kernel-procs.tcl
    • -0
    • +0
    ./tcl/acs-permissions-procs.tcl
    • -0
    • +0
    ./tcl/acs-private-data-procs.tcl
    • -0
    • +0
    ./tcl/ad-functional-procs.tcl
    • -0
    • +0
    ./tcl/admin-init.tcl
    • -0
    • +0
    ./tcl/admin-procs.tcl
    • -0
    • +0
    ./tcl/adp-parser-procs.tcl
    • -0
    • +0
    ./tcl/aolserver-3-procs.tcl
    • -0
    • +0
    ./tcl/apm-file-procs.tcl
    • -0
    • +0
    ./tcl/apm-install-procs.tcl
  16. … 1450 more files in changeset.
Tuesday 03 Sep
5:37 pm

gustafn

merge from oacs-5-10

Options
    • -7
    • +8
    ./acs-tcl.info
    • -1
    • +1
    ./catalog/acs-tcl.ca_ES.ISO-8859-1.xml
    • -18
    • +19
    ./catalog/acs-tcl.de_DE.ISO-8859-1.xml
    • -5
    • +5
    ./catalog/acs-tcl.el_GR.utf-8.xml
    • -39
    • +33
    ./catalog/acs-tcl.en_US.ISO-8859-1.xml
    • -5
    • +6
    ./catalog/acs-tcl.es_ES.ISO-8859-1.xml
    • -5
    • +5
    ./catalog/acs-tcl.gl_ES.ISO-8859-1.xml
    • -8
    • +9
    ./catalog/acs-tcl.it_IT.ISO-8859-1.xml
    • -5
    • +5
    ./catalog/acs-tcl.nl_NL.ISO-8859-1.xml
    • -5
    • +5
    ./catalog/acs-tcl.nl_ZA.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/acs-tcl.pl_PL.utf-8.xml
    • -5
    • +5
    ./catalog/acs-tcl.pt_BR.ISO-8859-1.xml
    • -5
    • +5
    ./catalog/acs-tcl.ru_RU.utf-8.xml
    • -1
    • +1
    ./lib/actions.tcl
    • -1
    • +1
    ./lib/ad-return-complaint.adp
  16. … 8085 more files in changeset.
2:59 pm

gustafn

small fix, when cookie times out and dotlrn is active

Options
    • -1
    • +4
    ./tcl/security-procs.tcl
Monday 02 Sep
2:54 pm

gustafn

bumped version number from development version to release version

Options
    • -5
    • +5
    ./acs-tcl.info
  2. … 93 more files in changeset.
Saturday 31 Aug
11:46 am

gustafn

improved test case

- load first mime package before loading it

- provide version of the mime package in the test log

- don't provide ns_set id as "error"

Options
    • -9
    • +18
    ./tcl/test/html-email-procs.tcl
11:37 am

gustafn

documented command result

Options
    • -1
    • +3
    ./tcl/html-email-procs.tcl
Thursday 29 Aug
10:37 am

gustafn

Use "ns_mkdtemp" when available to create temporary directories

Options
    • -0
    • +1
    ./tcl/00-icanuse-procs.tcl
    • -13
    • +27
    ./tcl/utilities-procs.tcl
Wednesday 28 Aug
4:27 pm

gustafn

cleanup tmp directories created by the acs-tcl regression test

Options
    • -0
    • +2
    ./tcl/test/apm-file-procs.tcl
    • -0
    • +3
    ./tcl/test/utilities-procs.tcl
8:44 am

gustafn

whitespace changes

Options
    • -1
    • +0
    ./tcl/00-acs-tcl-init.tcl
    • -1
    • +1
    ./tcl/acs-cache-init.tcl
    • -1
    • +1
    ./tcl/acs-container-procs.tcl
    • -2
    • +96
    ./tcl/deprecated-procs.tcl
    • -2
    • +2
    ./tcl/ds-stub-procs.tcl
    • -5
    • +5
    ./tcl/html-email-procs.tcl
    • -2
    • +1
    ./tcl/http-auth-procs.tcl
    • -3
    • +3
    ./tcl/json-procs.tcl
    • -2
    • +2
    ./tcl/memoize-procs.tcl
    • -3
    • +3
    ./tcl/pdf-procs.tcl
    • -1
    • +1
    ./tcl/site-nodes-procs.tcl
    • -105
    • +0
    ./tcl/sql-statement-procs.tcl
    • -1
    • +0
    ./tcl/test/acs-db-00-procs.tcl
    • -1
    • +1
    ./tcl/test/acs-tcl-apm-procs.tcl
    • -4
    • +4
    ./tcl/test/acs-tcl-test-procs.tcl
  16. … 7 more files in changeset.