OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 1
Total Committers: 73
Last Commit: 12:10
Commits this week: 1
Total Lines of Code (LoC): 74,843
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 08 Oct
5:20 pm

antoniop

No need to fiddle in the ad_conn array if we just reset it

Options
    • -6
    • +2
    ./tcl/request-processor-procs.tcl
5:16 pm

antoniop

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -9
    • +7
    ./tcl/apm-install-procs.tcl
  2. … 3 more files in changeset.
4:13 pm

antoniop

Prefer unset to array unset when the whole array should be deleted, rework array idioms into dict idioms to avoid unsetting the array, where appropriate

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -5
    • +7
    ./tcl/apm-install-procs.tcl
    • -5
    • +5
    ./tcl/apm-procs.tcl
    • -1
    • +1
    ./tcl/form-processing-procs.tcl
    • -8
    • +6
    ./tcl/site-nodes-procs.tcl
    • -2
    • +2
    ./tcl/text-html-procs.tcl
11:30 am

antoniop

Limit files__tcl_file_common_errors test to installed packages

Unmaintained packages may ship files with invalid encodings, which tcl9 won't tolerate anymore.

Options
    • -2
    • +13
    ./tcl/test/file-test-procs.tcl
Monday 07 Oct
6:02 pm

antoniop

Improve test

- skip packages that are not installed before we check the info file

- ensure all installed packages have an info file

This fixes the test for tcl9, where some unmaintained packages may fail the file parsing because of invalid encoding.

Options
    • -5
    • +21
    ./tcl/test/file-test-procs.tcl
Tuesday 01 Oct
2:52 pm

gustafn

Tcl9 regression test: deactivated case broken in tcl9 with unclear semantics

Options
    • -40
    • +45
    ./tcl/test/http-client-procs.tcl
2:50 pm

gustafn

whitespace change

Options
    • -4
    • +4
    ./tcl/acs-db-12-procs.tcl
2:44 pm

gustafn

tcl9 changes: "string bytelength" does not exist in tcl9

Options
    • -13
    • +12
    ./tcl/test/00-icanuse-procs.tcl
  2. … 1 more file in changeset.
Sunday 29 Sep
6:29 am

gustafn

removed file deleted in branch oacs-5-10

Options
    • -3810
    • +0
    ./tcl/00-database-procs.tcl
Tuesday 24 Sep
1:44 pm

antoniop

Ensure we fail the check and complain when a localurl is invalid

Options
    • -10
    • +15
    ./tcl/tcl-documentation-procs.tcl
Thursday 19 Sep
12:59 pm

antoniop

Fix passing complaints info to the complain template

Options
    • -3
    • +5
    ./tcl/tcl-documentation-procs.tcl
Wednesday 11 Sep
8:11 am

gustafn

merge with missing files

Options
    • -0
    • +0
    ./lib/page-error.tcl
    • -0
    • +0
    ./tcl/01-database-procs-oracle.tcl
    • -0
    • +0
    ./tcl/01-database-procs-postgresql.tcl
    • -0
    • +0
    ./tcl/01-database-procs.tcl
    • -0
    • +0
    ./tcl/10-charset-compat-procs.tcl
    • -0
    • +0
    ./tcl/acs-kernel-procs.tcl
    • -0
    • +0
    ./tcl/acs-permissions-procs.tcl
    • -0
    • +0
    ./tcl/acs-private-data-procs.tcl
    • -0
    • +0
    ./tcl/ad-functional-procs.tcl
    • -0
    • +0
    ./tcl/admin-init.tcl
    • -0
    • +0
    ./tcl/admin-procs.tcl
    • -0
    • +0
    ./tcl/adp-parser-procs.tcl
    • -0
    • +0
    ./tcl/aolserver-3-procs.tcl
    • -0
    • +0
    ./tcl/apm-file-procs.tcl
    • -0
    • +0
    ./tcl/apm-install-procs.tcl
  16. … 1450 more files in changeset.
Tuesday 03 Sep
5:37 pm

gustafn

merge from oacs-5-10

Options
    • -7
    • +8
    ./acs-tcl.info
    • -1
    • +1
    ./catalog/acs-tcl.ca_ES.ISO-8859-1.xml
    • -18
    • +19
    ./catalog/acs-tcl.de_DE.ISO-8859-1.xml
    • -5
    • +5
    ./catalog/acs-tcl.el_GR.utf-8.xml
    • -39
    • +33
    ./catalog/acs-tcl.en_US.ISO-8859-1.xml
    • -5
    • +6
    ./catalog/acs-tcl.es_ES.ISO-8859-1.xml
    • -5
    • +5
    ./catalog/acs-tcl.gl_ES.ISO-8859-1.xml
    • -8
    • +9
    ./catalog/acs-tcl.it_IT.ISO-8859-1.xml
    • -5
    • +5
    ./catalog/acs-tcl.nl_NL.ISO-8859-1.xml
    • -5
    • +5
    ./catalog/acs-tcl.nl_ZA.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/acs-tcl.pl_PL.utf-8.xml
    • -5
    • +5
    ./catalog/acs-tcl.pt_BR.ISO-8859-1.xml
    • -5
    • +5
    ./catalog/acs-tcl.ru_RU.utf-8.xml
    • -1
    • +1
    ./lib/actions.tcl
    • -1
    • +1
    ./lib/ad-return-complaint.adp
  16. … 8085 more files in changeset.
2:59 pm

gustafn

small fix, when cookie times out and dotlrn is active

Options
    • -1
    • +4
    ./tcl/security-procs.tcl
Monday 02 Sep
2:54 pm

gustafn

bumped version number from development version to release version

Options
    • -5
    • +5
    ./acs-tcl.info
  2. … 93 more files in changeset.
Saturday 31 Aug
11:46 am

gustafn

improved test case

- load first mime package before loading it

- provide version of the mime package in the test log

- don't provide ns_set id as "error"

Options
    • -9
    • +18
    ./tcl/test/html-email-procs.tcl
11:37 am

gustafn

documented command result

Options
    • -1
    • +3
    ./tcl/html-email-procs.tcl
Thursday 29 Aug
10:37 am

gustafn

Use "ns_mkdtemp" when available to create temporary directories

Options
    • -0
    • +1
    ./tcl/00-icanuse-procs.tcl
    • -13
    • +27
    ./tcl/utilities-procs.tcl
Wednesday 28 Aug
4:27 pm

gustafn

cleanup tmp directories created by the acs-tcl regression test

Options
    • -0
    • +2
    ./tcl/test/apm-file-procs.tcl
    • -0
    • +3
    ./tcl/test/utilities-procs.tcl
8:44 am

gustafn

whitespace changes

Options
    • -1
    • +0
    ./tcl/00-acs-tcl-init.tcl
    • -1
    • +1
    ./tcl/acs-cache-init.tcl
    • -1
    • +1
    ./tcl/acs-container-procs.tcl
    • -2
    • +96
    ./tcl/deprecated-procs.tcl
    • -2
    • +2
    ./tcl/ds-stub-procs.tcl
    • -5
    • +5
    ./tcl/html-email-procs.tcl
    • -2
    • +1
    ./tcl/http-auth-procs.tcl
    • -3
    • +3
    ./tcl/json-procs.tcl
    • -2
    • +2
    ./tcl/memoize-procs.tcl
    • -3
    • +3
    ./tcl/pdf-procs.tcl
    • -1
    • +1
    ./tcl/site-nodes-procs.tcl
    • -105
    • +0
    ./tcl/sql-statement-procs.tcl
    • -1
    • +0
    ./tcl/test/acs-db-00-procs.tcl
    • -1
    • +1
    ./tcl/test/acs-tcl-apm-procs.tcl
    • -4
    • +4
    ./tcl/test/acs-tcl-test-procs.tcl
  16. … 7 more files in changeset.
8:32 am

gustafn

improve source code documentation

Options
    • -3
    • +6
    ./tcl/request-processor-procs.tcl
8:32 am

gustafn

added icanuse handler for "ns_info meminfo"

Options
    • -0
    • +1
    ./tcl/00-icanuse-procs.tcl
8:31 am

gustafn

new function: ad_unless_script_abort and bump version to 5.10.1b12

This convenience function eases handling of ad_script_abort exceptions

in cases, where the OpenACS request processor is not involved.

From the documentation:

Execute the provided body in the callers' environment. When the

body does not raise an "ad_script_abort" exception, the

"non_abort_action" is also executed. This pattern is useful when

handling client requests and where the "non_abort_action" is used

to return results to the client. When "ad_script_abort" is

executed, the connection is usually closed, and any attempt to

talk to the client over the closed connection will fail.

The handling of script_abort exceptions is done usually in the

request processor. The function is useful when registering own

request procs (e.g., via "ns_register_proc") where the OpenACS

request processor is not involved.

bumped version to 5.10.1b12

Options
    • -2
    • +2
    ./acs-tcl.info
    • -1
    • +35
    ./tcl/exception-procs.tcl
Tuesday 27 Aug
7:24 pm

gustafn

take out "nsstats" from the tests for page_contracts

Options
    • -5
    • +6
    ./tcl/test/file-test-procs.tcl
    • -49
    • +0
    ./tcl/test/log-test-procs.tcl
4:06 pm

gustafn

silence regression test

Options
    • -1
    • +3
    ./tcl/test/doc-check-procs.tcl
    • -1
    • +4
    ./tcl/test/security-procs.tcl
3:55 pm

gustafn

reduce verbosity during regression test

Options
    • -1
    • +5
    ./tcl/test/acs-tcl-test-procs.tcl
    • -6
    • +4
    ./tcl/test/ad-proc-test-procs.tcl
3:37 pm

gustafn

do not complain about expected behavior

Options
    • -7
    • +7
    ./tcl/apm-install-procs.tcl
3:22 pm

gustafn

silence regression test

Options
    • -5
    • +32
    ./tcl/test/ad-proc-test-procs.tcl
    • -4
    • +9
    ./tcl/test/datamodel-test-procs.tcl
3:21 pm

gustafn

don't expect that invalid input becomes magically valid

Options
    • -2
    • +2
    ./tcl/test/html-conversion-procs.tcl
3:20 pm

gustafn

reduce verbosity

Options
    • -18
    • +1
    ./tcl/community-core-procs.tcl
    • -2
    • +2
    ./tcl/test/text-html-procs.tcl